From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE2ABC61DA4 for ; Wed, 15 Mar 2023 22:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jmSfz9N+//kQsYTUB2G37HioVGhLuHk6TCWmv+9CN8s=; b=e46hobrrypGusB WrSe3vc9afj2X4Z6bPlofKWerpjz5dShpv6j3343fKrt5H2XLn8DX5a9EK1TAmoZMZH9gd3QZnS8x uSueT0RjaKHzCSsrLcdK9Ggj2NvfksdZjUBRZIngmF4cNwUJWkrgYohadpzXmYlxabA7BNSW6TBUB J+s9EeyejLJoqhlUfDMv3/f/MZZGY4+f+k+y/b46ikG/bQOhjQPOtBMDU2xzKENX+IjZXQcXUfxC7 375+tOJYOkX7y4OOi7bzGegjvgphcUWrRplByk6CMBy//7dEDud2B61LqkXeUfAAytdU1qpBAdCLA CqU5W5FYv5RT6zLiumsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcZvs-00EduQ-2r; Wed, 15 Mar 2023 22:49:20 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcZvp-00EdsZ-0Q for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 22:49:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678920557; x=1710456557; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Hn1T9lfJLT4sd3ZWTd7QnFSn+OPgoQxCfE5guxD4r0Q=; b=PYN5m5raoziw9SMfj/c0qGge6MMMOBwPJQIv632d/Fh7Bc/oyMPhJlIs z/zPZUQWxNDieC2JB0V3mHZ0TX5HyCfEEqghgRPC78d2nIBAtq96/eakE xxO3Tby4QP9HhZT5xM+ljWdvDisZz7XvT3751Bl+NiFXaGeWmjbNlGI81 ZYqBrzOihU5WneOX09FvQ+pQCRU7a/eEo9faCQoXiKsI/4/IrUkydedTQ ArNbH7SaoeVedo1DcfaOLgZibwd5GnaqGDP5XuOOC/OIYaiCYAXvcPN0D A3kGchv426xNd3b7PSOP1XnKQw0+BhihprO1k8xy/ocRksduv9aYAfnof w==; X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="339371195" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="339371195" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 15:49:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10650"; a="682034502" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="682034502" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 15 Mar 2023 15:49:12 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pcZvj-000862-0e; Wed, 15 Mar 2023 22:49:11 +0000 Date: Thu, 16 Mar 2023 06:48:48 +0800 From: kernel test robot To: Shanker Donthineni , Marc Zyngier , Catalin Marinas , Will Deacon , Jonathan Corbet , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Shanker Donthineni , Vikram Sethi , Thierry Reding Subject: Re: [PATCH v2] irqchip/gicv3: Workaround for NVIDIA erratum T241-FABRIC-4 Message-ID: <202303160647.R16cnZkc-lkp@intel.com> References: <20230314135128.2930580-1-sdonthineni@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230314135128.2930580-1-sdonthineni@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_154917_213001_7FF78C8C X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shanker, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on tip/irq/core soc/for-next linus/master v6.3-rc2 next-20230315] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shanker-Donthineni/irqchip-gicv3-Workaround-for-NVIDIA-erratum-T241-FABRIC-4/20230314-215648 base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core patch link: https://lore.kernel.org/r/20230314135128.2930580-1-sdonthineni%40nvidia.com patch subject: [PATCH v2] irqchip/gicv3: Workaround for NVIDIA erratum T241-FABRIC-4 config: arm-randconfig-r046-20230315 (https://download.01.org/0day-ci/archive/20230316/202303160647.R16cnZkc-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f796361134151057b68a259013204e8fa5516aee git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shanker-Donthineni/irqchip-gicv3-Workaround-for-NVIDIA-erratum-T241-FABRIC-4/20230314-215648 git checkout f796361134151057b68a259013204e8fa5516aee # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/irqchip/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303160647.R16cnZkc-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/linux/bits.h:6, from include/linux/ioport.h:13, from include/linux/acpi.h:12, from drivers/irqchip/irq-gic-v3.c:9: drivers/irqchip/irq-gic-v3.c: In function 'gic_enable_quirk_nvidia_t241': >> drivers/irqchip/irq-gic-v3.c:1775:35: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration] 1775 | chip_bmask |= BIT(FIELD_GET(T241_CHIPN_MASK, | ^~~~~~~~~ include/vdso/bits.h:7:44: note: in definition of macro 'BIT' 7 | #define BIT(nr) (UL(1) << (nr)) | ^~ >> drivers/irqchip/irq-gic-v3.c:1786:33: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration] 1786 | phys |= FIELD_PREP(T241_CHIPN_MASK, i); | ^~~~~~~~~~ cc1: some warnings being treated as errors vim +1775 drivers/irqchip/irq-gic-v3.c 1760 1761 static bool gic_enable_quirk_nvidia_t241(void *data) 1762 { 1763 unsigned long chip_bmask = 0; 1764 phys_addr_t phys; 1765 u32 i; 1766 1767 /* Check JEP106 code for NVIDIA T241 chip (036b:0241) */ 1768 if ((smccc_soc_id_version < 0) || 1769 ((smccc_soc_id_version & SMCCC_SOC_ID_MASK) != SMCCC_SOC_ID_T241)) { 1770 return false; 1771 } 1772 1773 /* Find the chips based on GICR regions PHYS addr */ 1774 for (i = 0; i < gic_data.nr_redist_regions; i++) { > 1775 chip_bmask |= BIT(FIELD_GET(T241_CHIPN_MASK, 1776 gic_data.redist_regions[i].phys_base)); 1777 } 1778 1779 if (hweight32(chip_bmask) < 3) 1780 return false; 1781 1782 /* Setup GICD alias regions */ 1783 for (i = 0; i < ARRAY_SIZE(t241_dist_base_alias); i++) { 1784 if (chip_bmask & BIT(i)) { 1785 phys = gic_data.dist_phys_base + T241_CHIP_GICDA_OFFSET; > 1786 phys |= FIELD_PREP(T241_CHIPN_MASK, i); 1787 t241_dist_base_alias[i] = ioremap(phys, SZ_64K); 1788 WARN_ON_ONCE(!t241_dist_base_alias[i]); 1789 } 1790 } 1791 static_branch_enable(&gic_nvidia_t241_erratum); 1792 return true; 1793 } 1794 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel