From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B943C7618D for ; Thu, 16 Mar 2023 15:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a0qZyyfjLNaJyGAE3FDEYPMr8S6egI7pv3AMyd3nlEY=; b=CBHWjaZ6D5w2jq Fjc8GqZ5cPx2NUM3QmGZK7XrTsw+hE8PBSBym/KZmwHtgBZj77yYQHVGgiYKmBYkdB6kF0BBKclM2 h70HqZN7WUeT2f4MLhgYhBUt7uELp4TzFeM4WQ/CVybATvTanOvt8L9ansYlZKWIW/cVsyiZI3S+5 6cE9QGI+VU82zGIcdMnP7UOQsfWwcU051TcuMXe9yA68IRNdEfz8XcOB1zJhGKoaqbyt3JUxN1lUQ R/0QxaAcJzj/TLn7BUhQ453uOIkjzKET6InWDSqUdQ9cVw+T1rq1uGfTqzGlMnxsBqdr02G0kl31K 5xUpDCksqxj4COxw1HVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcp7Y-00GlIw-0f; Thu, 16 Mar 2023 15:02:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcp7V-00GlIL-0a for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 15:02:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B308C2F4; Thu, 16 Mar 2023 08:03:02 -0700 (PDT) Received: from bogus (unknown [10.57.52.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 93FED3F67D; Thu, 16 Mar 2023 08:02:17 -0700 (PDT) Date: Thu, 16 Mar 2023 15:01:44 +0000 From: Sudeep Holla To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/30] clk: scpi: Convert to platform remove callback returning void Message-ID: <20230316150144.2aap5otmgblj24ty@bogus> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-16-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312161512.2715500-16-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_080221_271944_05B05C5A X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 12, 2023 at 05:14:57PM +0100, Uwe Kleine-K=F6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > Acked-by: Sudeep Holla Let me know if you want me to pick up instead. -- = Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel