From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A284EC74A5B for ; Fri, 17 Mar 2023 00:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7uEhmCyGuamqrn8PJ3WfiL5jXQ/r70W8baEEMmSk7iA=; b=cP91r2fHyfzxz1 d30O2Hz+o9cL/rk0y/9DqekatR3GueQwYwfb7BaJ/WS10cTZohcWJY4MTgmhPD4RqEwPUsMvTVfeb RvMbrIVy0CybD8sqXtb48/8yHeqssqxSy7OJyCed9Vgo01SeF83zlh+ebLLEQ3EUZ4l/fkW+sgoWf j5UdYFjB5SQz6nxZbgR6KFAEeNuhJyktCJnwr9qR+E4DeSpZn1ZUuX6Z/xv47wEInPRHM/zrlDS9/ la1vFPILSo0RmDirIFNZvwKOSwAC2hMAahDX3WRGnQdJBUiC3gjz8rTeL0D3HDatalgqkPc8Eyv3l u+fQd/1XlRjbhYqMK3rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcxXc-000NpC-1J; Fri, 17 Mar 2023 00:01:52 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcxXY-000Nlv-1S for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 00:01:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8FEEDCE1D32; Fri, 17 Mar 2023 00:01:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D02DC433EF; Fri, 17 Mar 2023 00:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679011288; bh=hTYgEnMkyE64wnXsk3avUA5GCBJ8kbqVBwnmO0El23w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mypInJB7USBxQTN7HvThfy/CAw1zfzkM+ju9mTokOdz/uj0tuVPYUCuC+Y5HM3AWi Ar+wZyMFzHVje5vIzYY79u0DpGUqhKOkETv6ZGZb80uT+dGLD3wZcvf9B/rOMjIUrG HbAwQWFw2Yh4V3bu/vDt7XAgb3kJZzUtpNGrheUjeCco69BP9N/QRSFXeDSV6P0Xmd EHlmapHbhpWZbGBo7HJdrRbP3HIIGeJBJUI8HFU61wrTzwQsERKXGSs1XMXza4ULqH lzv8gDeATgqg9E0sHBOOOZ3fQtNSdnpY7ZRUrxWjzFb2hKmMEdwQDBAXJJ3iRCCIdZ SJY7Sq6DgwSWQ== Date: Thu, 16 Mar 2023 17:01:27 -0700 From: Jakub Kicinski To: Michael Sit Wei Hong , Ong Boon Leong Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Voon Weifeng , Lai Peter Jun Ann Subject: Re: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup code Message-ID: <20230316170127.5bbd559d@kernel.org> In-Reply-To: <20230314070208.3703963-3-michael.wei.hong.sit@intel.com> References: <20230314070208.3703963-1-michael.wei.hong.sit@intel.com> <20230314070208.3703963-3-michael.wei.hong.sit@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_170148_663767_56AFBBA7 X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 14 Mar 2023 15:02:08 +0800 Michael Sit Wei Hong wrote: > xpcs_an_inband value is updated in the speed_mode_2500 function > which turns on the xpcs_an_inband mode. > > Moving the fixed-link fixup code to right before phylink setup to > ensure no more fixup will affect the fixed-link mode configurations. > > Fixes: 72edaf39fc65 ("stmmac: intel: add phy-mode and fixed-link ACPI _DSD setting support") > Signed-off-by: Michael Sit Wei Hong Ong Boon, since you added the code which gets moved - could we get an ack/review tag from you? Helps increase the confidence in the change. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel