* [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment
@ 2023-03-16 8:40 Yang Li
2023-03-16 8:44 ` AngeloGioacchino Del Regno
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yang Li @ 2023-03-16 8:40 UTC (permalink / raw)
To: andersson
Cc: mathieu.poirier, matthias.bgg, angelogioacchino.delregno,
linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
Yang Li, Abaci Robot
Fixs the function name in kernel-doc comments to clear the below
warning:
drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/remoteproc/mtk_scp_ipi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c
index fc55df649b40..9c7c17b9d181 100644
--- a/drivers/remoteproc/mtk_scp_ipi.c
+++ b/drivers/remoteproc/mtk_scp_ipi.c
@@ -125,7 +125,7 @@ void scp_ipi_lock(struct mtk_scp *scp, u32 id)
EXPORT_SYMBOL_GPL(scp_ipi_lock);
/**
- * scp_ipi_lock() - Unlock after operations of an IPI ID
+ * scp_ipi_unlock() - Unlock after operations of an IPI ID
*
* @scp: mtk_scp structure
* @id: IPI ID
--
2.20.1.7.g153144c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment
2023-03-16 8:40 [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment Yang Li
@ 2023-03-16 8:44 ` AngeloGioacchino Del Regno
2023-03-16 8:47 ` Mukesh Ojha
2023-03-16 18:14 ` Mathieu Poirier
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-16 8:44 UTC (permalink / raw)
To: Yang Li, andersson
Cc: mathieu.poirier, matthias.bgg, linux-remoteproc, linux-kernel,
linux-arm-kernel, linux-mediatek, Abaci Robot
Il 16/03/23 09:40, Yang Li ha scritto:
> Fixs the function name in kernel-doc comments to clear the below
> warning:
>
> drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment
2023-03-16 8:40 [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment Yang Li
2023-03-16 8:44 ` AngeloGioacchino Del Regno
@ 2023-03-16 8:47 ` Mukesh Ojha
2023-03-16 18:14 ` Mathieu Poirier
2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2023-03-16 8:47 UTC (permalink / raw)
To: Yang Li, andersson
Cc: mathieu.poirier, matthias.bgg, angelogioacchino.delregno,
linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
Abaci Robot
On 3/16/2023 2:10 PM, Yang Li wrote:
> Fixs the function name in kernel-doc comments to clear the below
nit: Fix
> warning:
>
> drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/remoteproc/mtk_scp_ipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c
> index fc55df649b40..9c7c17b9d181 100644
> --- a/drivers/remoteproc/mtk_scp_ipi.c
> +++ b/drivers/remoteproc/mtk_scp_ipi.c
> @@ -125,7 +125,7 @@ void scp_ipi_lock(struct mtk_scp *scp, u32 id)
> EXPORT_SYMBOL_GPL(scp_ipi_lock);
>
> /**
> - * scp_ipi_lock() - Unlock after operations of an IPI ID
> + * scp_ipi_unlock() - Unlock after operations of an IPI ID
> *
> * @scp: mtk_scp structure
> * @id: IPI ID
Otherwise LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-- Mukesh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment
2023-03-16 8:40 [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment Yang Li
2023-03-16 8:44 ` AngeloGioacchino Del Regno
2023-03-16 8:47 ` Mukesh Ojha
@ 2023-03-16 18:14 ` Mathieu Poirier
2 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2023-03-16 18:14 UTC (permalink / raw)
To: Yang Li
Cc: andersson, matthias.bgg, angelogioacchino.delregno,
linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek,
Abaci Robot
On Thu, Mar 16, 2023 at 04:40:11PM +0800, Yang Li wrote:
> Fixs the function name in kernel-doc comments to clear the below
> warning:
>
> drivers/remoteproc/mtk_scp_ipi.c:136: warning: expecting prototype for scp_ipi_lock(). Prototype was for scp_ipi_unlock() instead
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4544
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/remoteproc/mtk_scp_ipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c
> index fc55df649b40..9c7c17b9d181 100644
> --- a/drivers/remoteproc/mtk_scp_ipi.c
> +++ b/drivers/remoteproc/mtk_scp_ipi.c
> @@ -125,7 +125,7 @@ void scp_ipi_lock(struct mtk_scp *scp, u32 id)
> EXPORT_SYMBOL_GPL(scp_ipi_lock);
>
> /**
> - * scp_ipi_lock() - Unlock after operations of an IPI ID
> + * scp_ipi_unlock() - Unlock after operations of an IPI ID
I have applied this patch.
Thanks,
Mathieu
> *
> * @scp: mtk_scp structure
> * @id: IPI ID
> --
> 2.20.1.7.g153144c
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-16 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-16 8:40 [PATCH -next] remoteproc/mtk_scp: Fix one kernel-doc comment Yang Li
2023-03-16 8:44 ` AngeloGioacchino Del Regno
2023-03-16 8:47 ` Mukesh Ojha
2023-03-16 18:14 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).