From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10671C6FD1D for ; Fri, 17 Mar 2023 07:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V+KpQ06jY3kR9A5ZBmz5MGr1xTsPBb5d2viX4aTb5z8=; b=EKS+eeRg6kvXCr TdYQVB82JMNtRRTeDaN/SXnDxL/NizuHVrxkzCW8g13pR2TAJKRQe0VWpiiwfY+hWuZYRhGXbL0/b 9Wsfl1ChiO4PFuVIT47MGHfiGcjgP/mF5hRw4FYvD/3DxNkjKX5Blth970d/oOt7hgLbWPIv4X9ut J6cVsj5yW+Ppg1oWnN+/yJ9YfPhf+3GNKVdl4lnVmR4GYQXegOY4bXZAlL3FcrWGrN6+0XPJF3xex /PW8zIpVUzhwSQg0K3L267s7vx9JYzg2rhoKINSX6EfnPPwPDaL7IC90PKWgp5qk8+DRf1LbpYTpx zt6NA2coZ0gBu4XIQ9zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd4mJ-001KSV-0D; Fri, 17 Mar 2023 07:45:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pd4mH-001KRd-00 for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 07:45:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C61FB621CF; Fri, 17 Mar 2023 07:45:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B4F0C433EF; Fri, 17 Mar 2023 07:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679039127; bh=uMC+mKisSczlSP5vnGYRs4BuFUpa/scNus377rX44J0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sR3e/4eBXDoo1W3Jp5JGHJIuY0EK//4Pc6SkXzWsmHNRPPWeWk5A++HMSz+evmAhV uVweUDEqfJ8E0ANk3QGoxnYfzl+Qs5dTXYEjhXGm+4v1r1oxGLry60xFLpEP6P9PhV C2CXnlIU78mjBM0m2zhMIMc1Ir8uVdrNPjtjeo8x3fSO+L1HlQAyIgteuTU2c4MXEJ AAnGDsVgHFIqKbYICDx2wrZhnbjvuARW/F/omqPeO+vBXa+GU+8J7Dp1zGVSaB9URk 0+r4L8Bn4nn5bQhY0s9mYHMDybNH5RF6eMA/6smCj1IPkDD8A44PYjFpEthj90xNTe d94fS/VAl+DAA== Date: Fri, 17 Mar 2023 08:45:19 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v4 04/14] net: phy: Add a binding for PHY LEDs Message-ID: <20230317084519.12d3587a@dellmb> In-Reply-To: <20230317023125.486-5-ansuelsmth@gmail.com> References: <20230317023125.486-1-ansuelsmth@gmail.com> <20230317023125.486-5-ansuelsmth@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_004529_122879_40126545 X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Mar 2023 03:31:15 +0100 Christian Marangi wrote: > + cdev->brightness_set_blocking = phy_led_set_brightness; > + cdev->max_brightness = 1; > + init_data.devicename = dev_name(&phydev->mdio.dev); > + init_data.fwnode = of_fwnode_handle(led); > + > + err = devm_led_classdev_register_ext(dev, cdev, &init_data); Since init_data.devname_mandatory is false, devicename is ignored. Which is probably good, becuse the device name of a mdio device is often ugly, taken from devicetree or switch drivers, for example: f1072004.mdio-mii fixed-0 mv88e6xxx-1 So either don't fill devicename or use devname_mandatory (and maybe fill devicename with something less ugly, but I guess if we don't have much choice if we want to keep persistent names). Without devname_mandatory, the name of the LED classdev will be of the form color:function[-function-enumerator], i.e. green:lan amber:lan-1 With multiple switch ethenret ports all having LAN function, it is worth noting that the function enumerator must be explicitly used in the devicetree, otherwise multiple LEDs will be registered under the same name, and the LED subsystem will add a number at the and of the name (function led_classdev_next_name), resulting in names green:lan green:lan_1 green:lan_2 ... These names are dependent on the order of classdev registration. Marek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel