From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C949AC6FD1D for ; Fri, 17 Mar 2023 18:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lsWOkDTQEUBzA7zYBs8bDaihI2LV7P+k6WtpD+/HCr8=; b=gAHXHw4M8s63c1 R6pi3cn6L/QRGlCb14u28QVEE5ivquVvRAFPskJDlQ1Q4yd9lGVSPXtsMevus1nVpepYPn5pQLxfu 2jAKKqnDtz8vdUWXbGezWm0M8l1qv7rf3j4rd+Q11kr5VTkHSojfPKvz4kbEIG/vFHCqYFAfEddxr jC2tat2Urp7pkJ0AoR1Ex68/KhuTdEC8Xh09VRMr64jZ0Rg4ltQGHmWrtRuP2HC1dIVwnzOyKBbY6 rl7lQHb0L5bfneVGshPlkQJ4IHOm60uiqlg93cUiO3ADNrN1GqJF51+cmftQb35/t8RciIdZOLMMI KDivARTbt9W0VRJbU4uQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdEji-0030pQ-2t; Fri, 17 Mar 2023 18:23:30 +0000 Received: from mail-io1-f48.google.com ([209.85.166.48]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdEjg-0030oS-1v for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 18:23:29 +0000 Received: by mail-io1-f48.google.com with SMTP id p17so934671ioj.10 for ; Fri, 17 Mar 2023 11:23:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679077405; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YY5kvROBmAIjw6Dx4gFwNzn0Rq7UyRKCnLAFPdvlxE0=; b=pwuIvQx2xoNpticL8ifrVnOxXCtHOC1xgcYa1wh3TWmmqLlMg20U/GZBDaoqt4gTCA TrAS6DmLobXbCzMFoF5IwHBqBsSrYtQtt3BMVPwRFPjlL+eYbQIcCmiJw70+fYv1dd85 o1twSLnnEjQykr4IkSKQa0c6KUdtub+OT5NMS1AzlmKx9AU9L7NYwwOlJcsO8X/lRwd5 XsJlexfSnuajnhbhL0rtcbPOM5gQiuAyU5t8h0n4SZXdJLrak8Cp7/HlubqEPxjumuqc qY6LVfaXO8Ec3EpGxJogPEYhHaTFYclNLIr8RU1nLHev0cecLDPww87XZA9g52M3aZ12 om2g== X-Gm-Message-State: AO0yUKXSV8kzj7LOuPo1XREUVDqERtGLCPDF41HX0NJUodGgXc5Po4DX RmyhODBTecGY74LeDXT9JA== X-Google-Smtp-Source: AK7set+NBOhE/BlrvZHskphjTYZF6T6DcdgvpFdLKzZVNY9P5Z4F1Ye4FXKATFWy0j0uztmzyjmHFA== X-Received: by 2002:a5e:8b03:0:b0:6ea:6c79:d21d with SMTP id g3-20020a5e8b03000000b006ea6c79d21dmr289758iok.20.1679077404945; Fri, 17 Mar 2023 11:23:24 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id y10-20020a6be50a000000b007453a11bdf5sm756667ioc.13.2023.03.17.11.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 11:23:24 -0700 (PDT) Received: (nullmailer pid 2575814 invoked by uid 1000); Fri, 17 Mar 2023 18:23:23 -0000 Date: Fri, 17 Mar 2023 13:23:23 -0500 From: Rob Herring To: Elad Nachman Cc: thomas.petazzoni@bootlin.com, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, krzysztof.kozlowski+dt@linaro.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Robin Murphy Subject: Re: [PATCH v4 7/8] PCI: dwc: Introduce configurable DMA mask Message-ID: <20230317182323.GA2445959-robh@kernel.org> References: <20230313124016.17102-1-enachman@marvell.com> <20230313124016.17102-8-enachman@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230313124016.17102-8-enachman@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_112328_635444_771F56C9 X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Robin On Mon, Mar 13, 2023 at 02:40:15PM +0200, Elad Nachman wrote: > From: Elad Nachman > > Some devices, such as AC5 and AC5X have their physical DDR memory > start at address 0x2_0000_0000. In order to have the DMA coherent > allocation succeed later, a different DMA mask is required, as > defined in the DT file for such SOCs, using dma-ranges. I'm afraid this is not right. 'dma-ranges' in the PCI host bridge node applies to PCI devices (i.e. child node), not the host bridge itself. It's 'dma-ranges' in the parent node of the host bridge that applies here. The core code will set masks (ranges really now) based on bus restrictions. The mask for the device should only be based on the device's limits (i.e. the device is 32-bit only). I think you will need whatever solution comes out of this thread[1]. Rob [1] https://lore.kernel.org/all/c014b074-6d7f-773b-533a-c0500e239ab8@arm.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel