From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1090C74A5B for ; Fri, 17 Mar 2023 18:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jUb9/XU2Z6ijiVUpIDg5+h9pxOjt9eejdDOXMLEnmh4=; b=EMetiIFMUXLiNi 2q9vR0RaVzmvWyKGXgIN6NgjXrFDsOsgW/xSL6W0V+zEm25uK/iyUtlyKHSRT0pEWFh1DSlvrdfy7 YU/2vsHAwEu7bIz5Tanz6gJ3MBfaoZU3WeuJd2tcGOmOYeY405lnN1ZFgdAts5dRffA3W6V7AgO7/ d773bJRZ1zutl/JjLZcNMYlWpMqxAKgFN0gZ8UQoqDTEdcXnmbQcjZ0VsP3Tp61hb08ap/1wgkDFx A6YM7x/clkEqRu52BqEqbBUOskMSTAMw7Ou1GJNoRNgQTkx1GUuzWMaZypfF7kTkBaUZ15xE0vLAp Vna+7zZQBTbD6bJg4NOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdEp0-0031sK-26; Fri, 17 Mar 2023 18:28:58 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdEox-0031rV-38 for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 18:28:57 +0000 Received: from pendragon.ideasonboard.com (i5C75E58C.versanet.de [92.117.229.140]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DE275AA; Fri, 17 Mar 2023 19:28:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679077733; bh=2mTQyPYbYhd9tHh9yIpZMUOlllKkWQTXKMhZaaiuzC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W0Eq8y5jLQHK/CW3yEDttk319cl2PXZn6DbhKqIv2lhmpI4NUfpAhF840BeC6OVWP gQuCY6VMiEHbf502ZtCljqSUGGLvndAq6012Ntjtl/c73TTn8jfqzcp1JTY0iu411B 0DpEnvasKExKkhOt88KBqOrv1l++MtemNBQfkiRE= Date: Fri, 17 Mar 2023 20:28:58 +0200 From: Laurent Pinchart To: Rui Miguel Silva Cc: Alexander Stein , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] media: imx: imx7-media-csi: Fix mbus framefmt field init Message-ID: <20230317182858.GB28322@pendragon.ideasonboard.com> References: <20230316143829.499039-1-alexander.stein@ew.tq-group.com> <20230316143829.499039-2-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_112856_156665_6E536F59 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Fri, Mar 17, 2023 at 05:20:55PM +0000, Rui Miguel Silva wrote: > Hi Alexander, > Thanks for the patch. > > Alexander Stein writes: > > > Default to non-interleaving. > > Why? Otherwise it is implicitly set to V4L2_FIELD_ANY as the structure is zero-initialized, and that's not a valid value for drivers to return to userspace. This should be explained in the commit message. > > Fixes: bc0d3df31ffe ("media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format()") > > It was never init to FIELD_NONE even before this patch, do you think it > is really a fix? Commit bc0d3df31ffe does indeed not seem relevant. The problem predates the destaging of the driver, it's a bit difficult to trace. I'd drop the Fixes: tag. > > Signed-off-by: Alexander Stein > > --- > > drivers/media/platform/nxp/imx7-media-csi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c > > index c22bf5c827e7..3e97b9f2ff69 100644 > > --- a/drivers/media/platform/nxp/imx7-media-csi.c > > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > > @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct imx7_csi *csi) > > format.code = IMX7_CSI_DEF_MBUS_CODE; > > format.width = IMX7_CSI_DEF_PIX_WIDTH; > > format.height = IMX7_CSI_DEF_PIX_HEIGHT; > > + format.field = V4L2_FIELD_NONE; > > > > imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL); > > csi->vdev_compose.width = format.width; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel