From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E49D2C74A5B for ; Fri, 17 Mar 2023 18:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zq66Y9cYSRd49gaUA0LtkMrMAfpZZNvpYlutW7uLrUs=; b=hZrkN+uy6NZMqw 4CrHSrTg3dDub1jLUCkkCCU3vCBPo8SJTCwH9CJAH/fHkfEBS8xgyB7iCH4obvZAgXMJCZNj0ac5+ SEf5QawvlCUOcTc/cfKIuf7x9Bcw34wOo6rfB0DKdgXCFtt350WywtCVxZXpe+ustbg4yseHZw86J W3FNDKsDZ729Sa2KKnz2ReMGtrplxhfqIePk0r7xWmoR/cXNdzfI8SNTTk/aVdk3hMQpC9IQC/l+Y aQbl1nC77UfSlM3dPwLaInDcCyErkIHQjWOwZkdi/Sn9Y0eMTx2pPrcaD0TzLQsHXzh0e73gQm9wB hFM0m4axiiKJjvrhQQhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdEs8-0032Se-26; Fri, 17 Mar 2023 18:32:12 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdEs5-0032RR-1w for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 18:32:10 +0000 Received: from pendragon.ideasonboard.com (i5C75E58C.versanet.de [92.117.229.140]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 144835AA; Fri, 17 Mar 2023 19:32:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679077928; bh=6/oM1KKGG8WY8ldnmAeeGvVgG8ROUWko+8FB/jF0Tv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Im94IrxJMB9c1zOYUtmBOHAQBWKu0r+Y8W5yIRpWwvO7Kz9xseey5J5O3pzXlqBTp alguIoGJbk4nP3/V+RQHh2p/H9W2BXekyUzOysvc59y0IZumvlbsEGe1mcl7QCBVZC AJS0GbSQ+HOsA9FASwGYnMWhWRu4pVHTjBik+t0I= Date: Fri, 17 Mar 2023 20:32:13 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Rui Miguel Silva , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] media: imx: imx7-media-csi: Fail on invalid type in VIDIOC_G_SELECTION Message-ID: <20230317183213.GC28322@pendragon.ideasonboard.com> References: <20230316143829.499039-1-alexander.stein@ew.tq-group.com> <20230316143829.499039-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230316143829.499039-3-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_113209_787592_D5DC90F9 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thank you for the patch. On Thu, Mar 16, 2023 at 03:38:28PM +0100, Alexander Stein wrote: > This device only supports video capture, so bail out if invalid > selection type is passed. > > Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx7-media-csi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c > index 3e97b9f2ff69..389d7d88b341 100644 > --- a/drivers/media/platform/nxp/imx7-media-csi.c > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > @@ -1214,6 +1214,9 @@ static int imx7_csi_video_g_selection(struct file *file, void *fh, > { > struct imx7_csi *csi = video_drvdata(file); > > + if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > + return -EINVAL; > + > switch (s->target) { > case V4L2_SEL_TGT_COMPOSE: > case V4L2_SEL_TGT_COMPOSE_DEFAULT: -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel