From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9008AC74A5B for ; Fri, 17 Mar 2023 21:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HiBamXYz38Z5kFwyLou36OeGuHe9tJGqPib/ZAG0eww=; b=HuLPG86rfDm6aA q1yx1lelTuE/pPRZR9iaR2qcmAdk6IqPsknlYVGWJou1zZy5FTc2oZ0eksSteAHslH8DxnHPNGMLj ohsO34OdXOSe+ZZSDW5+OpfeCBvy1c6vs7XrlFSavgHktZP9YM6SSa8KJMpEjXsrGb1S5TQFvpkgY V/EszIaqBSNFnDvu4G/fP6K5Y25WhOqQWd8VZuhtayBHBPGwcSCe1d78KQA1ZOHdhcAO3fSUPbrrL 69oWh1q90QYJBxOdzopMTu7ybpZegSN+WXbLD8EfG4zR8GhepmYfQ2xEFQrWVPQ/GwR+HnN4DoiaU ZDrX4FUBVQG6i5TxN7ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdHO3-003Phb-0n; Fri, 17 Mar 2023 21:13:19 +0000 Received: from mail-il1-f176.google.com ([209.85.166.176]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdHO0-003Pfl-1a for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 21:13:17 +0000 Received: by mail-il1-f176.google.com with SMTP id i19so3406065ila.10 for ; Fri, 17 Mar 2023 14:13:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679087583; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0cLT9nvbyGDO+rZS3qLUAHKtUfaXz4dTYvgAZ9mY5+E=; b=M0VbFs7YFiXI5v5jSymoIsntbh+mcPu4i0HbwEH7vWlug82YHjCOxuWRgelgVWfNo1 PogLsRVL1FvIxrs63EEmoiHc0kyOEBFHyzHP9iWCjpk0aXDgdMb1Aka9i401oQ13ihrN 8Hp0GArFP4YzZ8kJjWTJEjmjU9CuwoDnhomdWTgvzjjrvnUYH3cSPYqslnUKy2uQdCbj UgucCQMDa4ETwS2FsbUApEtop0InYzzVaWhVyMP353WNInhsutJ62+FGXr9qbRSGSUWE PUw1sf10z3WgxwUr2WSqpJcDojU5VI3OOhX7yUWlEKlkwl7omn54PAxXoNZzLVBSUvST KSDw== X-Gm-Message-State: AO0yUKWCpYDWZEJqZbsYGkFGrWy7f1CzT7OHUc/aQY6zZYhwqwjICuDS cnTmSqqJUktDbXyAmTRLgg== X-Google-Smtp-Source: AK7set+kHa11pPniVGqEyT+IX45l08nf/CPb3WXSyO/YNiwEYWD2EUMXyJV7HLcXyV4EPbUjxdWQlg== X-Received: by 2002:a92:d40c:0:b0:317:93dc:10f5 with SMTP id q12-20020a92d40c000000b0031793dc10f5mr33737ilm.19.1679087582684; Fri, 17 Mar 2023 14:13:02 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id i35-20020a056638382300b003a607dccd1bsm1009090jav.17.2023.03.17.14.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 14:13:02 -0700 (PDT) Received: (nullmailer pid 2814507 invoked by uid 1000); Fri, 17 Mar 2023 21:13:00 -0000 Date: Fri, 17 Mar 2023 16:13:00 -0500 From: Rob Herring To: Andrew Lunn Cc: Vladimir Oltean , Christian Marangi , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v3 09/14] dt-bindings: net: dsa: dsa-port: Document support for LEDs node Message-ID: <20230317211300.GA2811156-robh@kernel.org> References: <20230314101516.20427-1-ansuelsmth@gmail.com> <20230314101516.20427-1-ansuelsmth@gmail.com> <20230314101516.20427-10-ansuelsmth@gmail.com> <20230314101516.20427-10-ansuelsmth@gmail.com> <20230315005000.co4in33amy3t3xbx@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_141316_549653_AAEDDEAF X-CRM114-Status: GOOD ( 23.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 15, 2023 at 02:58:23AM +0100, Andrew Lunn wrote: > On Wed, Mar 15, 2023 at 02:50:00AM +0200, Vladimir Oltean wrote: > > On Tue, Mar 14, 2023 at 11:15:11AM +0100, Christian Marangi wrote: > > > Document support for LEDs node in dsa port. > > > Switch may support different LEDs that can be configured for different > > > operation like blinking on traffic event or port link. > > > > > > Also add some Documentation to describe the difference of these nodes > > > compared to PHY LEDs, since dsa-port LEDs are controllable by the switch > > > regs and the possible intergated PHY doesn't have control on them. > > > > > > Signed-off-by: Christian Marangi > > > --- > > > .../devicetree/bindings/net/dsa/dsa-port.yaml | 21 +++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > > Of all schemas, why did you choose dsa-port.yaml? Why not either something > > hardware specific (qca8k.yaml) or more generic (ethernet-controller.yaml)? > > The binding should be generic. So qca8k.yaml is way to specific. The > Marvell switch should re-use it at some point. > > Looking at the hierarchy, ethernet-controller.yaml would work since > dsa-port includes ethernet-switch-port, which includes > ethernet-controller. > > These are MAC LEDs, and there is no reason why a standalone MAC in a > NIC could not implement such LEDs. So yes, > ethernet-controller.yaml. > > Is there actually anything above ethernet-controller.yaml? Yes, the one under review[1]. Rob [1] https://lore.kernel.org/all/20230203-dt-bindings-network-class-v2-0-499686795073@jannau.net/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel