From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4585EC6FD1D for ; Fri, 17 Mar 2023 21:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9uzf7lXjBq1BePKSnkk/u4TW01XPurYHJzhH3cTFbBU=; b=RXWsURzbSNA44i R1xAjXlRrUuXSHoAOF6hg48VcWk03D1mu3ncFP+d8Tp/Ufr2W3bwzorwnHoNWNePN3Y19DuUy1pQC HlPvT1jAskIlMRvGryN3QkrOfOYKeoLIiUQv2KBIFGkg1bqslSlkluMeNcwbSVsruM/rYC5A7C9Kk 83x8+JrRtj/ZTpBlQJp7GAFoIjmWGXq/dzZuzSjKkRmzXbFgjv0UcO6bILeBRIxkUu3e8R2xvt0r+ x5PTwlujlXyCcbr3nkOUjaS+qANHGyyhKJOFKzLOoLTXSsNYpwnxm3edZ5cSf+leCG4cMZb6jAKgK j+i0U5qoxVhnXSqCbLrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdHR9-003Q4W-1k; Fri, 17 Mar 2023 21:16:31 +0000 Received: from mail-il1-f175.google.com ([209.85.166.175]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdHR6-003Q3J-2b for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 21:16:30 +0000 Received: by mail-il1-f175.google.com with SMTP id r4so3426053ila.2 for ; Fri, 17 Mar 2023 14:16:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679087785; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E8EReBm37JWyJO8L1kIPOgKUl1U5FCQclLtDZ/qXfAs=; b=F1vNawOeOHuvaVnXMrRynQy0AwHnvXwYkU2C3ROzzYISosHed55jqnRfNzS655+Co5 M6DwqcSsjZcvH7HjsC1etRf8Dn98ogEmrxNAaEEC/mOo2+0q4T6rcv6Y6940dGPMTqZJ ecPpiPrZaq3H022QMAVn3wkSOryy8j4QoCxXijgn7jIiXzMboSKK6S13MX89DepKnF4K tA7j6J5W2RE/Aq2p8ex64kxWjiWPnc+t5EKVphlSDDgKDDbzykHjdJPDIw/s8EGuWFkY jABm7PuYLvbYOgJKSf/s3RpKeC/gw+wjMknFYsApzOlWn29+pusee9Nh4TNmymcMcu8N Qitg== X-Gm-Message-State: AO0yUKXSdgQdezouhG21iE0/moOcDBuE24kmY4ro4fgZ834VXTCbmfMz 0WBCtKx6gS9lostZjhsbgA== X-Google-Smtp-Source: AK7set+44jDdZQnQ5gK5eSj07BZtp0lA+8sBDtriRGbUAZiENzi39wMOmMGgf61Ip66/ii32uJBABg== X-Received: by 2002:a92:cc08:0:b0:317:99b9:3d1c with SMTP id s8-20020a92cc08000000b0031799b93d1cmr12777ilp.26.1679087785257; Fri, 17 Mar 2023 14:16:25 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id c7-20020a929407000000b003232362a4c2sm879970ili.8.2023.03.17.14.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 14:16:23 -0700 (PDT) Received: (nullmailer pid 2819364 invoked by uid 1000); Fri, 17 Mar 2023 21:16:21 -0000 Date: Fri, 17 Mar 2023 16:16:21 -0500 From: Rob Herring To: Arnd Bergmann Cc: Christian Lamparter , Kalle Valo , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Tony Lindgren , Aaro Koskinen , Felipe Balbi , Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , =?iso-8859-1?Q?Beno=EEt?= Cousson , Russell King , Dmitry Torokhov , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] p54spi: convert to devicetree Message-ID: <20230317211621.GA2814846-robh@kernel.org> References: <20230314163201.955689-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230314163201.955689-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_141628_842965_8014602C X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 05:30:56PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The Prism54 SPI driver hardcodes GPIO numbers and expects users to > pass them as module parameters, apparently a relic from its life as a > staging driver. This works because there is only one user, the Nokia > N8x0 tablet. > > Convert this to the gpio descriptor interface and move the gpio > line information into devicetree to improve this and simplify the > code at the same time. > > Signed-off-by: Arnd Bergmann > --- > As I don't have an N8x0, this is completely untested. > > I listed the driver authors (Johannes and Christian) as the maintainers > of the binding document, but I don't know if they actually have this > hardware. It might be better to list someone who is actually using it. > > Among the various chip identifications, I wasn't sure which one to > use for the compatible string and the name of the binding document. > I picked st,stlc4560 as that was cited as the version in the N800 > on multiple websites. > --- > .../bindings/net/wireless/st,stlc45xx.yaml | 64 +++++++++++++++++ > MAINTAINERS | 1 + > arch/arm/boot/dts/omap2.dtsi | 4 ++ > arch/arm/boot/dts/omap2420-n8x0-common.dtsi | 12 ++++ > arch/arm/mach-omap2/board-n8x0.c | 18 ----- > drivers/net/wireless/intersil/p54/p54spi.c | 69 +++++++------------ > drivers/net/wireless/intersil/p54/p54spi.h | 3 + > 7 files changed, 109 insertions(+), 62 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/wireless/st,stlc45xx.yaml Binding looks fine, but I assume you'll split this into at least 3 patches? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel