From: Jonathan Cameron <jic23@kernel.org>
To: Stefan Wahren <stefan.wahren@chargebyte.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Evgeniy Polyakov <zbr@ioremap.net>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-imx@nxp.com, Li Yang <leoyang.li@nxp.com>,
Denis Ciocca <denis.ciocca@st.com>,
soc@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
stefan.wahren@i2se.com
Subject: Re: [PATCH V2 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer
Date: Sat, 18 Mar 2023 15:55:45 +0000 [thread overview]
Message-ID: <20230318155534.16b47583@jic23-huawei> (raw)
In-Reply-To: <20230317103323.7741-5-stefan.wahren@chargebyte.com>
On Fri, 17 Mar 2023 11:33:19 +0100
Stefan Wahren <stefan.wahren@chargebyte.com> wrote:
> The ST IIS328DQ is an accelerometer sensor, which is compatible with
> the already supported ST H3LIS331DL. So add the new compatible
> with a fallback to the ST sensor binding.
>
> Link: https://lore.kernel.org/linux-iio/2bac9ecf-9d2e-967e-9020-1c950487d781@i2se.com/
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> ---
> Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> index c6201976378f..5eb71b24a7cb 100644
> --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> @@ -48,6 +48,9 @@ properties:
> - st,lsm330d-accel
> - st,lsm330dl-accel
> - st,lsm330dlc-accel
> + - items:
> + - const: st,iis328dq
> + - const: st,h3lis331dl-accel
Hmm. So this separates the particular 'oneOf' group from the description
associated with the ST accelerometers.
DT experts, is there a better way to do this? Ideally we'd also associate
other similar groups going forwards so it might become less and less obvious
how the groupings work. (bit late for the many groups that exist
already in that list above this point).
If not I'm fine with it being fairly obvious what is going on in the binding file
current and we can rethink it later.
> - description: Silan Accelerometers
> enum:
> - silan,sc7a20
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-18 15:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 10:33 [PATCH V2 0/8] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-17 10:33 ` [PATCH V2 1/8] dt-bindings: vendor-prefixes: add chargebyte Stefan Wahren
2023-03-17 10:33 ` [PATCH V2 2/8] dt-bindings: Add DS2482/DS2484 as trivial device Stefan Wahren
2023-03-17 10:33 ` [PATCH V2 3/8] w1: ds2482: add i2c id for DS2484 Stefan Wahren
2023-03-17 10:33 ` [PATCH V2 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer Stefan Wahren
2023-03-18 15:55 ` Jonathan Cameron [this message]
2023-03-19 12:40 ` Krzysztof Kozlowski
2023-03-19 15:42 ` Jonathan Cameron
2023-03-27 10:57 ` Stefan Wahren
2023-04-01 15:38 ` Jonathan Cameron
2023-03-17 10:33 ` [PATCH V2 5/8] iio: accel: add support for IIS328DQ variant Stefan Wahren
2023-03-18 15:58 ` Jonathan Cameron
2023-03-18 17:35 ` Stefan Wahren
2023-03-19 15:42 ` Jonathan Cameron
2023-03-17 10:33 ` [PATCH V2 6/8] dt-bindings: ARM: fsl: Add chargebyte Tarragon Stefan Wahren
2023-03-19 12:41 ` Krzysztof Kozlowski
2023-03-17 10:33 ` [PATCH V2 7/8] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-27 5:02 ` Shawn Guo
2023-03-17 10:33 ` [PATCH V2 8/8] ARM: imx_v6_v7_defconfig: Enable Tarragon peripheral drivers Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318155534.16b47583@jic23-huawei \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=stefan.wahren@chargebyte.com \
--cc=stefan.wahren@i2se.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).