From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CE7DC61DA4 for ; Sat, 18 Mar 2023 15:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2rj89fGKDSYRWProfSprX06HgO1enuJRzWhBJmsr0hg=; b=iMxqQTkH+Cl6lD S7XgdvwFf+gipUzlg+9pEaMW/LPJ2WjWsS/uoVWtVYUFJHS8QPEtYNrq7kbSmxzxeveCxXydn3JpU n2n3LbEzsV/XCzyDrxvBfvGFs9y0wC/Jf2+K79kyT8xXAKxM2PzuKthhv33pHZGTzWLi1QiroVX1t kfXaA4VqG2HqDvZSJQyiDM/pBKM7gV6EX1CUXZMzuTfEd11bgNiXldp362YsdL2FPdBfFltsrO1ym JmLcGZ3CLMCoiGLV1uwvzYw550L7qXRLNAMxrSIa8a6XpACaDmmd7V2Br7dRTaBZsyo3Z69bhG/OB bgLnDlWPZDvvpFk6NWUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdYiL-004xgp-1E; Sat, 18 Mar 2023 15:43:25 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdYiI-004xfF-1U for linux-arm-kernel@lists.infradead.org; Sat, 18 Mar 2023 15:43:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 097D9B8015A; Sat, 18 Mar 2023 15:43:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB612C433EF; Sat, 18 Mar 2023 15:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679154199; bh=zaXZb/0+GrPKZGUgY6W8pIhqtj61Krtk5SiZ6NML8ac=; h=Date:From:To:List-Id:Cc:Subject:In-Reply-To:References:From; b=bcwE0qRxHBmZ5qdaimVBn4abPVl3pV94dMyeckbXnKW5luBsOQS6gRc/DxjCm5Mcc 8FKtDV//AAxAkzylLqRMt8GHI0+aVNDZp7YMuYOsi9t+7dvN0YBADM9ZjdtJB/HfRk Mt4MoxBx3ekdJ0Er0aL7NvjyyceEE6e+EPUAM5wb1h1PCmVQTGDnfU2lSYb4ZPLjvN sQkVwREa4nNOmO2Cf839HbnLTAZy4MQdbwH9nFdohN5UDHjcaFw5IWdpM05OOykzNa JL73JUu+uXq4zr+KQOGodn/cVXWzcMuanAT6jWHTMNTFBHleTR0m29B8FitLg34xxT oc1PXGVwiU83w== Date: Sat, 18 Mar 2023 15:58:11 +0000 From: Jonathan Cameron To: Stefan Wahren Cc: Rob Herring , Krzysztof Kozlowski , Lars-Peter Clausen , Arnd Bergmann , Olof Johansson , Evgeniy Polyakov , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-imx@nxp.com, Li Yang , Denis Ciocca , soc@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stefan.wahren@i2se.com Subject: Re: [PATCH V2 5/8] iio: accel: add support for IIS328DQ variant Message-ID: <20230318155811.0bcf85e1@jic23-huawei> In-Reply-To: <20230317103323.7741-6-stefan.wahren@chargebyte.com> References: <20230317103323.7741-1-stefan.wahren@chargebyte.com> <20230317103323.7741-6-stefan.wahren@chargebyte.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_084322_798453_16CB770D X-CRM114-Status: GOOD ( 21.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Mar 2023 11:33:20 +0100 Stefan Wahren wrote: > Since the ST IIS328DQ accelerometer is compatible to the ST LIS331DL, > just add the new compatible to the st_accel framework. > > Link: https://www.st.com/resource/en/datasheet/iis328dq.pdf > Signed-off-by: Stefan Wahren Hi Stefan, Assuming the DT binding is fine with the DT maintainers, I plan to pick the pair of IIO fixes up through my tree. Is there any strong reason they should go via another route? It's common for the dts files to go via ARM soc in cases like this and we tend not to worry that they are 'broken' until the binding docs are visible via other trees. Other than that I can't see an obvious reason not to split these up. Thanks, Jonathan > --- > drivers/iio/accel/st_accel.h | 1 + > drivers/iio/accel/st_accel_core.c | 1 + > drivers/iio/accel/st_accel_i2c.c | 5 +++++ > drivers/iio/accel/st_accel_spi.c | 5 +++++ > 4 files changed, 12 insertions(+) > > diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h > index 56ed0c776d4a..e7525615712b 100644 > --- a/drivers/iio/accel/st_accel.h > +++ b/drivers/iio/accel/st_accel.h > @@ -39,6 +39,7 @@ > #define LIS302DL_ACCEL_DEV_NAME "lis302dl" > #define LSM303C_ACCEL_DEV_NAME "lsm303c_accel" > #define SC7A20_ACCEL_DEV_NAME "sc7a20" > +#define IIS328DQ_ACCEL_DEV_NAME "iis328dq" > > > #ifdef CONFIG_IIO_BUFFER > diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c > index 6b8562f684d5..5f7d81b44b1d 100644 > --- a/drivers/iio/accel/st_accel_core.c > +++ b/drivers/iio/accel/st_accel_core.c > @@ -517,6 +517,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = { > .wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS, > .sensors_supported = { > [0] = H3LIS331DL_ACCEL_DEV_NAME, > + [1] = IIS328DQ_ACCEL_DEV_NAME, > }, > .ch = (struct iio_chan_spec *)st_accel_12bit_channels, > .odr = { > diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c > index 3f02fd5d5946..fb9e2d6f4210 100644 > --- a/drivers/iio/accel/st_accel_i2c.c > +++ b/drivers/iio/accel/st_accel_i2c.c > @@ -119,6 +119,10 @@ static const struct of_device_id st_accel_of_match[] = { > .compatible = "silan,sc7a20", > .data = SC7A20_ACCEL_DEV_NAME, > }, > + { > + .compatible = "st,iis328dq", > + .data = IIS328DQ_ACCEL_DEV_NAME, > + }, > {}, > }; > MODULE_DEVICE_TABLE(of, st_accel_of_match); > @@ -157,6 +161,7 @@ static const struct i2c_device_id st_accel_id_table[] = { > { LIS302DL_ACCEL_DEV_NAME }, > { LSM303C_ACCEL_DEV_NAME }, > { SC7A20_ACCEL_DEV_NAME }, > + { IIS328DQ_ACCEL_DEV_NAME }, > {}, > }; > MODULE_DEVICE_TABLE(i2c, st_accel_id_table); > diff --git a/drivers/iio/accel/st_accel_spi.c b/drivers/iio/accel/st_accel_spi.c > index 5740dc1820bd..f72a24f45322 100644 > --- a/drivers/iio/accel/st_accel_spi.c > +++ b/drivers/iio/accel/st_accel_spi.c > @@ -100,6 +100,10 @@ static const struct of_device_id st_accel_of_match[] = { > .compatible = "st,lsm303c-accel", > .data = LSM303C_ACCEL_DEV_NAME, > }, > + { > + .compatible = "st,iis328dq", > + .data = IIS328DQ_ACCEL_DEV_NAME, > + }, > {} > }; > MODULE_DEVICE_TABLE(of, st_accel_of_match); > @@ -157,6 +161,7 @@ static const struct spi_device_id st_accel_id_table[] = { > { LIS3DE_ACCEL_DEV_NAME }, > { LIS302DL_ACCEL_DEV_NAME }, > { LSM303C_ACCEL_DEV_NAME }, > + { IIS328DQ_ACCEL_DEV_NAME }, > {}, > }; > MODULE_DEVICE_TABLE(spi, st_accel_id_table); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel