From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5AF8C61DA4 for ; Sat, 18 Mar 2023 15:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+YnrIjQezYFV34kwD/FRvZ6Z5Fh0ZRDzPnFmysG+8v8=; b=j24k6nrJmJOedV h3yef7VD2wTQYTkE/2COCOUIgNJ+08/vWpI3bu32avADSvPiGW3gb3QOf7KTpNsoWY0Uuw+JyZpv/ qARs7mbrBUlTcwSXkSFTmQz8H3g37/3JtVm8uKIlMqeGK3TjqkKiWhEsFrryAv5P7Av7Zm35l4s+o Jq/r2CNES7hS+zxEd4OqYOAaHqwXADccxtDu6vNLRa7O9rR6sNEgjaEcd1qhIoTfgTzW+ulpHC9kE qzLVCNCQUE1U25Dnv8wZMpsvBUpJGSwy4yBZwJ0U6sRsc2WNctyy7qfw9zEdLvPe12D6yNqSFxaL+ 7ceGJYBmQrXfs75O4NFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdYrt-004yDL-1O; Sat, 18 Mar 2023 15:53:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdYrq-004yCY-2a for linux-arm-kernel@lists.infradead.org; Sat, 18 Mar 2023 15:53:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0ED1260EB3; Sat, 18 Mar 2023 15:53:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F873C433EF; Sat, 18 Mar 2023 15:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679154793; bh=VIC8yNIF5gb8H4Ss/veeFWQBDBzRAUYMI7xaHoyLXNI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g1/XvBucTyM/JnLrfOELRPJPtmSKDTeJRTmatUDoM8fO5ATOgavaQY5wFYWEQvfIA y3u/5DCZkGN5iwFbY0zdAdIpTfKsnrIOH1pyg37/TjWwZDWHKaFj9in0Wtkrgt7ZUB 99oHWm5JpQdMJEDxltGQAhcec+9YW/9CgKfZE9oMMPY0ZD1uXVTeQP/MHBQY2Zxru4 xQXfUhh0HJmv81l4sk1Z3ke6MbFrfmV8T6bjH/p6ZA+uPJtVwx1QmqL84btdWaFf+G WfrHYefnyf5jQsf8ak0j3jsUlJUIGYh9E9nw2aMvytKDgvhLd2rw8l7+iemGfhdgeP YqlHISFdlZTCQ== Date: Sat, 18 Mar 2023 16:08:06 +0000 From: Jonathan Cameron To: Subject: Re: [PATCH v3] iio: adc: at91-sama5d2_adc: remove dead code in `at91_adc_probe` Message-ID: <20230318160806.7943aba4@jic23-huawei> In-Reply-To: References: <20230314070130.60581-1-chengziqiu@hust.edu.cn> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_085314_882591_EF68B28A X-CRM114-Status: GOOD ( 21.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, lars@metafoo.de, linux-iio@vger.kernel.org, eugen.hristev@collabora.com, linux-kernel@vger.kernel.org, chengziqiu@hust.edu.cn, dzm91@hust.edu.cn, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 14 Mar 2023 10:12:23 +0000 wrote: > On 14.03.2023 09:01, Cheng Ziqiu wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > >>From the comment of platform_get_irq, it only returns non-zero IRQ > > number and negative error number, other than zero. > > > > Fix this by removing the if condition. > > > > Signed-off-by: Cheng Ziqiu > > Reviewed-by: Dongliang Mu > > Reviewed-by: Claudiu Beznea Applied to the togreg branch of iio.git - initially pushed out as testing for 0-day to take a look at it. Thanks, Jonathan > > > > --- > > v2->v3: Change subject to make it regular. > > v1->v2: Change commit message from SoB to Reviewed-by. > > drivers/iio/adc/at91-sama5d2_adc.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > > index 50d02e5fc6fc..168399092590 100644 > > --- a/drivers/iio/adc/at91-sama5d2_adc.c > > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > > @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev) > > st->dma_st.phys_addr = res->start; > > > > st->irq = platform_get_irq(pdev, 0); > > - if (st->irq <= 0) { > > - if (!st->irq) > > - st->irq = -ENXIO; > > - > > + if (st->irq < 0) > > return st->irq; > > - } > > > > st->per_clk = devm_clk_get(&pdev->dev, "adc_clk"); > > if (IS_ERR(st->per_clk)) > > -- > > 2.34.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel