linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bryan Brattlof <bb@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Tero Kristo <kristo@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Julien Panis <jpanis@baylibre.com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am62: Add watchdog nodes
Date: Mon, 20 Mar 2023 10:36:49 -0500	[thread overview]
Message-ID: <20230320153649.zfmyhk65ngh4u35d@bryanbrattlof.com> (raw)
In-Reply-To: <20230311105850.21811-3-nm@ti.com>

On March 11, 2023 thus sayeth Nishanth Menon:
> From: Julien Panis <jpanis@baylibre.com>
> 
> Add nodes for watchdogs :
> - 5 in main domain
> - 1 in MCU domain
> - 1 in wakeup domain
> 
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V3:
> - Dropped the board level wdt reservation, do that with overlays based on
>   modifiable firmware dependencies.
> 
> V3: https://lore.kernel.org/all/20221109093026.103790-2-jpanis@baylibre.com/
> 
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi   | 45 ++++++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi    |  9 +++++
>  arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 11 ++++++
>  3 files changed, 65 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index ea683fd77d6a..90d5f145de4f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -758,6 +758,51 @@ main_mcan0: can@20701000 {
>  		status = "disabled";
>  	};
>  
> +	main_rti0: watchdog@e000000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x0e000000 0x00 0x100>;
> +		clocks = <&k3_clks 125 0>;
> +		power-domains = <&k3_pds 125 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 125 0>;
> +		assigned-clock-parents = <&k3_clks 125 2>;
> +	};
> +
> +	main_rti1: watchdog@e010000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x0e010000 0x00 0x100>;
> +		clocks = <&k3_clks 126 0>;
> +		power-domains = <&k3_pds 126 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 126 0>;
> +		assigned-clock-parents = <&k3_clks 126 2>;
> +	};
> +
> +	main_rti2: watchdog@e020000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x0e020000 0x00 0x100>;
> +		clocks = <&k3_clks 127 0>;
> +		power-domains = <&k3_pds 127 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 127 0>;
> +		assigned-clock-parents = <&k3_clks 127 2>;
> +	};
> +
> +	main_rti3: watchdog@e030000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x0e030000 0x00 0x100>;
> +		clocks = <&k3_clks 128 0>;
> +		power-domains = <&k3_pds 128 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 128 0>;
> +		assigned-clock-parents = <&k3_clks 128 2>;
> +	};
> +
> +	main_rti4: watchdog@e0f0000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x0e0f0000 0x00 0x100>;
> +		clocks = <&k3_clks 130 0>;
> +		power-domains = <&k3_pds 130 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 130 0>;
> +		assigned-clock-parents = <&k3_clks 130 2>;
> +	};
> +

This may be a dumb question, though the ti-sci and TRM documentation is 
labeling this as rti15? idk if we should label this the same? it might 
make grepping a little easier :)

~Bryan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-20 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 10:58 [PATCH 0/2] arm64: dts: ti: k3-am62: Add watchdog and rtc nodes Nishanth Menon
2023-03-11 10:58 ` [PATCH 1/2] arm64: dts: ti: k3-am62-wakeup: Introduce RTC node Nishanth Menon
2023-03-11 10:58 ` [PATCH 2/2] arm64: dts: ti: k3-am62: Add watchdog nodes Nishanth Menon
2023-03-20 15:36   ` Bryan Brattlof [this message]
2023-03-20 15:44     ` Nishanth Menon
2023-03-20 15:37 ` [PATCH 0/2] arm64: dts: ti: k3-am62: Add watchdog and rtc nodes Bryan Brattlof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230320153649.zfmyhk65ngh4u35d@bryanbrattlof.com \
    --to=bb@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jpanis@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).