From: Rob Herring <robh@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Daniel Drake <drake@endlessm.com>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint
Date: Mon, 20 Mar 2023 10:58:12 -0500 [thread overview]
Message-ID: <20230320155812.GA1755078-robh@kernel.org> (raw)
In-Reply-To: <167904851367.26.16449705310108549543@mailman-core.alsa-project.org>
On Fri, Mar 17, 2023 at 12:21:41PM +0200, Cristian Ciocaltea via Alsa-devel wrote:
> Date: Fri, 17 Mar 2023 12:21:41 +0200
> From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sudeep Holla
> <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>, Rob
> Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark
> Brown <broonie@kernel.org>, Nicolas Frattaroli
> <frattaroli.nicolas@gmail.com>, Heiko Stuebner <heiko@sntech.de>, Jaroslav
> Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Paul Walmsley
> <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou
> <aou@eecs.berkeley.edu>, Daniel Drake <drake@endlessm.com>, Katsuhiro
> Suzuki <katsuhiro@katsuster.net>
> CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
> linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
> alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org,
> linux-riscv@lists.infradead.org, kernel@collabora.com
> Subject: Re: [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax
> dma-names order constraint
> Message-ID: <8ae57fe3-56aa-7e50-3eaa-a12a40657baf@collabora.com>
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
> Thunderbird/102.7.2
There is something strange going on with your mails as there are 2
copies in the archives with the 2nd one getting the header twice. It's
coming from the alsa-devel list.
>
> On 3/17/23 10:31, Krzysztof Kozlowski wrote:
> > On 15/03/2023 12:47, Cristian Ciocaltea wrote:
> > > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma &
> > > dma-names properties") documented dma-names property to handle Allwiner
> > > D1 dtbs_check warnings, but relies on a strict rx->tx ordering, which is
> > > the reverse of what a different board expects:
> > >
> > > rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected
> > >
> > > A quick and incomplete check shows the inconsistency is present in many
> > > other DT files:
> >
> > Why not fixing the DTS? The properties should have fixed order.
>
> I was initially concerned about the risk of a potential ABI breakage, but I
> think that's not really a problem since dma-names is not directly accessed
> in the driver and DT Kernel API doesn't rely on a particular order.
>
> If there are no objections, I would switch the order in the binding to
> tx->rx, since that's what most of the DTS use, and fix the remaining ones.
>
> > Best regards,
> > Krzysztof
>
> Thanks,
> Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-20 15:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 11:47 [PATCH 00/11] Enable I2S support for RK3588/RK3588S SoCs Cristian Ciocaltea
2023-03-15 11:47 ` [PATCH 01/11] dt-bindings: firmware: arm,scmi: Document assigned-clocks and assigned-clock-rates Cristian Ciocaltea
2023-03-16 20:34 ` Rob Herring
2023-03-16 22:26 ` Sudeep Holla
2023-03-17 9:59 ` Cristian Ciocaltea
2023-03-17 14:27 ` Rob Herring
2023-03-17 17:21 ` Cristian Ciocaltea
2023-03-15 11:47 ` [PATCH 02/11] dt-bindings: serial: snps-dw-apb-uart: Relax dma-names order constraint Cristian Ciocaltea
2023-03-17 8:31 ` Krzysztof Kozlowski
2023-03-17 10:21 ` Cristian Ciocaltea
2023-03-17 15:54 ` Krzysztof Kozlowski
2023-03-17 16:26 ` Conor Dooley
2023-03-17 17:43 ` Cristian Ciocaltea
2023-03-20 16:01 ` Rob Herring
2023-03-20 19:23 ` Cristian Ciocaltea
[not found] ` <167904851367.26.16449705310108549543@mailman-core.alsa-project.org>
2023-03-20 15:58 ` Rob Herring [this message]
2023-03-20 16:28 ` Mark Brown
2023-03-15 11:47 ` [PATCH 03/11] ASoC: dt-bindings: everest,es8316: Document audio graph port Cristian Ciocaltea
2023-03-20 16:02 ` Rob Herring
2023-03-15 11:47 ` [PATCH 04/11] ASoC: dt-bindings: rockchip: " Cristian Ciocaltea
2023-03-20 16:02 ` Rob Herring
2023-03-15 11:48 ` [PATCH 05/11] ASoC: dt-bindings: rockchip: i2s-tdm: " Cristian Ciocaltea
2023-03-20 16:02 ` Rob Herring
2023-03-15 11:48 ` [PATCH 06/11] ASoC: dt-bindings: rockchip: i2s-tdm: Document power-domains Cristian Ciocaltea
2023-03-20 16:03 ` Rob Herring
2023-03-15 11:48 ` [PATCH 07/11] ASoC: dt-bindings: rockchip: Add compatible for RK3588 Cristian Ciocaltea
2023-03-20 16:03 ` Rob Herring
2023-03-15 11:48 ` [PATCH 08/11] ASoC: rockchip: i2s: " Cristian Ciocaltea
2023-03-15 11:48 ` [PATCH 09/11] arm64: dts: rockchip: rk3588s: Add I2S nodes Cristian Ciocaltea
2023-03-15 11:48 ` [PATCH 10/11] arm64: dts: rockchip: rk3588: " Cristian Ciocaltea
2023-03-15 11:48 ` [PATCH 11/11] arm64: dts: rockchip: rk3588-rock-5b: Add analog audio Cristian Ciocaltea
2023-03-20 18:31 ` (subset) [PATCH 00/11] Enable I2S support for RK3588/RK3588S SoCs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320155812.GA1755078-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=drake@endlessm.com \
--cc=frattaroli.nicolas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=katsuhiro@katsuster.net \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=perex@perex.cz \
--cc=sudeep.holla@arm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).