From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79BE9C6FD1C for ; Tue, 21 Mar 2023 03:30:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MoVKNCkRhFo5kqc+rEEr0yIG8+trjL2IPo0gHRjwBOA=; b=lU2TR0AbKlbVhL VPcCCGqsl4tdZFuK4PRYAzielxMs6cbUJIGupQkyjSdZPXo2JANklMZhwTGwHCJLS98sZQ8V7Idau SFmygpp9l18ZurkCn1ryB4TmCIzqvnLUY2SU4xb2NRVcGvp2cloTyPyYcE8LCS5y7mMwXiVTfL/hf iQgwD9AZOrUggfM5qZzY5YotuuWXZPJrYN2Vrxz8Lp7nBrFpTgCRuyHfsqlqXlL/+DESaUAoaOaYk oMF3jZRbf8/t4V45LpoEypI7oep3EVDI8Pm32qWzaFn3kdinfmGWXHqyxLyqPEeVZCjNrD0ANAQQ/ 0AhBiH2ZyXngvqvSIZEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peSh8-00B6Dm-2L; Tue, 21 Mar 2023 03:29:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peSh6-00B6D9-06 for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 03:29:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6275661943; Tue, 21 Mar 2023 03:29:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 160ACC433D2; Tue, 21 Mar 2023 03:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679369390; bh=GZWXqBx1VZ5HLFmDQaUsHeHsXagTJgeevyhmDS9nBQI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fgt8ewdhEaKB7HcggS2oUKQwMcNjAqV2eGMyVXGnJauZ79cLN0Uq1f/sdAzSEe1L+ DAusnUTbcsPD7vBET9ovu5kWDQsz4LsyQ4CacIDa31R7ZZGY9SGtZUWJxHJ1jOjBOf BI6cR447fnFLxdGR2kMzAfcl56Oo339nQmQ7gua4g/t4rvuu4OcwbO3KwSPoFpypE/ R/TQBEEnnYE4Y2SPTUUR7kj1ajpDIz0ivcl568Qs80uG7BEZQGzaCqdqDfDIUxp33y P9ko7lq6mwUiJLD/E1Vbdgw8RHqnmP+RpYbcmiGVKQWaz048cEXLJtEk8JSWNXrZ8G GjGG53hhlKLCA== Date: Mon, 20 Mar 2023 20:29:48 -0700 From: Jakub Kicinski To: Andrew Halaney Cc: linux-kernel@vger.kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, bhupesh.sharma@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, linux@armlinux.org.uk, veekhee@apple.com, tee.min.tan@linux.intel.com, mohammad.athari.ismail@intel.com, jonathanh@nvidia.com, ruppala@nvidia.com, bmasney@redhat.com, andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ncai@quicinc.com, jsuraj@qti.qualcomm.com, hisunil@quicinc.com, echanude@redhat.com Subject: Re: [PATCH net-next v2 10/12] net: stmmac: dwmac-qcom-ethqos: Respect phy-mode and TX delay Message-ID: <20230320202948.7ba109a4@kernel.org> In-Reply-To: <20230320221617.236323-11-ahalaney@redhat.com> References: <20230320221617.236323-1-ahalaney@redhat.com> <20230320221617.236323-11-ahalaney@redhat.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_202952_108524_93C827A6 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 20 Mar 2023 17:16:15 -0500 Andrew Halaney wrote: > static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos) > { > + int phy_mode; > + int phase_shift; nit: invert the order, we like variable declaration lines longest to shortest > + /* Determine if the PHY adds a 2 ns TX delay or the MAC handles it */ > + phy_mode = device_get_phy_mode(ðqos->pdev->dev); > + if (phy_mode == PHY_INTERFACE_MODE_RGMII_ID || phy_mode == PHY_INTERFACE_MODE_RGMII_TXID) Let's try to stick to 80 chars where reasonable, this would be easier to read as 2 lines. > + phase_shift = 0; > + else > + phase_shift = RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN; > + > /* Disable loopback mode */ > rgmii_updatel(ethqos, RGMII_CONFIG2_TX_TO_RX_LOOPBACK_EN, > 0, RGMII_IO_MACRO_CONFIG2); > @@ -300,9 +310,9 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos) > RGMII_CONFIG_PROG_SWAP, RGMII_IO_MACRO_CONFIG); > rgmii_updatel(ethqos, RGMII_CONFIG2_DATA_DIVIDE_CLK_SEL, > 0, RGMII_IO_MACRO_CONFIG2); > + > rgmii_updatel(ethqos, RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN, > - RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN, > - RGMII_IO_MACRO_CONFIG2); > + phase_shift, RGMII_IO_MACRO_CONFIG2); here and in couple more places looks like indentation got broken? continuation line should start under the opening bracket + 1. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel