From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B027CC74A5B for ; Tue, 21 Mar 2023 04:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P4hBsX0GH9++RdQoSR+wUPNui0BUUqqZhGve7dwDESU=; b=GuLGBuX9oloyYe JlhvyoWg7jLycV7IVbBoHtv2WMh6Op8wuYlCv2EaNHX+8Rq929lmx+vhwMTmV+6mhNcB3KGJxsNhG Ti6USZBhY9cGEJ38VNq2GhomLseXJk6wRi5atwqtFV4ogdgx+0Iay8mkQC3jmfg+WIIyICt/73XjC JW7sr4an5NJoFO29Nk4l03lWBNF52W44YHdvNFykZ8DiuC7Q3v4WG0N3bYpN0v+vim4G78nOg1ZmR UDlpDVvRyiYcLsnMEzYdPdSms8NOnybFywoIojdLDQcpfBzKzwHf7zG48EXWjKhF2uzCbUiKBx5tJ 1HOeYUDQhQSbAJOmdZCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peTG0-00B9Rp-0Z; Tue, 21 Mar 2023 04:05:56 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peTFx-00B9Qw-09 for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 04:05:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 87CEA61956; Tue, 21 Mar 2023 04:05:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6966CC433EF; Tue, 21 Mar 2023 04:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679371550; bh=dkNXtuPKzvH8px3D6BZTKCZ/f6/0QU05iqQDcuooA8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pzADmA5bysShRhtC8zU+1CY1moObQ/KOtgBsTkrjYieCcDGfLyEgUG/1v2S9ntb3a zgqgQzl5SDJS0Z/JBGwt+WHwnnj8Sa71i3YON3MD6IMcpd4T8CZeSM5NY3xLfS4HTX Ahq9CvkwOW19c7h+0DlTiM5XxR2NqauCICZs1aa6nJRqgwnsVKT5vCTP94xpwqqNJP gHk7vARzojEZN4ItrwppFssYWCkdCcpWRblOGtvvB3Bn9Os1B9zZqcfM7uvC69daRs sXqnnY2hwRgfvGuW22kY/U6I8+K6MdAh/Gm/pe7ZbC6e5+3OOtiqRMaQmGUE1geXMF in6r6hTOXHKZA== Date: Mon, 20 Mar 2023 21:05:49 -0700 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: Jiri Pirko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros , mschmidt , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "Michalik, Michal" Subject: Re: [PATCH RFC v6 1/6] dpll: spec: Add Netlink spec in YAML Message-ID: <20230320210549.081da89b@kernel.org> In-Reply-To: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-2-vadfed@meta.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_210553_139039_3C352769 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Mar 2023 13:15:59 +0000 Kubalewski, Arkadiusz wrote: > >Value 23? What's this? > >You have it specified for some attrs all over the place. > >What is the reason for it? > > > > Actually this particular one is not needed (also value: 12 on pin above), > I will remove those. > But the others you are refering to (the ones in nested attribute list), > are required because of cli.py parser issue, maybe Kuba knows a better way to > prevent the issue? > Basically, without those values, cli.py brakes on parsing responses, after > every "jump" to nested attribute list it is assigning first attribute there > with value=0, thus there is a need to assign a proper value, same as it is on > 'main' attribute list. Are you saying the parser gets confused after returning from nested parsing? Can you still repro this problem? I don't see any global state in _decode().. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel