From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84818C6FD1D for ; Tue, 21 Mar 2023 09:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S4L0nfjw92j9Vh+Z1m3vXaIAacpdujtPBVz7YjIdKzA=; b=GBetEISEXNsEnc jorSRbYf2TOp87T5ofKOxRr9RHM/8wp5YjkayPWQcD6vs690cZtsCdROm3lss96FT8wGvuIkiaizG JkGQFQfkdXC/wsH1NdfodNU24zlDS+N5PQnrwPNf2rcws5290e/RFfXuBV+CjP+WHZx28Ym6VHKfn Hxk57I0/jD2unVL/armIIsxfvOOiNaG+y75O7DckX8L8yKdsm4RSg9KySRxtTvBjH2Sa7RyF2Nc3N pLl1Yx8kUWvJXr0F65FaaCh3vY/5+3r1T9QJz9zIk6KGQqu6QuF0M1l6Hdlaadf8FxB8yDbJsysH0 vfJ1UrCRzNzsh/JOiHaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peYRL-00Bu4k-03; Tue, 21 Mar 2023 09:37:59 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peYRI-00Bu2b-0C for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 09:37:57 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2719A496; Tue, 21 Mar 2023 10:37:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679391471; bh=cCHwQxhNTRriBl3uBijGqtpqmS6HWZUMxP7sK9K/wL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SeUT0JzburiGqjVFS8NysbHRabRcLCOzqPL8bukrGvpeahY7CViHgcpTbfDiOasd0 pjea+qhXd0h+Z8l65bFuiMRrdTFV/PKuwaoeR7ShBqb0TTyQq1sKUITzf2ywEPfnq0 KQ/vOfC9sKCktK/ASyUV26xb4x01sCPEl2iynDhc= Date: Tue, 21 Mar 2023 11:37:57 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Rui Miguel Silva , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] media: imx: imx7-media-csi: Fix mbus framefmt field init Message-ID: <20230321093757.GZ20234@pendragon.ideasonboard.com> References: <20230321072707.678039-1-alexander.stein@ew.tq-group.com> <20230321072707.678039-2-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230321072707.678039-2-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_023756_247366_37772113 X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thank you for the patch. On Tue, Mar 21, 2023 at 08:27:06AM +0100, Alexander Stein wrote: > 'field' is zero-initialized to V4L2_FIELD_ANY, which is an invalid value > to return to userspace. Instead fefault to non-interleaving. I prefer defaulting to non-interleaving instead of fefaulting :-) I'll fix the typo in my tree. > Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx7-media-csi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c > index c22bf5c827e7..3e97b9f2ff69 100644 > --- a/drivers/media/platform/nxp/imx7-media-csi.c > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct imx7_csi *csi) > format.code = IMX7_CSI_DEF_MBUS_CODE; > format.width = IMX7_CSI_DEF_PIX_WIDTH; > format.height = IMX7_CSI_DEF_PIX_HEIGHT; > + format.field = V4L2_FIELD_NONE; > > imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL); > csi->vdev_compose.width = format.width; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel