From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B7B9C6FD1D for ; Tue, 21 Mar 2023 15:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bxvTMyfj8IEH54yR7fgh5vVvDoqMroFr1khDG8TNsIQ=; b=dT/qWDI6BdjnGnnp741YlNbdEa WJ0gaQqN8hm9Amg1HSu+XJw3pF4RlPMltOhE32NOzY1q5XQGYLyNR8TBnQmx/BvQyD7c05SFfOXO8 6Sp9m1J5+QuyYLm/+dJjnsyv3MDkGhWpvhOgcvX+IbZ/ieC2yvFSVde84HEPBU2CpTGpiWSQXr7vY tbx+CKR77DfDm2Nim/jcP0COATAOL9Fk8/EDxM+kf4sB1P1ioObjPg9PV7UYmJAz7WSjQSBzl6sL1 5jYNl/waQMsuF1+TVVJA0bdGWcdsfJY+KPrqLjLjG0TXnnM2Nmu49TTI+6X6Vg6nq976VzJmi3b38 yuM8Dujg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peeBF-00Cyat-14; Tue, 21 Mar 2023 15:45:45 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peeB7-00CyZT-2C for linux-arm-kernel@bombadil.infradead.org; Tue, 21 Mar 2023 15:45:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Krzg0wsgi3e1+bN2uZEn+LdbVtw9+KSDVRGMqDt0WbY=; b=IYpUcsHz/GkLW0d4/iC3F9ez9L RNUwAU2Fsnwd6JSaXHYtBQ/BPWqUr266Xpr6xmKr2Ti6sWhFLsBfEWpm+rLAukMFu7cMw9ckyc5+b AiK1X57mH09UxG4tl6qemdwH9DHsCoAE0ojSMlsUroNOPQP1n2oOWsVa8L6SMlhwdaScASg9dG+zh /YwdP7tlVTt4z+XVsEjrbrsbBOSu5NWWLbZ2Hhx7/+ePL1wkuPzL8lnpWWMPFZ6qitnUZT3gJmpA/ 5LanLESyl8zeofKlwV9+O3i7kW2gxtPjsIrZ7y3P5Ehrp7VXdZ6Gedw1RQOO2Ai57eFNoqeLYOu/K Aq9XK6hQ==; Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pedQ3-004Hmd-1S for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 14:57:02 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6A7185C00FD; Tue, 21 Mar 2023 10:56:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 21 Mar 2023 10:56:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1679410609; x=1679497009; bh=Kr zg0wsgi3e1+bN2uZEn+LdbVtw9+KSDVRGMqDt0WbY=; b=rOFJfN0ZWr4AOuVBov h67qAC7OEWFK6+Lcmoxr4zy9jam8b5UPcV4rttDgUYhblJwTiNkoPAZ8S2f4QXqI khWQvUhOMUEXRA5Tnh3pnwhqy2vYe6cUxkaI8XKypB/U3jv5bWB4Gml3l2M0vqRI 8mJa7sS91lwUUOuEiTaCZduzUxOZFgbgLsj5Q6hKNQV6TS7MUWHp2lqfLTR9w6/n wvZ3/6VplK1vWi4bxTNvF2DJzRBFZuFpLluihrbUXyRbWuZzCLxjldNoxRCDnsIh YDK98MSyNUuENuemqGZkDWxgnuS1pz1N9motRBRTE1SifM2zDEmsDjkPoL7Wh7W3 8gPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679410609; x=1679497009; bh=Krzg0wsgi3e1+ bN2uZEn+LdbVtw9+KSDVRGMqDt0WbY=; b=HyLtwTHXPYjFq/3VilH0N4YsaxI0U CEVCkcQlv5EwGi/cmTpvzouxVUQuETIwpkz+XgS6rlxpVg52+XbaPvXlUdLCoEPu AQvzDhp84NU/D85de731dJQcXhKYsKOgUGNHvoRJntDpBN74Jj4m3vuOGhBOl8By 6fijWW30/KVCyv7WzBJscCRUvjulbNSCpJfZZrudFjKXijsxQPuGAglSLDxEtw4p OPLG56lSNeXsyN7rffp/TVlZADqDIlHO8bVrrpx7C5ghZtlnnt3w3pjQxodFl0cG GeI19nlM6sIQuSxgfTk+N3MeMbugxnLsuiQ5013S/CAV/uVWXsUdr9C3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegtddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeeuvdejfefhueeukeegffekieejtdefkeejuedtueegleeijefgjeeigfej hedtteenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhkvghrnhgvlhdrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhm vgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Mar 2023 10:56:47 -0400 (EDT) Date: Tue, 21 Mar 2023 15:56:46 +0100 From: Maxime Ripard To: Roman Beranek Cc: Chen-Yu Tsai , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG Message-ID: <20230321145646.w6kr7ddurfxpg5rt@houat> References: <20230320161636.24411-1-romanberanek@icloud.com> MIME-Version: 1.0 In-Reply-To: <20230320161636.24411-1-romanberanek@icloud.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_145700_755905_320B92CC X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5684052358370752654==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5684052358370752654== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zucvqkk7astyp3jt" Content-Disposition: inline --zucvqkk7astyp3jt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Mar 20, 2023 at 05:16:36PM +0100, Roman Beranek wrote: > In the case of DSI output, the value of SUN4I_TCON0_DCLK_DIV (4) does > not represent the actual dotclock divider, PLL_MIPI instead runs at > (bpp / lanes )-multiple [1] of the dotclock. [2] Setting 4 as dotclock > divder thus leads to reduced frame rate, specifically by 1/3 on 4-lane > panels, and by 2/3 on 2-lane panels respectively. >=20 > As sun4i_dotclock driver stores its calculated divider directly in > the register, conditional handling of the DSI output scenario is needed. > Instead of reading the divider from SUN4I_TCON0_DCLK_REG, retrieve > the value from tcon->dclk_min_div. >=20 > [1] bits per pixel / number of DSI lanes > [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp-4.4/blob/66bef0f2f30b367e= b93b1cbad21ce85e0361f7ae/linux-sunxi/drivers/video/fbdev/sunxi/disp2/disp/d= e/lowlevel_sun50iw1/disp_al.c#L322 >=20 > Signed-off-by: Roman Beranek This is similar to https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/ What's the story there? Also, how was it tested/confirmed? Maxime --zucvqkk7astyp3jt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZBnFrgAKCRDj7w1vZxhR xW1uAP9976ZsRECK0eQpWRQZgu8XVlengWG8ooPy6U2I7N47ZgEA6brbh4HoKGtV lwnpwiadCnsprq26idTI18GGtM6lrAY= =giCa -----END PGP SIGNATURE----- --zucvqkk7astyp3jt-- --===============5684052358370752654== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5684052358370752654==--