From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DE2EC6FD20 for ; Tue, 21 Mar 2023 21:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I6Qw54N34A/8gimd8bKzIL9Z8gR96YYACFGblKgXMBY=; b=nVL1Zo7xvw4sL8 JzohAwwT8YOHgkVSRTXcImhadBuN5rfJ7gkGtDVRBtJi7myYjlYSDAY2z3AC48NtsqrTL0CGDiMsF MAmp7ZceREU/VFGxhnWJNES0XFkPt2GLQk+F+lC7sD8c6/iv4uP+T4OogR9QDLPyksJMDqxTPhkQ8 Bb2Dv/4QOOGHOHDAGywJe8vvJHECikuf4r2c7fWWsAYPLymejDntuxFlHIXkAj+tOLZzxe4Hey743 44maXmLntrXjJ022MoMEBMUj/A6a5Wnvf8lCQBlTxGDyl3aebCPa1eqKb9o/Tk1H9rnZfLJmLvOMq TMZ4Xh69bQnAnrzvZsGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pejWf-00Dojy-1Y; Tue, 21 Mar 2023 21:28:13 +0000 Received: from mail-oi1-f177.google.com ([209.85.167.177]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pejWc-00DoiE-0j for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 21:28:11 +0000 Received: by mail-oi1-f177.google.com with SMTP id s8so2308344ois.2 for ; Tue, 21 Mar 2023 14:28:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679434080; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xuIPF2p5MBOAhgvZYwGUOCveU0K59ld+o3H/BrUHIXc=; b=5JLG4ajIpjv/1zLKwS/ykn1g5P7XwvqjP794YIqaMaB5yD7BJMEl5xRRQtOx6Dsi2w ba3Pe06efZHIe4ASl9DerRbY7pwlBRCum6CckKRc+CUUPfKMStJ6bazynpYU+hGDmFfQ WpGqN4aOm6avDpJQ5nORdOlv+TQsEjiWnEtoH09MxEM9xlzABbxi4z5rCcM/zjoAlwNz /jmGxfIqywgvIHRhhwoCChcaNmCfnD+DhxwrtHCm1ye27tMAzbbcyssXA7QWzeZBsALi itn11e+rbVfF5NY26vEgSdnyN6Gib74q5jK0EPBlJBrvKNMT8TH8DXitT19Fz++X+aj8 9AQQ== X-Gm-Message-State: AO0yUKXZwL54PCrvTSRv7h74uz/VzMwpAOxnW2camC/moa2t8MVp8MC+ 97EvhdBKDAGIuPPBSkB2HQ== X-Google-Smtp-Source: AK7set/faoMGqVJ+QTJCoH7na00DNWHkcm9XMi+/7B7CQTvY9i7F6tP/AT297tYCXkj3ApwrgJrMzg== X-Received: by 2002:a05:6808:8c6:b0:384:356a:a26f with SMTP id k6-20020a05680808c600b00384356aa26fmr256794oij.51.1679434078727; Tue, 21 Mar 2023 14:27:58 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id v184-20020acadec1000000b003871471f894sm1753856oig.27.2023.03.21.14.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 14:27:57 -0700 (PDT) Received: (nullmailer pid 1643739 invoked by uid 1000); Tue, 21 Mar 2023 21:27:56 -0000 Date: Tue, 21 Mar 2023 16:27:56 -0500 From: Rob Herring To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 11/15] dt-bindings: net: dsa: qca8k: add LEDs definition example Message-ID: <20230321212756.GA1635435-robh@kernel.org> References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-12-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230319191814.22067-12-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_142810_266059_36DB3FE3 X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 19, 2023 at 08:18:10PM +0100, Christian Marangi wrote: > Add LEDs definition example for qca8k Switch Family to describe how they > should be defined for a correct usage. > > Signed-off-by: Christian Marangi > --- > .../devicetree/bindings/net/dsa/qca8k.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > index 389892592aac..2e9c14af0223 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > @@ -18,6 +18,8 @@ description: > PHY it is connected to. In this config, an internal mdio-bus is registered and > the MDIO master is used for communication. Mixed external and internal > mdio-bus configurations are not supported by the hardware. > + Each phy has at least 3 LEDs connected and can be declared > + using the standard LEDs structure. > > properties: > compatible: > @@ -117,6 +119,7 @@ unevaluatedProperties: false > examples: > - | > #include > + #include > > mdio { > #address-cells = <1>; > @@ -226,6 +229,27 @@ examples: > label = "lan1"; > phy-mode = "internal"; > phy-handle = <&internal_phy_port1>; > + > + leds { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; Once 'unevaluatedProperties' is properly implemented in the schema, this will be a warning. You didn't define 'reg' in the schema. > + color = ; > + function = LED_FUNCTION_LAN; > + function-enumerator = <1>; > + default-state = "keep"; > + }; > + > + led@1 { > + reg = <1>; > + color = ; > + function = LED_FUNCTION_LAN; > + function-enumerator = <1>; > + default-state = "keep"; > + }; > + }; > }; > > port@2 { > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel