* [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET
@ 2023-03-17 15:42 cy_huang
2023-03-22 15:28 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: cy_huang @ 2023-03-17 15:42 UTC (permalink / raw)
To: pavel, lee
Cc: matthias.bgg, angelogioacchino.delregno, cy_huang, chiaen_wu,
jacek.anaszewski, linux-leds, linux-kernel, linux-arm-kernel,
linux-mediatek
From: ChiYuan Huang <cy_huang@richtek.com>
0-DAY CI Kernel Test Service reported the implicit declaration error below:
drivers/leds/rgb/leds-mt6370-rgb.c: In function'mt6370_check_vendor_info':
>> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration
of function 'FIELD_GET' [-Werror=implicit-function-declaration]
889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
|
Add the missing header 'bitfield.h' to fix it.
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202303171729.CcgyFx17-lkp@intel.com/
Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
drivers/leds/rgb/leds-mt6370-rgb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
index 9c1e6d5..bb62431 100644
--- a/drivers/leds/rgb/leds-mt6370-rgb.c
+++ b/drivers/leds/rgb/leds-mt6370-rgb.c
@@ -7,6 +7,7 @@
* Alice Chen <alice_chen@richtek.com>
*/
+#include <linux/bitfield.h>
#include <linux/bitops.h>
#include <linux/kernel.h>
#include <linux/leds.h>
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET
2023-03-17 15:42 [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET cy_huang
@ 2023-03-22 15:28 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-03-22 15:28 UTC (permalink / raw)
To: cy_huang
Cc: pavel, matthias.bgg, angelogioacchino.delregno, chiaen_wu,
jacek.anaszewski, linux-leds, linux-kernel, linux-arm-kernel,
linux-mediatek
On Fri, 17 Mar 2023, cy_huang@richtek.com wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> 0-DAY CI Kernel Test Service reported the implicit declaration error below:
>
> drivers/leds/rgb/leds-mt6370-rgb.c: In function'mt6370_check_vendor_info':
> >> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration
> of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> 889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> |
>
> Add the missing header 'bitfield.h' to fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303171729.CcgyFx17-lkp@intel.com/
> Fixes: 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> drivers/leds/rgb/leds-mt6370-rgb.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-22 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-17 15:42 [PATCH] leds: rgb: mt6370: Fix implicit declaration for FIELD_GET cy_huang
2023-03-22 15:28 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).