From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE613C6FD1C for ; Thu, 23 Mar 2023 15:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HYRfvEpkVsgALRLGgCOUce4p0vFDSy0VYF5jiCUd4HU=; b=eKULhzauaEWP7C i8q8Q20lLCZOTmEmPGer2G8IKClzSKyYCe/U3LukCaG9Pw4bvYLX4vSO6Bs53dzgPOR4C0HVwEE9S iCu9VWg5xcysmqrItDMKYSv3JLbncFB1gquC8RzqmGWemAYlHV/HuyWgGkU/c9U+Jrtlq3lesIUMC nc1sw8sp97avrNtXD7fOmMAhuMFmNM9m0uex6yQh1SCKl08OK/2K7cGUlpRQHwicEwIBFaBuC/B6p dHjY2gwSfzO3hOHKcl9rN1+c/NnWUejyUGzoE0SDItGkMDuA5ZZCrSfp9Shd91N00u7bKoiYRmeg+ S+MAn+Z+cXp6FLxGcpog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfMbL-002JTb-2K; Thu, 23 Mar 2023 15:11:39 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfMbG-002JS0-1O for linux-arm-kernel@lists.infradead.org; Thu, 23 Mar 2023 15:11:38 +0000 Received: by mail-lf1-x129.google.com with SMTP id i13so12515957lfe.9 for ; Thu, 23 Mar 2023 08:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679584291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=09gF+ci4EZ7xKNHFBN4nQXrjScsnzrqt/YgXpgBpcd0=; b=Mu76RFZOyAfrq9LEOuqynAliFMXq6UNacOyT2uAPTpnq5G3H+re0Cx4K/gGwiBMVIi c/cB37JF5RoQfM4k+LLFb0flTYpNLJD1E9OqFxtJc9XNGb0f6Chyw3Ax/hYXAsgNQEmM hPkLk/8WJgpOVjkfW2By4WK6f18UAW+IynBO9hIT17PcpBC79JaazKDFsOnZr2I104Mh VSB05qI7RSyU3URsvUBR8qornl8zwj0iyQgPOIpbCqaq0vqoPbaClmMYGGUOgLuevuOT kWOtDMygByiviB7puF3lgqpj2y4ovP3fvmPiV2jzjaRFe43U7jLJwRdZycaz7ztObeHH B6Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679584291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=09gF+ci4EZ7xKNHFBN4nQXrjScsnzrqt/YgXpgBpcd0=; b=I4ii4CQWTrpK653QQgchDL2bRZntZPHvj3/G2AxokD3oTkIn2d94fODc2Gu6BUH2rS W4kboSG/22pNJCufk1y0vdBDC1Og1KD/mlrZyWPSCM2JaVb6MyxHsUK66UBWMqZdMLi+ Qkb+ZPw5J1eqaCcr+OmiS01sJtDPy3rne8uQ2sb/Aty1bGc0ut8PY6lvwrN/jE+5nIS7 a/kuhm8BKrzh2C1xkW53Ls1ZtcUCYEqAr5Ehvp9smO2D3yAIA0RvUQ1uJcuFlcAe+lYc PZZdQAqVieeoKtAMai5vc/GC0Bu1Lvpk7faKgVJMD3E4Wtiu4sULcO3A4pwwyhtTf3H1 qzqw== X-Gm-Message-State: AO0yUKUtwxW1b1E2+qUMmq21gRO1rNPev4hXT5kIJYw/UMeAa60XKv2O rVuKGvkdOG4timIC874xscY= X-Google-Smtp-Source: AK7set8+y6nFsaRhX1UdZartcuOV9lCKqA6Fzy/bfBfHkNjRTDXtDL4DUFOei4x0Jj1AQNWUtFdkzA== X-Received: by 2002:ac2:4c39:0:b0:4ea:e688:a04a with SMTP id u25-20020ac24c39000000b004eae688a04amr2864973lfq.66.1679584291452; Thu, 23 Mar 2023 08:11:31 -0700 (PDT) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id w19-20020ac24433000000b004eb00c0d417sm150066lfl.130.2023.03.23.08.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 08:10:47 -0700 (PDT) Date: Thu, 23 Mar 2023 18:10:22 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Krzysztof Kozlowski , Alexey Malahov , Pavel Parkhomenko , Christian Marangi , Richard Cochran , Biao Huang , Yang Yingliang , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 15/16] dt-bindings: net: dwmac: Simplify MTL queue props dependencies Message-ID: <20230323151022.q5h6rf3azbncfid3@mobilestation> References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-16-Sergey.Semin@baikalelectronics.ru> <20230317205604.GA2723387-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230317205604.GA2723387-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_081134_488417_5029D066 X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 03:56:04PM -0500, Rob Herring wrote: > On Tue, Mar 14, 2023 at 01:51:02AM +0300, Serge Semin wrote: > > Currently the Tx/Rx queues properties interdependencies are described by > > means of the pattern: "if: required: X, then: properties: Y: false, Z: > > false, etc". Due to very unfortunate MTL Tx/Rx queue DT-node design the > > resultant sub-nodes schemas look very bulky and thus hard to read. The > > situation can be improved by using the "allOf:/oneOf: required: X, > > required: Y, etc" pattern instead thus getting shorter and a bit easier to > > comprehend constructions. > > > > Signed-off-by: Serge Semin > > > > --- > > Reviewed-by: Rob Herring > > > > > Note the solution can be shortened out a bit further by replacing the > > single-entry allOf statements with just the "not: required: etc" pattern. > > But in order to do that the DT-schema validation tool must be fixed like > > this: > > > > --- a/meta-schemas/nodes.yaml 2021-02-08 14:20:56.732447780 +0300 > > +++ b/meta-schemas/nodes.yaml 2021-02-08 14:21:00.736492245 +0300 > > @@ -22,6 +22,7 @@ > > - unevaluatedProperties > > - deprecated > > - required > > + - not > > - allOf > > - anyOf > > - oneOf > > This should be added regardless. Can you send a patch to devicetree-spec > or a GH PR. But I'd skip using that here for now because then we require > a new version of dtschema. Ok. I'll send the patch to the devicetree-spec mailing list. * Note meta-schemas/base.yaml will be fixed in the similar way. -Serge(y) > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel