From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
linux-mtd@lists.infradead.org, Julien Su <juliensu@mxic.com.tw>,
Jaime Liao <jaimeliao@mxic.com.tw>,
Jaime Liao <jaimeliao.tw@gmail.com>,
Alvin Zhou <alvinzhou@mxic.com.tw>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Michal Simek <monstr@monstr.eu>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/8] mtd: spi-nor: Reorder the preparation vs locking steps
Date: Fri, 24 Mar 2023 16:28:02 +0100 [thread overview]
Message-ID: <20230324162802.28338739@xps-13> (raw)
In-Reply-To: <57a59ac4-56bf-9aa4-540a-9d72455951d3@linaro.org>
Hi Tudor,
tudor.ambarus@linaro.org wrote on Fri, 17 Mar 2023 03:51:37 +0000:
> On 3/17/23 03:39, Tudor Ambarus wrote:
> >
> >
> > On 2/1/23 11:35, Miquel Raynal wrote:
> >> The ->prepare()/->unprepare() hooks are now legacy, we no longer accept
> >> new drivers supporting them. The only remaining controllers using them
> >> acquires a per-chip mutex, which should not interfere with the rest of
> >> the operation done in the core. As a result, we should be safe to
> >> reorganize these helpers to first perform the preparation, before
> >> acquiring the core locks. This is necessary in order to be able to
> >> improve the locking mechanism in the core (coming next). No side effects
> >> are expected.
> >>
> >> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> >
> > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>
> No, I take back my R-b. The reorder is fine, but you missed to update
> otp.c and swp.c, see below.
/me guilty
Not sure how that slipped in. Anyhow, I'll go through the missing files
ofc.
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-24 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 11:35 [PATCH v4 0/8] mtd: spi-nor: read while write support Miquel Raynal
2023-02-01 11:35 ` [PATCH v4 1/8] mtd: spi-nor: Introduce the concept of bank Miquel Raynal
2023-03-17 3:36 ` Tudor Ambarus
2023-02-01 11:35 ` [PATCH v4 2/8] mtd: spi-nor: Add a macro to define more banks Miquel Raynal
2023-02-01 11:35 ` [PATCH v4 3/8] mtd: spi-nor: Reorder the preparation vs locking steps Miquel Raynal
2023-03-17 3:39 ` Tudor Ambarus
2023-03-17 3:51 ` Tudor Ambarus
2023-03-24 15:28 ` Miquel Raynal [this message]
2023-02-01 11:35 ` [PATCH v4 4/8] mtd: spi-nor: Separate preparation and locking Miquel Raynal
2023-02-01 11:36 ` [PATCH v4 5/8] mtd: spi-nor: Prepare the introduction of a new locking mechanism Miquel Raynal
2023-02-01 11:36 ` [PATCH v4 6/8] mtd: spi-nor: Add a RWW flag Miquel Raynal
2023-03-17 3:20 ` Tudor Ambarus
2023-02-01 11:36 ` [PATCH v4 7/8] mtd: spi-nor: Enhance locking to support reads while writes Miquel Raynal
2023-03-17 5:59 ` Tudor Ambarus
2023-03-24 17:41 ` Miquel Raynal
2023-03-27 9:29 ` Tudor Ambarus
2023-03-28 8:22 ` Miquel Raynal
2023-02-01 11:36 ` [PATCH v4 8/8] mtd: spi-nor: macronix: Add support for mx25uw51245g with RWW Miquel Raynal
2023-03-17 6:09 ` Tudor Ambarus
2023-03-17 7:43 ` liao jaime
2023-03-17 8:22 ` Tudor Ambarus
2023-03-17 4:13 ` [PATCH v4 0/8] mtd: spi-nor: read while write support Tudor Ambarus
2023-03-24 13:51 ` Miquel Raynal
2023-03-27 9:34 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324162802.28338739@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=alvinzhou@mxic.com.tw \
--cc=jaimeliao.tw@gmail.com \
--cc=jaimeliao@mxic.com.tw \
--cc=juliensu@mxic.com.tw \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=monstr@monstr.eu \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).