From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DC1FC6FD20 for ; Fri, 24 Mar 2023 22:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fLiWzzuzM0Jb1kBM4txExk4PmYSjPqibB6qTDfgs7VQ=; b=h4c8v2NT4/43C8 X2DFZBlcBfFFU3DAz7wwg7ABstzV0mkdRPGt7q9UbekEkonMbk2VFTwKo5gxTZY7MB2ijw+bNXQLy XLKx0lWXXyHcSUtDZvn4DAmlaoE1sE2yhItuDv3wqDskeiMoEN4e8xFbHew+KeA5GFdNbav1FmSeE 02RwebKOkSQwSHZJl4PO3ronjwQ/1A/1ok/WHVKSVWSOc4YBX0E0pu3kwNuCXBRM8XusrGbQfhWdJ lvNBiO1obVdPj5CUyzx8SdZUnPbFAaanydSPzE681QeBliZPCPkpGN8tOhKm+kpMuZwQ0M40IZ9zE 7MXsmu2S43UP+6utOlNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfpRq-005hD6-0I; Fri, 24 Mar 2023 21:59:46 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfpRm-005h9w-2o for linux-arm-kernel@lists.infradead.org; Fri, 24 Mar 2023 21:59:44 +0000 Received: by mail-oi1-f174.google.com with SMTP id f17so2291381oiw.10 for ; Fri, 24 Mar 2023 14:59:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679695174; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZNL5w5eYDM55BXRsVUv16I402Vb2xlU+5wdQWl0ZA5o=; b=xPMFiEavE6JdN/0oPRjmLvz5UAoyPBU/9CKGL7Tr/FJSm1JznRv/kmsDksPO7qo879 O1dnUS24ORZPhAvdsTmRCEMNAhdfrhwwSf3GNxr9Kw9QKng7Ji24DHvWZLqTF1OaeBoW nEzCXP1K60pL32p8/q59Qi+gwdGWeqG0m8wij+mg7/TglvwVr4XgBVXcOD4h1M6UEwXb KM3eU11ZotqwrpStxvNpidcSWWM6vNqRUj4MHxDM5+UhbJd9Uef6noNJ+dcXSDBob5I/ yaN1H/TeDyxUz6za+UokKgPLZ6Jj8iV6PMsB80MMdkHHS2VkMmrjwkPQGkJ3vV1/DFsm l03Q== X-Gm-Message-State: AO0yUKWMwJ6oXkja5UXFUC3UTrMOXp7CddXcYCW8LJkVi/7nD4147jsZ NdrKjLcfOFGgmF9yHwjf1g== X-Google-Smtp-Source: AK7set83OMMwHEd/xmeCKjvOBf+FPOq4sNLD29gH0PdiDnCImpMV3fVRF6vT6C/vpyBYUnXPJA7boA== X-Received: by 2002:a54:4805:0:b0:386:ce06:8d87 with SMTP id j5-20020a544805000000b00386ce068d87mr1666502oij.38.1679695174268; Fri, 24 Mar 2023 14:59:34 -0700 (PDT) Received: from robh_at_kernel.org ([2605:ef80:80f9:92f0:b372:78c0:69c1:66d6]) by smtp.gmail.com with ESMTPSA id r2-20020a056808210200b00387160bcd46sm4918565oiw.46.2023.03.24.14.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 14:59:33 -0700 (PDT) Received: (nullmailer pid 54572 invoked by uid 1000); Fri, 24 Mar 2023 21:59:30 -0000 Date: Fri, 24 Mar 2023 16:59:30 -0500 From: Rob Herring To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 10/15] dt-bindings: net: ethernet-controller: Document support for LEDs node Message-ID: <20230324215930.GA49367-robh@kernel.org> References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-11-ansuelsmth@gmail.com> <20230321211953.GA1544549-robh@kernel.org> <641a35b8.1c0a0220.25419.2b4d@mx.google.com> <38534a25-4bb3-4371-b80b-abfc259de781@lunn.ch> <641a4046.7b0a0220.44d4e.95d4@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <641a4046.7b0a0220.44d4e.95d4@mx.google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_145942_913972_948AA620 X-CRM114-Status: GOOD ( 37.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 22, 2023 at 12:39:48AM +0100, Christian Marangi wrote: > On Wed, Mar 22, 2023 at 12:23:59AM +0100, Andrew Lunn wrote: > > > > Are specific ethernet controllers allowed to add their own properties in > > > > led nodes? If so, this doesn't work. As-is, this allows any other > > > > properties. You need 'unevaluatedProperties: false' here to prevent > > > > that. But then no one can add properties. If you want to support that, > > > > then you need this to be a separate schema that devices can optionally > > > > include if they don't extend the properties, and then devices that > > > > extend the binding would essentially have the above with: > > > > > > > > $ref: /schemas/leds/common.yaml# > > > > unevaluatedProperties: false > > > > properties: > > > > a-custom-device-prop: ... > > > > > > > > > > > > If you wanted to define both common ethernet LED properties and > > > > device specific properties, then you'd need to replace leds/common.yaml > > > > above with the ethernet one. > > > > > > > > This is all the same reasons the DSA/switch stuff and graph bindings are > > > > structured the way they are. > > > > > > > > > > Hi Rob, thanks for the review/questions. > > > > > > The idea of all of this is to keep leds node as standard as possible. > > > It was asked to add unevaluatedProperties: False but I didn't understood > > > it was needed also for the led nodes. > > > > > > leds/common.yaml have additionalProperties set to true but I guess that > > > is not OK for the final schema and we need something more specific. > > > > > > Looking at the common.yaml schema reg binding is missing so an > > > additional schema is needed. > > > > > > Reg is needed for ethernet LEDs and PHY but I think we should also permit > > > to skip that if the device actually have just one LED. (if this wouldn't > > > complicate the implementation. Maybe some hints from Andrew about this > > > decision?) > > > > I would make reg mandatory. > > > > Ok will add a new schema and change the regex. > > > We should not encourage additional properties, but i also think we > > cannot block it. > > > > The problem we have is that there is absolutely no standardisation > > here. Vendors are free to do whatever they want, and they do. So i > > would not be too surprised if some vendor properties are needed > > eventually. > > > > Think that will come later with defining a more specific schema. But I > honestly think most of the special implementation will be handled to the > driver internally and not with special binding in DT. Then encourage no additional properties by letting whomever wants to add them to restructure the schema. ;) Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel