From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75F9CC6FD1F for ; Sat, 25 Mar 2023 21:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nHiRkq81a8Mruqd9fEQJWZl/4rq3dVppbw1KcN73eV0=; b=b1/0TVpT1f+clp OjEeQaMydKfouhg3B6nF4En/f7qoMyWsv8WkmZgXYYUFf2CpiRYkygVKDpLeFAbzq1+hc8DJ8Ll4Y Ec3LUjMhum7n6hkqgT9MUAcVGoujrNXzXEUHimfQNZOg1HF3u9JZGQ8s0I82aAYRakzT6fDBx5gbS CS/Y7REQLXd6LvmQ2u8sNHihiXCjEfA2OC2UQhxOhi7npzf6Rl/ZAYFpuiTrP55IvuneWSf5LAA0c ekmL1NnXWlTX3ukxZmxJ3SVi02ttEBOfJupOAar6UrpXW1g2KVI47pvrv/YsC3kZGNhPp5dmeJLEP Fug8KTHQV7ZR6OATNM8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgB0p-007Npk-1G; Sat, 25 Mar 2023 21:01:19 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgB0l-007Non-2z for linux-arm-kernel@lists.infradead.org; Sat, 25 Mar 2023 21:01:17 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F75A7FA; Sat, 25 Mar 2023 22:01:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679778073; bh=njmuQz/sfEKPGfRI9pv6Y5D/S1KWAHOVfjfyE6XFLmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qPhj0ux7fzLYIDnh1/Gen8aj3qj2by2GDykyH3ZSjGJCvkO8TBNmA3TVxAZYe1ghj 3nHHkcnJ1uVVObmsMI7STb0dKLkcGtzdNYgUJ2ng46AsFlXUJWWvQu4GxvPv70kyfU XmrS0j3kjkmepTunuW5joI8BA6vftdTepCdNT7y4= Date: Sat, 25 Mar 2023 23:01:20 +0200 From: Laurent Pinchart To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Adam Pigg , Thomas Petazzoni Subject: Re: [PATCH 2/9] media: v4l2: Add NV12_16L16 pixel format to v4l2 format info Message-ID: <20230325210120.GB22214@pendragon.ideasonboard.com> References: <20230324151228.2778112-1-paul.kocialkowski@bootlin.com> <20230324151228.2778112-3-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230324151228.2778112-3-paul.kocialkowski@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230325_140116_116547_E8AEC30A X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, Thank you for the patch. On Fri, Mar 24, 2023 at 04:12:21PM +0100, Paul Kocialkowski wrote: > Represent the NV12_16L16 pixel format in the v4l2 format info table. > This is a 16x16 tiled version of NV12. > > Signed-off-by: Paul Kocialkowski > --- > drivers/media/v4l2-core/v4l2-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c > index 3d044b31caad..5101989716aa 100644 > --- a/drivers/media/v4l2-core/v4l2-common.c > +++ b/drivers/media/v4l2-core/v4l2-common.c > @@ -280,6 +280,8 @@ const struct v4l2_format_info *v4l2_format_info(u32 format) > /* Tiled YUV formats */ > { .format = V4L2_PIX_FMT_NV12_4L4, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 2, .bpp = { 1, 2, 0, 0 }, .hdiv = 2, .vdiv = 2 }, > { .format = V4L2_PIX_FMT_P010_4L4, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 2, .bpp = { 2, 4, 0, 0 }, .hdiv = 2, .vdiv = 2 }, > + { .format = V4L2_PIX_FMT_NV12_16L16, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 2, .bpp = { 1, 2, 0, 0 }, .hdiv = 2, .vdiv = 2, > + .block_w = { 16, 16, 0, 0 }, .block_h = { 16, 16, 0, 0 } }, Not necessarily related to this patch, but I'm a bit puzzled by why V4L2_PIX_FMT_NV12_4L4 doesn't list block sizes. > > /* YUV planar formats, non contiguous variant */ > { .format = V4L2_PIX_FMT_YUV420M, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 3, .comp_planes = 3, .bpp = { 1, 1, 1, 0 }, .hdiv = 2, .vdiv = 2 }, -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel