From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BF61C74A5B for ; Mon, 27 Mar 2023 02:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uj6ms4OU/W+FFGl2qPRLhUo+zAPXYgZHDuZDAYADCT8=; b=u3uJkMu3gwQThI SknyXlUPbcSebfYTR3y7cqC0KHkLMv75ieWdqKljN2I5BLd/ktLpwQBE+G1kbkiHpplBOz/zFtQ6d LjUCPIv3v5q7WukcGcKPiX99wsiiWRivdABPRpRJdwAar2IYj+ji81qyUzC5WbgIIeaSGz1y17d5C +jPbldq0EjuVC29k4ky01rN51lPz4AY4EKF+f6c42hwcSDdIvR8hqgGgAm+VzV0W1TGsRExU+A7yw tp2krfukjf+aHAAqXaFG5Yn7akAJiX+HBNbX9Gv1xK28igNf7XKOxiLL/6a158D4dlJc077zVTIOd VyyVZT57XLZ9G359IQaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgcrK-009YkW-1w; Mon, 27 Mar 2023 02:45:22 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgcrG-009Yk0-2K for linux-arm-kernel@lists.infradead.org; Mon, 27 Mar 2023 02:45:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4AF73B80DA1; Mon, 27 Mar 2023 02:45:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF6AFC433EF; Mon, 27 Mar 2023 02:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679885116; bh=AiEbgLzIhGbD6g6j2H0IM5fDCH/xy7CmlIhEelLot2k=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=lGsTdYoHJpkcbpi1ryl9j1nwn7PTU1753FYC/owq7PtipZUJ8hDG+XZADL9ncVv+1 uDasc1xtzbJoU4BTZbZa0QdMiEspaN9XA2r+zcj13P9/FgjsoJ4MQ0QCgw3cancOUS Y5b2y39BDaEoEqD7m5U5Gd+mhiZYxI+bNzs0Jn/RLPwyBYC9EA/XRFQo2A46RU1et4 uwKZjfVhPfpggIghUud0jTWL/MOgh6NP6twgcexXbRNlqIXnleLgeXI07H1CdXnXGZ 541yNODHnkx1JdlGxMFw/3CW/I/xQcFfncWr2jESn+2H4EIHvRpblrLtrevCGZlGYx mj3RTfSg555Lw== Date: Mon, 27 Mar 2023 10:45:07 +0800 From: Shawn Guo To: Andreas Kemnade Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, marex@denx.de, max.krummenacher@toradex.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] ARM: dts: imx: Add devicetree for Tolino Vison Message-ID: <20230327024507.GG3364759@dragon> References: <20230317081618.2387407-1-andreas@kemnade.info> <20230317081618.2387407-3-andreas@kemnade.info> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230317081618.2387407-3-andreas@kemnade.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_194519_038776_9BAF77D7 X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 09:16:18AM +0100, Andreas Kemnade wrote: > Add a devicetree for the Tolino Vision Ebook reader. It is based > on boards marked with "37NB-E60Q30+4A3". It is equipped with an i.MX6SL > SoC. > > Expected to work: > - Buttons > - Wifi > - LEDs > - uSD > - eMMC > - USB > - RTC > - Touchscreen > - Backlight > > Signed-off-by: Andreas Kemnade > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6sl-tolino-vision.dts | 490 +++++++++++++++++++++ > 2 files changed, 491 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6sl-tolino-vision.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index efe4152e5846..159363f46522 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -690,6 +690,7 @@ dtb-$(CONFIG_SOC_IMX6SL) += \ > imx6sl-kobo-aura2.dtb \ > imx6sl-tolino-shine2hd.dtb \ > imx6sl-tolino-shine3.dtb \ > + imx6sl-tolino-vision.dtb \ > imx6sl-tolino-vision5.dtb \ > imx6sl-warp.dtb > dtb-$(CONFIG_SOC_IMX6SLL) += \ > diff --git a/arch/arm/boot/dts/imx6sl-tolino-vision.dts b/arch/arm/boot/dts/imx6sl-tolino-vision.dts > new file mode 100644 > index 000000000000..035d1dea42c4 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6sl-tolino-vision.dts > @@ -0,0 +1,490 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device tree for the Tolino Vison ebook reader > + * > + * Name on mainboard is: 37NB-E60Q30+4A3 > + * Serials start with: 6032 > + * > + * Copyright 2023 Andreas Kemnade > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include > +#include "imx6sl.dtsi" > + > +/ { > + model = "Tolino Vision"; > + compatible = "kobo,tolino-vision", "fsl,imx6sl"; > + > + aliases { > + mmc0 = &usdhc4; > + mmc1 = &usdhc2; > + }; > + > + backlight { > + compatible = "pwm-backlight"; > + pwms = <&ec 0 50000>; > + power-supply = <&backlight_regulator>; > + }; > + > + backlight_regulator: regulator-backlight { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_backlight_power>; > + regulator-name = "backlight"; > + gpio = <&gpio2 10 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + chosen { > + stdout-path = &uart1; > + }; > + > + gpio_keys: gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_keys>; > + > + key-cover { > + /* magnetic sensor in the corner next to the uSD slot */ > + label = "Cover"; > + gpios = <&gpio5 12 GPIO_ACTIVE_LOW>; > + linux,code = ; > + linux,input-type = ; > + wakeup-source; > + }; > + > + key-fl { > + label = "Frontlight"; > + gpios = <&gpio3 26 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + > + key-power { > + label = "Power"; > + gpios = <&gpio5 8 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + }; > + }; > + > + leds: leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_leds>; > + > + led-0 { > + /* LED on home button */ > + color = ; > + function = LED_FUNCTION_STATUS; > + gpios = <&gpio5 10 GPIO_ACTIVE_LOW>; > + }; > + > + led-1 { > + /* LED on power button */ > + color = ; > + function = LED_FUNCTION_POWER; > + gpios = <&gpio5 7 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "timer"; > + }; > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x20000000>; > + }; > + > + reg_wifi: regulator-wifi { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wifi_power>; > + regulator-name = "SD3_SPWR"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + gpio = <&gpio4 29 GPIO_ACTIVE_LOW>; > + }; > + > + > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wifi_reset>; > + post-power-on-delay-ms = <20>; > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&i2c1 { > + pinctrl-names = "default","sleep"; > + pinctrl-0 = <&pinctrl_i2c1>; > + pinctrl-1 = <&pinctrl_i2c1_sleep>; > + status = "okay"; > + > + touchscreen@15 { > + compatible = "elan,ektf2132"; > + reg = <0x15>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ts>; > + power-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH>; > + interrupts-extended = <&gpio5 6 IRQ_TYPE_EDGE_FALLING>; > + }; > + > + accelerometer@1d { > + reg = <0x1d>; > + compatible = "fsl,mma8652"; Flipped the order of these two. Applied both, thanks! Shawn > + }; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel