From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EE86C76195 for ; Mon, 27 Mar 2023 04:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PAmTPu6u+1hYGFPYNiLVHZyHWwFDHlmOxLoaQy7LOOQ=; b=n2YUnU3LqsZ0DE RSqF7H6K4jqTM7S12n/zaS2KI9GOgNoa16CN/iJe2zWEprqd9Oxja34DQFc5WSuSFlANOdIxSUqV4 WNWDLd7dEndS3KRaBemP5gtElcy3r2+x88UUcHEMlMxD09IqsdgGDsUDmeOpnlohZqPZ2LL2G/mON TKExPpC6PXbPcTtcQ8Y4cfW+xM9Tf7gTIjzXtAlgBnnanhpEL1HWmDumF1JT/DQvZb0xN2X6Swhc4 ZmoHZ4gzaaKac0XteCJGZLy+BVOKGe+IgI/Wklkdnx/uwy/AUx7Od+kQtNvRgPX4FKRvhfNzjQzGe jWzj9BaBlB2ugGg43CwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgeom-009jpO-1L; Mon, 27 Mar 2023 04:50:52 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgeoi-009jor-2E for linux-arm-kernel@lists.infradead.org; Mon, 27 Mar 2023 04:50:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BA1B1B80D17; Mon, 27 Mar 2023 04:50:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0459C433EF; Mon, 27 Mar 2023 04:50:40 +0000 (UTC) From: Greg Ungerer To: peng.fan@oss.nxp.com Cc: Markus.Niebel@ew.tq-group.com, abailon@baylibre.com, abelvesa@kernel.org, aford173@gmail.com, devicetree@vger.kernel.org, djakov@kernel.org, festevam@gmail.com, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, marex@denx.de, paul.elder@ideasonboard.com, peng.fan@nxp.com, robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, gerg@kernel.org Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Date: Mon, 27 Mar 2023 14:50:37 +1000 Message-Id: <20230327045037.593326-1-gerg@linux-m68k.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220703091451.1416264-8-peng.fan@oss.nxp.com> References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_215048_898399_2926AA13 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/3/22 17:13, Peng Fan wrote: > From: Peng Fan > > Add interconnect property for hsio blk ctrl > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 08bd57742294..9cceeeeb26be 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1109,6 +1109,11 @@ hsio_blk_ctrl: blk-ctrl@32f10000 { > <&pgc_hsiomix>, <&pgc_pcie_phy>; > power-domain-names = "bus", "usb", "usb-phy1", > "usb-phy2", "pcie", "pcie-phy"; > + interconnects = <&noc IMX8MP_ICM_NOC_PCIE &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_USB1 &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_USB2 &noc IMX8MP_ICN_HSIO>, > + <&noc IMX8MP_ICM_PCIE &noc IMX8MP_ICN_HSIO>; > + interconnect-names = "noc-pcie", "usb1", "usb2", "pcie"; > #power-domain-cells = <1>; > }; > }; This change completely breaks USB for me on a new iMX8mp platform I am working with. Before this change normal USB probe looks good: xhci-hcd xhci-hcd.0.auto: xHCI Host Controller xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 1 xhci-hcd xhci-hcd.0.auto: hcc params 0x0220fe6d hci version 0x110 quirks 0x0000000000010010 xhci-hcd xhci-hcd.0.auto: irq 206, io mem 0x38100000 xhci-hcd xhci-hcd.0.auto: xHCI Host Controller xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 2 xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.03 usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 usb usb1: Product: xHCI Host Controller usb usb1: Manufacturer: Linux 6.3.0-rc4-dirty xhci-hcd .... But after this commit is applied, no USB probe messages at all. USB worked fine in 6.0 for me, but when I switched up to 6.1 USB was broken, I bisected to this as being the offending commit. This is still broken for me in todays 6.3-rc4. If I revert this change (and only this change) USB works again. Any thoughts on why this breaks USB? Regards greg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel