From: Will Deacon <will@kernel.org>
To: void0red <void0red@gmail.com>
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/smmuv3: add a check of devm_add_action in smmu_pmu_setup_msi
Date: Mon, 27 Mar 2023 12:26:53 +0100 [thread overview]
Message-ID: <20230327112652.GA30874@willie-the-truck> (raw)
In-Reply-To: <20230227032557.894274-1-void0red@gmail.com>
On Mon, Feb 27, 2023 at 11:25:57AM +0800, void0red wrote:
> From: Kang Chen <void0red@gmail.com>
>
> devm_add_action may fails, add a warning when it happens.
>
> Signed-off-by: Kang Chen <void0red@gmail.com>
> ---
> drivers/perf/arm_smmuv3_pmu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c
> index 25a269d43..307bac904 100644
> --- a/drivers/perf/arm_smmuv3_pmu.c
> +++ b/drivers/perf/arm_smmuv3_pmu.c
> @@ -724,7 +724,11 @@ static void smmu_pmu_setup_msi(struct smmu_pmu *pmu)
> pmu->irq = msi_get_virq(dev, 0);
>
> /* Add callback to free MSIs on teardown */
> - devm_add_action(dev, smmu_pmu_free_msis, dev);
> + ret = devm_add_action(dev, smmu_pmu_free_msis, dev);
> + if (ret) {
> + dev_warn(dev, "failed to add callback to free MSIs on teardown\n");
> + return;
> + }
I appreciate that you're following the existing error handling in this
function, but I don't think this message is especially helpful. We'd be
better off propagating the error and failing the probe in this case, I
reckon.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-03-27 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 3:25 [PATCH] perf/smmuv3: add a check of devm_add_action in smmu_pmu_setup_msi void0red
2023-03-27 11:26 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327112652.GA30874@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=void0red@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox