From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE50EC76195 for ; Mon, 27 Mar 2023 21:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dcIjDyN0t5hssjh8akqSvx5gQ+Y1nn/uyCwzZeuCPsU=; b=dxJeGyg5utTv0A ZKcOgurUkvoH34E32kWg5W+F1MbcUPJySs6mqSmecKsiAcNTY54IWYV2KKG1gVEUtNMHnbyrAQLTP f07jN1xrlLNyT+eoyjOq2Ak2pW2P0vm1fTY1N7UP5Ch1/ccR0xZzNVpYjK1wPih/2nwGGvx8d7y1K 6/hDn7WugDdAqvoqLtsooF60gN7omoxOGWnJy9DuXrPfW/FZFKjhWkc9vDlB4dEnK0imCwaqY/SvK gcGaI1/EXAW+QLYVqx5Rzcg7GPYe4pvqdw3vGA41WWiNjYODkraSROc+GC1cNvmZCukFvd1+I+nOH NTEAf8CY6EOXcGOf2RDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgty9-00CMqn-0c; Mon, 27 Mar 2023 21:01:33 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgty6-00CMq7-1f for linux-arm-kernel@lists.infradead.org; Mon, 27 Mar 2023 21:01:32 +0000 Received: by mail-pj1-x102e.google.com with SMTP id h12-20020a17090aea8c00b0023d1311fab3so10361318pjz.1 for ; Mon, 27 Mar 2023 14:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679950890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I47QgG80c18NHe2QXGtpe6IXSCOJbQsxdw+n6WwyTPc=; b=qEMxtwtl57eh3jwNaDlneulqEJP59uEeZdGMNUBJvreTP9e94ESJcY8Jo7vY9WHvSQ ahMzjIJhOtkCwnV0g5A4O/aNEWAnicKi2dfHbEnZ5lShR7llIZ49aK2KwBA45Fh44Dbj 5fK7WxfNzUdfG5Ci0+Y9QADuCr9zGKlPIwJVis+6X4ICttn9DcgH5dNw1Wj4LRRgaI4a pPeeDS2OmegcbFJPxOHZVp7sE5P+x0vEhMGlAin26j6QA3/4vTHTHdck9n4FHyJ0WGrD FTG4+dOiu8nnONYgQEOPIjtX5dFKN1NadCgxyamiPKEx5Y4eRsQpVnp5O+mKC3uPdnT4 I+eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679950890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I47QgG80c18NHe2QXGtpe6IXSCOJbQsxdw+n6WwyTPc=; b=JdPrDrPNusfhvqjOPYqSr9VtkLRC1iAvx81s7UNZLgtx4f9cgRSXAFJUn5qkLc9tK1 dR53UyPP/ZkXLepRDdsovDtRcTyB2u3v0Rx7eXUtCmmkUnj1Q+9/daVMQPq67jLDYbMG /PBucHxlbtQ1UU8WLPHbDeew+JO+schLbSXRIN6NaRPcj0bitpcA0rE/B09deBFDQ3FT Ni/RaVEsJ06/siQbbG/RCVcniU9Uf5fK/YGEZKEU32y4QxNsRv4LemJfTZmGEBeHPaPi E4vTMVhT1FUJsYTNnsNOeoaS/wcYppx+tBBTqiUiTNg3HVAR+9QX8ql5zynTtpOdSPhv zLuw== X-Gm-Message-State: AAQBX9cY03jsaU3hYQU8KtEBy+l/itOGvvew7GyPuzEUidw6H8eg9RM1 2IG67QzcDQTg6RLZA1fZ3NfjWA== X-Google-Smtp-Source: AKy350aHdL7wM6XPVYpmTCr5+ubBfWHZ0yH2Ao164vY7yTBP8KHuhKBry5rT2/49WOb0LzeOxmuENA== X-Received: by 2002:a17:903:32ca:b0:1a0:53f3:3761 with SMTP id i10-20020a17090332ca00b001a053f33761mr13617248plr.15.1679950889923; Mon, 27 Mar 2023 14:01:29 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:ad52:968f:ad4a:52d2]) by smtp.gmail.com with ESMTPSA id y15-20020a1709027c8f00b001a21fceff33sm6267741pll.48.2023.03.27.14.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:01:29 -0700 (PDT) Date: Mon, 27 Mar 2023 15:01:26 -0600 From: Mathieu Poirier To: MD Danish Anwar Subject: Re: [PATCH v5 3/5] soc: ti: pruss: Add pruss_cfg_read()/update() API Message-ID: <20230327210126.GC3158115@p14s> References: <20230323062451.2925996-1-danishanwar@ti.com> <20230323062451.2925996-4-danishanwar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230323062451.2925996-4-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_140130_567597_AC9AB805 X-CRM114-Status: GOOD ( 25.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , srk@ti.com, linux-omap@vger.kernel.org, Vignesh Raghavendra , Tero Kristo , devicetree@vger.kernel.org, netdev@vger.kernel.org, Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew F. Davis" , Roger Quadros , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 23, 2023 at 11:54:49AM +0530, MD Danish Anwar wrote: > From: Suman Anna > > Add two new generic API pruss_cfg_read() and pruss_cfg_update() to > the PRUSS platform driver to read and program respectively a register > within the PRUSS CFG sub-module represented by a syscon driver. > > These APIs are internal to PRUSS driver. Various useful registers > and macros for certain register bit-fields and their values have also > been added. > > Signed-off-by: Suman Anna > Co-developed-by: Grzegorz Jaszczyk > Signed-off-by: Grzegorz Jaszczyk > Signed-off-by: Puranjay Mohan > Signed-off-by: MD Danish Anwar > --- > drivers/soc/ti/pruss.c | 1 + > drivers/soc/ti/pruss.h | 112 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 113 insertions(+) > create mode 100644 drivers/soc/ti/pruss.h > This patch doesn't compile without warnings. > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index 126b672b9b30..2fa7df667592 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include "pruss.h" > > /** > * struct pruss_private_data - PRUSS driver private data > diff --git a/drivers/soc/ti/pruss.h b/drivers/soc/ti/pruss.h > new file mode 100644 > index 000000000000..4626d5f6b874 > --- /dev/null > +++ b/drivers/soc/ti/pruss.h > @@ -0,0 +1,112 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * PRU-ICSS Subsystem user interfaces > + * > + * Copyright (C) 2015-2023 Texas Instruments Incorporated - http://www.ti.com > + * MD Danish Anwar > + */ > + > +#ifndef _SOC_TI_PRUSS_H_ > +#define _SOC_TI_PRUSS_H_ > + > +#include > +#include > + > +/* > + * PRU_ICSS_CFG registers > + * SYSCFG, ISRP, ISP, IESP, IECP, SCRP applicable on AMxxxx devices only > + */ > +#define PRUSS_CFG_REVID 0x00 > +#define PRUSS_CFG_SYSCFG 0x04 > +#define PRUSS_CFG_GPCFG(x) (0x08 + (x) * 4) > +#define PRUSS_CFG_CGR 0x10 > +#define PRUSS_CFG_ISRP 0x14 > +#define PRUSS_CFG_ISP 0x18 > +#define PRUSS_CFG_IESP 0x1C > +#define PRUSS_CFG_IECP 0x20 > +#define PRUSS_CFG_SCRP 0x24 > +#define PRUSS_CFG_PMAO 0x28 > +#define PRUSS_CFG_MII_RT 0x2C > +#define PRUSS_CFG_IEPCLK 0x30 > +#define PRUSS_CFG_SPP 0x34 > +#define PRUSS_CFG_PIN_MX 0x40 > + > +/* PRUSS_GPCFG register bits */ > +#define PRUSS_GPCFG_PRU_GPO_SH_SEL BIT(25) > + > +#define PRUSS_GPCFG_PRU_DIV1_SHIFT 20 > +#define PRUSS_GPCFG_PRU_DIV1_MASK GENMASK(24, 20) > + > +#define PRUSS_GPCFG_PRU_DIV0_SHIFT 15 > +#define PRUSS_GPCFG_PRU_DIV0_MASK GENMASK(15, 19) > + > +#define PRUSS_GPCFG_PRU_GPO_MODE BIT(14) > +#define PRUSS_GPCFG_PRU_GPO_MODE_DIRECT 0 > +#define PRUSS_GPCFG_PRU_GPO_MODE_SERIAL BIT(14) > + > +#define PRUSS_GPCFG_PRU_GPI_SB BIT(13) > + > +#define PRUSS_GPCFG_PRU_GPI_DIV1_SHIFT 8 > +#define PRUSS_GPCFG_PRU_GPI_DIV1_MASK GENMASK(12, 8) > + > +#define PRUSS_GPCFG_PRU_GPI_DIV0_SHIFT 3 > +#define PRUSS_GPCFG_PRU_GPI_DIV0_MASK GENMASK(7, 3) > + > +#define PRUSS_GPCFG_PRU_GPI_CLK_MODE_POSITIVE 0 > +#define PRUSS_GPCFG_PRU_GPI_CLK_MODE_NEGATIVE BIT(2) > +#define PRUSS_GPCFG_PRU_GPI_CLK_MODE BIT(2) > + > +#define PRUSS_GPCFG_PRU_GPI_MODE_MASK GENMASK(1, 0) > +#define PRUSS_GPCFG_PRU_GPI_MODE_SHIFT 0 > + > +#define PRUSS_GPCFG_PRU_MUX_SEL_SHIFT 26 > +#define PRUSS_GPCFG_PRU_MUX_SEL_MASK GENMASK(29, 26) > + > +/* PRUSS_MII_RT register bits */ > +#define PRUSS_MII_RT_EVENT_EN BIT(0) > + > +/* PRUSS_SPP register bits */ > +#define PRUSS_SPP_XFER_SHIFT_EN BIT(1) > +#define PRUSS_SPP_PRU1_PAD_HP_EN BIT(0) > +#define PRUSS_SPP_RTU_XFR_SHIFT_EN BIT(3) > + > +/** > + * pruss_cfg_read() - read a PRUSS CFG sub-module register > + * @pruss: the pruss instance handle > + * @reg: register offset within the CFG sub-module > + * @val: pointer to return the value in > + * > + * Reads a given register within the PRUSS CFG sub-module and > + * returns it through the passed-in @val pointer > + * > + * Return: 0 on success, or an error code otherwise > + */ > +static int pruss_cfg_read(struct pruss *pruss, unsigned int reg, unsigned int *val) > +{ > + if (IS_ERR_OR_NULL(pruss)) > + return -EINVAL; > + > + return regmap_read(pruss->cfg_regmap, reg, val); > +} > + > +/** > + * pruss_cfg_update() - configure a PRUSS CFG sub-module register > + * @pruss: the pruss instance handle > + * @reg: register offset within the CFG sub-module > + * @mask: bit mask to use for programming the @val > + * @val: value to write > + * > + * Programs a given register within the PRUSS CFG sub-module > + * > + * Return: 0 on success, or an error code otherwise > + */ > +static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, > + unsigned int mask, unsigned int val) > +{ > + if (IS_ERR_OR_NULL(pruss)) > + return -EINVAL; > + > + return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); > +} > + > +#endif /* _SOC_TI_PRUSS_H_ */ > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel