linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable
@ 2022-09-20  6:51 cgel.zte
  2023-03-28  5:44 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-09-20  6:51 UTC (permalink / raw)
  To: tony
  Cc: khilman, linux, linux-omap, linux-arm-kernel, linux-kernel,
	ye xingchen, Zeal Robot

From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value amx3_common_init() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 arch/arm/mach-omap2/pm33xx-core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
index bf0d25fd2cea..4b29d8323ffc 100644
--- a/arch/arm/mach-omap2/pm33xx-core.c
+++ b/arch/arm/mach-omap2/pm33xx-core.c
@@ -105,8 +105,6 @@ static int amx3_common_init(int (*idle)(u32 wfi_flags))
 
 static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))
 {
-	int ret;
-
 	gfx_l4ls_clkdm = clkdm_lookup("gfx_l4ls_gfx_clkdm");
 
 	if (!gfx_l4ls_clkdm) {
@@ -114,9 +112,7 @@ static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))
 		return -ENODEV;
 	}
 
-	ret = amx3_common_init(idle);
-
-	return ret;
+	return amx3_common_init(idle);
 }
 
 static int am43xx_suspend_init(int (*idle)(u32 wfi_flags))
-- 
2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable
  2022-09-20  6:51 [PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable cgel.zte
@ 2023-03-28  5:44 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2023-03-28  5:44 UTC (permalink / raw)
  To: cgel.zte
  Cc: khilman, linux, linux-omap, linux-arm-kernel, linux-kernel,
	ye xingchen, Zeal Robot

* cgel.zte@gmail.com <cgel.zte@gmail.com> [220920 09:43]:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Return the value amx3_common_init() directly instead of storing it in
> another redundant variable.

Thanks applying into omap-for-v6.4/cleanup.

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-28  5:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-20  6:51 [PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable cgel.zte
2023-03-28  5:44 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).