From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95DBCC76196 for ; Tue, 28 Mar 2023 09:54:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4RJxo/JwjRJBDDLUVmQa7zjgTEYKJuwhLlxFgWpk3Po=; b=m0T36Q3vcZwPjH Alwy/ih6zUmo562g0CF0aTE9mELjM6iLxPWQf0DussdR5EUW+SYPKpOFWdSKt1aKDlM5570ZPPOPA ctrZirekfnYUDJpRuIycw4LZlm3fm+/eNS10QXTIt9GjOx3Z0dgxI7WvGpdPN0zlYRgCJVcRxeiDR 7PADFtksQAcBTfNCIDYKlMRezwDMbkJ+BPzFr+MpKdBSiM0QNN+DnKSSu+MiLpjKXQoxabi7elw9E dT/zqSETKF2r+rXcc0j7Fm16szaEuu5Plw/KM8NH+d2LhGNtLGLLRct4TGvrjrYDvkxRq5vdAv/3A sdbKGjJTY+J7PEEn6xWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph61V-00DoGx-1k; Tue, 28 Mar 2023 09:53:49 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph61S-00DoGA-07 for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 09:53:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BFA88B817B1; Tue, 28 Mar 2023 09:53:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02A0BC433EF; Tue, 28 Mar 2023 09:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679997220; bh=VhcEmaPkel8t+3tqqVdwI5zgGFM9/5+T/o02FWQ94dM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ivQoSC2YH3DO/kBIom8ARFZmat2GWfuuU3f83pGVVozRRhpq2SRPLfvey5XkBprFx 14lDUpzUCsn3rMU79Scw5SP7smAaNF8xkyTIAiYp8YHKHy/JiXRo+5/xH6r+Mb5Ebw 8ccpCKE6luvFYvl7Rl4mAZyjn23R6xqisLGSd8FdTKHVCbhIo4Dm+llX/1t6wmwezD 3Nv0HqG2IOFkwZg0RSzG7qA8f1pI4bWS2EHjDhWA8CQ4Caw+i6opHqlMgz139SW8q2 97UjzKwuaQAtcw0DXdoovGxBWDquUAVf4wqC6cABXTsY2PxN/hVY7J9C+l9wceolv3 hPF2jR3ufuGEQ== Date: Tue, 28 Mar 2023 11:53:37 +0200 From: Andi Shyti To: Krzysztof Kozlowski Cc: Yang Li , kyungmin.park@samsung.com, myungjoo.ham@samsung.com, cw00.choi@samsung.com, alim.akhtar@samsung.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource() Message-ID: <20230328095337.sr6s3klmhiyz63pr@intel.intel> References: <20230328053853.23159-1-yang.lee@linux.alibaba.com> <8779217b-bd70-37a4-c779-139690048d4d@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8779217b-bd70-37a4-c779-139690048d4d@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_025346_242151_9BF55DAE X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote: > On 28/03/2023 07:38, Yang Li wrote: > > According to commit 890cc39a8799 ("drivers: provide > > devm_platform_get_and_ioremap_resource()"), convert > > I don't understand why do you reference this commit. There is no bug > introduced there, there is nothing related to this driver. > > > platform_get_resource(), devm_ioremap_resource() to a single > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > what this function does. I've seen Yang has sent many of these cleanups, perhaps he can write something like: " Commit 890cc39a8799 ("drivers: provide devm_platform_get_and_ioremap_resource()") introduces the devm_platform_get_and_ioremap_resource() function which combines both platform_get_resource() and devm_ioremap_resource() into a single call. Update the code to use the new combined function instead of the separate calls. " With that Reviewed-by: Andi Shyti Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel