From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46CE1C76195 for ; Tue, 28 Mar 2023 11:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4xhyYhAvLq/eFEuTXstbccwE51FuJm9IreYIAPbn9sg=; b=pSgXNLU4ZM0msl Qc+AIhRL3I4q2utRL48lxrDwliziFt4iO/zMGGgfcdCjgYLf7KTAb66isiLbSNtf+U1Vff5/v4btP 1kjGO7k+HG+uf5eF4aGfDTnG9pa3Jc1VFzAgn87vjVGQr+na2jt9w7gXKcG+ObNl6fVDppc9T/gfN RYcy6GGppQ5B9DH6dcmFF5TVW7ONDhzj8q//Y1EOh+wgeUvitScfoohGUQ1NaYtQJyfMRDAwgXyt+ 6jncj88UxK/rQUotkErOLNYY751kFVpaVcmAOs59crBFnxA8k+IDbAtbEbO0kIc/VHfFOCzKpHnbO iOGW9fgdNd/mDVACr/jQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph7nt-00EDKq-1L; Tue, 28 Mar 2023 11:47:53 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph7nq-00EDK5-0g for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 11:47:51 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32SBlh76060327; Tue, 28 Mar 2023 06:47:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680004063; bh=nRCPznyG8qPMq1TD0NttucUdDHIhiajZD9URKVA9jYE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=HsM/O1c/VajqKfKZY7Vu1YEbwf0aHPBqJY9KjWFWDZp0bS3GA+2Kze66z6vTRmlW5 W+yTX1XmYqZEiIIau4jdpjGNBY+bHCdEapXkT7e4pg56MMth1UJUFzBnWDA+JhIuM5 SdgyznJdAvinRp1pl6JfYRPmG1fcG53qNdtup4S4= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32SBlh1J026415 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Mar 2023 06:47:43 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 28 Mar 2023 06:47:43 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 28 Mar 2023 06:47:43 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32SBlghd120488; Tue, 28 Mar 2023 06:47:42 -0500 Date: Tue, 28 Mar 2023 06:47:42 -0500 From: Nishanth Menon To: Vaishnav Achath CC: Sinthu Raja , Tero Kristo , Rob Herring , Vignesh Raghavendra , Krzysztof Kozlowski , , , , Sinthu Raja Subject: Re: [PATCH V3 1/2] arm64: dts: ti: k3-j721s2-mcu-wakeup: Fix IO PADCONFIG size for wakeup domain Message-ID: <20230328114742.tnaa5hi3qm3rsgld@ecology> References: <20230316114102.3602-1-sinthu.raja@ti.com> <20230316114102.3602-2-sinthu.raja@ti.com> <5f08cb2f-d2de-8e4e-a9be-1ef3a5fd3a39@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5f08cb2f-d2de-8e4e-a9be-1ef3a5fd3a39@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_044750_354012_030D8D3F X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:48-20230328, Vaishnav Achath wrote: > Hi Sinthu, > > On 16/03/23 17:11, Sinthu Raja wrote: > > From: Sinthu Raja > > > > The size of wkup domain I/O PADCONFIG register set is incorrect for J721S2. > > Therefore, update the PADCONFIG total offset size to the correct value for > > J721S22 SoC. > > > > Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC") > > Signed-off-by: Sinthu Raja > > --- > > > > Changes in V3: > > - Added Fix tag > > > > Changes in V2: > > - Update commit description. > > - Update the offset value to 0x194 because 0x190 is the last register of the > > IO PADCONFIG register set. > > > > The existing PADCONFIG register region descriptions in the pinctrl nodes seems > to be incorrect for j721s2-main and j721s2-mcu-wakeup due to non-addressable > holes in the region which causes bus aborts when the registers are read and > causes system crash if we read something like, > /sys/kernel/debug/pinctrl/4301c000.pinctrl-pinctrl-single/pins > > This is what I saw from inspection of the datasheet: > > * WKUP_PADCONFIG13, WKUP_PADCONFIG25 missing in WKUP_PADCONFIG region > * MAIN_PADCONFIG 64-68 missing in MAIN_PADCONFIG region > > I have verified that your patch does not introduce new issues, but since it is a > Fix patch, I will defer the decision to the maintainers on whether we should > split the nodes to avoid non-addressable regions and fix it completely here or > later do a fix for the split. Do a single fix-up please. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel