From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAA38C6FD18 for ; Tue, 28 Mar 2023 13:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CIiLZJf1EjAfvPpMJyhgpmlrZKEkn9uQEe1rPI6So8k=; b=rRggpFxAs3mgBn lu5ZUI5ZB42Rl8OusTRYDlLZEs554h4jTxzia3xufwbFWl6erv0IvO+wqvT72UZGK9AkqTy6Vvlfl RQLGZwydp+kSscye0HsT5DH3vAusq66WezerHeFsQV5R3kcUDN1DbjOSIhFjKgYahY3L9DekurCzj KZhkfz8To9lWwPVrj1fUdMfkk5dFhmAKIjvWPsoucoHod67aGwWXbf5lYXx/CTMo86XAGY6hORrqj C5ryg6e1c1/mr21rqpcy2MVoIa0VBye1kgrHU6du31Mfbdzd7rWUKFa9XBPudiNzvXOAG2u3rGl1e 1CFlEmScaYC2IHndshyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph97k-00EW7M-2i; Tue, 28 Mar 2023 13:12:28 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph97g-00EW6J-3B for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 13:12:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 85E56B81A99; Tue, 28 Mar 2023 13:12:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87623C433EF; Tue, 28 Mar 2023 13:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680009142; bh=syclwcK/oT0pSom8NZFtmAdR8n43l8GNIE7YH56c9w8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DM0XoB3KQaJfPLp3jiKz+cfjQWvr72eRkBryHiXwIgMq9QAObJ8b5ZBrKxdsPYopW 7NId+xloccQjYxKmgd2LZLICdSoPCHrWRVKgBgcjBe1sYjK4nFzbgTzRJIfRRfRdPu Iw1gej7xeMbyfGvBkptrrrCBcSJMqwMNhIL1ViYiLt8GrxNhru3ZhN8MxMZt9Sbma+ A6WeUDFduyIx8+RPIJwQ9KG3s1gOAdKNXsXl4T7HF/5fIfnGRwm1LBAx/sNeJ4RNC8 kXt+ZhOfDFM+rP++NYfpkhcaXCo7QRT42dNgQY+nxVXle2Y0FczHBsoQOi30Ix7mcB Q+kEcdj9JdCBQ== Date: Tue, 28 Mar 2023 15:12:19 +0200 From: Andi Shyti To: Ryan Chen Cc: jk@codeconstruct.com.au, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Linus Walleij , linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH v7 2/2] i2c: aspeed: support ast2600 i2c new register mode driver Message-ID: <20230328131219.khfd2jz3z4es5bzy@intel.intel> References: <20230327092524.3916389-1-ryan_chen@aspeedtech.com> <20230327092524.3916389-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230327092524.3916389-3-ryan_chen@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_061225_185466_D07E3C72 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ryan, [...] > + ret = of_property_read_u32(dev->of_node, > + "i2c-scl-clk-low-timeout-us", > + &i2c_bus->timeout); in your v6 patch this was a boolean value. If you need to keep it boolean you have the "i2c-scl-has-clk-low-timeout". > + if (ret < 0) { > + i2c_bus->timeout = 0; > + } else { > + /* i2c timeout counter: use base clk4 1Mhz > + * per unit: 1/(1000/4096) = 4096us > + */ > + i2c_bus->timeout /= 4096; > + } Can you please run checkpatch.pl before sending the patch? [...] > + dev_info(dev, "%s [%d]: adapter [%d khz] mode [%d]\n", > + dev->of_node->name, i2c_bus->adap.nr, i2c_bus->bus_frequency / 1000, > + i2c_bus->mode); > + > + return 0; > + > + return ret; can you also please do some cleanups before sending the patch? Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel