From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 909A2C76196 for ; Tue, 28 Mar 2023 13:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c3qOusd3pMM+RPn5gM/eHDtCUzZCHr5xv5QhgD65GYk=; b=k3vyQFCWI50WhU arFE3Ul2sIX1aquzTMsQjNHGubJ+WHdPZCR79AO4lp/xlHveFIdm18QqT0+bwMKTab41zxEtxU6kp Ypf39YjGmZK8Y9f7nI2idwIgJQhZ+OYhfs8YmhtUNOkYFr59ijtaJZSZuN+FnkqAYwx5o97n0cwfm ETwmROlwettJMyp1ydBL2/gBYhbROq6JSWbK7/Q8jEQfVfpNkZLzxCQ5lgUNK5MBckr+vvmiP3ULd 7tilC06z82KSamqgLLvFap56YCdTcLRFb1vhloELy8+SAL32vHLsDQmSxBQ7T+Hwe0wQsbGaHS/Ak PvqfYQ7PBd6f5F+Dx/LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph9PY-00Eadj-2f; Tue, 28 Mar 2023 13:30:52 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph9P8-00EaQR-31 for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 13:30:30 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32SDUOqO088362; Tue, 28 Mar 2023 08:30:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680010224; bh=lbr9wtZJ3+vqB726ZlcF2VKPodm4TfjxZUt3/w4yNf0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=HJHqwDqUMcg3KzmVzcp1Pu4o48Y9SJLupzb7zt/jh6LsOHsUwqrAEtoGDshQKKw1e PRa1j2AYpyvNzi8BdXJB7cMYk9FJAJi83Sc7uoZPOYd4X34yUr/WCEAqidLopd1juJ Dy4dMZoWdHzKjsPPhbICVxHq9YuO4ydBtffn1YrY= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32SDUOXo127195 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Mar 2023 08:30:24 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 28 Mar 2023 08:30:24 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 28 Mar 2023 08:30:24 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32SDUO4v124470; Tue, 28 Mar 2023 08:30:24 -0500 Date: Tue, 28 Mar 2023 08:30:24 -0500 From: Nishanth Menon To: Roger Quadros CC: , , , , , , , Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port for USB0 Message-ID: <20230328133024.ow6cvm22o2c5heem@untrimmed> References: <20230328124315.123778-1-rogerq@kernel.org> <20230328124315.123778-3-rogerq@kernel.org> <20230328131810.x2j6uvwzhniclvwf@evoke> <3bd6191c-caa4-15a8-92ad-17a07ec085e2@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3bd6191c-caa4-15a8-92ad-17a07ec085e2@kernel.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_063027_063968_9D605B07 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:20-20230328, Roger Quadros wrote: > > > On 28/03/2023 16:18, Nishanth Menon wrote: > > On 15:43-20230328, Roger Quadros wrote: > >> USB0 is a Type-C port with dual data role and power sink. > >> > >> Signed-off-by: Roger Quadros > >> --- > >> arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 4 ++ > >> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 44 ++++++++++++++++++- > >> .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 4 -- > >> 3 files changed, 47 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts > >> index b2ca19e3042e..a3c3609833fd 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts > >> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts > >> @@ -225,3 +225,7 @@ ldo4_reg: ldo4 { > >> }; > >> }; > >> }; > >> + > >> +&usb0 { > >> + dr_mode = "peripheral"; > >> +}; > >> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > >> index cdc0858dd1b2..13fdaa9ce4e7 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts > >> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > >> @@ -136,6 +136,35 @@ AM62X_IOPAD(0x01d4, PIN_INPUT, 7) /* (B15) UART0_RTSn.GPIO1_23 */ > >> }; > >> }; > >> > >> +&main_i2c0 { > >> + typec_pd: tps6598x@3f { > >> + compatible = "ti,tps6598x"; > >> + reg = <0x3f>; > >> + interrupt-parent = <&exp1>; > >> + interrupts = <17 IRQ_TYPE_EDGE_FALLING>; > >> + interrupt-names = "irq"; > >> + > >> + connector { > >> + compatible = "usb-c-connector"; > >> + label = "USB-C"; > >> + self-powered; > >> + data-role = "dual"; > >> + power-role = "sink"; > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + port@0 { > >> + reg = <0>; > >> + usb_con_hs: endpoint { > >> + remote-endpoint = <&usb0_hs_ep>; > >> + }; > >> + }; > >> + }; > >> + }; > >> + }; > >> +}; > >> + > >> &main_i2c1 { > >> exp1: gpio@22 { > >> compatible = "ti,tca6424"; > >> @@ -150,7 +179,7 @@ exp1: gpio@22 { > >> "UART1_FET_BUF_EN", "WL_LT_EN", > >> "GPIO_HDMI_RSTn", "CSI_GPIO1", > >> "CSI_GPIO2", "PRU_3V3_EN", > >> - "HDMI_INTn", "TEST_GPIO2", > >> + "HDMI_INTn", "PD_I2C_IRQ", > >> "MCASP1_FET_EN", "MCASP1_BUF_BT_EN", > >> "MCASP1_FET_SEL", "UART1_FET_SEL", > >> "TSINT#", "IO_EXP_TEST_LED"; > >> @@ -256,3 +285,16 @@ partition@3fc0000 { > >> }; > >> }; > >> }; > >> + > >> +&usb0 { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + usb-role-switch; > >> + > >> + port@0 { > >> + reg = <0>; > >> + usb0_hs_ep: endpoint { > >> + remote-endpoint = <&usb_con_hs>; > >> + }; > >> + }; > >> +}; > >> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > >> index 80e8b9b9a5f5..e3223088b90c 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > >> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > >> @@ -264,10 +264,6 @@ &usbss1 { > >> ti,vbus-divider; > >> }; > >> > >> -&usb0 { > >> - dr_mode = "peripheral"; > >> -}; > >> - > > > > How about sk-lp ? > > moved it to sk-lp. see above in this patch. > A bit confused. Looking at [1] vs [2], it seems to indicate pd controller at 0x3f as well? Am I misreading the schematics? [1] https://www.ti.com/tool/SK-AM62-LP#design-files [2] https://www.ti.com/tool/SK-AM62#design-files -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel