From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 920B8C6FD18 for ; Tue, 28 Mar 2023 15:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K2HiCEwl08NAOXy9YA3k+D+wZZdCgjd5Apw7qFrl3Dg=; b=ONKDNMBuj860mB 8o3wIbmbuI7gduFfO1r2u3Xvf3xYRD5+fWkjHkXcgzE/UU/HgVSiyQ/+dc2sUv3NI/zuZMZQYnINQ cwTVEuy7njAbiI/xldP17riB3c8kCrrbxVFTDmPWAfqEkWmkWoNybRvOXefxIRr/hyJM3204orBGg N7sSUhGzwmySm0HW5+4v8KYVIoo1gi9Lugok7wi9hf2SF5+P8SN1gPW/9nBGHTX5gCSL4H7tmsZNX /vxYqDGqbbtAMFAXVenwVGTUzRpaE+Rt8nerGRGrj+BLfO5F1lKYm7oNBgqebewgFqPLZPhG1XeC4 vJP6NTaza9WoQZyMcjlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phB8y-00EugI-0c; Tue, 28 Mar 2023 15:21:52 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phB8u-00Euf8-2J for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 15:21:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 944E5CE1DA3; Tue, 28 Mar 2023 15:21:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61CD0C4339C; Tue, 28 Mar 2023 15:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680016902; bh=i3OkFYn+CvmNVhVlFuKMt5831golXkFfwanYc2N5usY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UTRUTtheg3ul7TFIUZ2bUACT6mMO4m2jNNA8dJNsFdEOYw3guRTO9SMsVWYvsAY3h EhoYVun4Z7KOwxgYLpVZ2guqVBHuO3HOmujEehnh8rNAT0npfoh0Sav0Vr5z+tyr/M 39mQciKni4eiIwKhS7OUB9A/BrRmRmGU73J7eYMkWPSDFMwDWNNHzDKaFglqo9rVkH mgl9O65iX1QyJ8ivozahD4YKlnfUmQrz8A7NELtC9nJtteF0T/Qa1oLTI3SebGQhoa q3wGgKqG4koRsPL++lYpA19H7Jzd+4rApL2oihpzZoPXsXTumvaFg6MCI2LWW7mAOr 15AVt+voYRK5w== Date: Tue, 28 Mar 2023 16:21:37 +0100 From: Will Deacon To: Arnd Bergmann Cc: Zaid Al-Bassam , Marc Zyngier , Arnd Bergmann , Russell King , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mach-virt: fix PMUv3 dependendency Message-ID: <20230328152136.GA1844@willie-the-truck> References: <20230328144405.1527555-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230328144405.1527555-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_082149_416473_944F79C8 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Tue, Mar 28, 2023 at 04:43:44PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Selecting a ARM_PMUV3 from a platform option breaks the build > when CONFIG_ARM_PMU is not already set: > > WARNING: unmet direct dependencies detected for ARM_PMUV3 > Depends on [n]: PERF_EVENTS [=y] && HW_PERF_EVENTS [=n] && (ARM [=y] && CPU_V7 [=y] || ARM64) > Selected by [y]: > - ARCH_VIRT [=y] && ARCH_MULTI_V7 [=y] && PERF_EVENTS [=y] > > drivers/perf/arm_pmuv3.c:48:9: error: 'PERF_MAP_ALL_UNSUPPORTED' undeclared here (not in a function) > 48 | PERF_MAP_ALL_UNSUPPORTED, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/perf/arm_pmuv3.c:63:9: error: 'PERF_CACHE_MAP_ALL_UNSUPPORTED' undeclared here (not in a function) > 63 | PERF_CACHE_MAP_ALL_UNSUPPORTED, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/perf/arm_pmuv3.c:65:10: error: implicit declaration of function 'C' [-Werror=implicit-function-declaration] > 65 | [C(L1D)][C(OP_READ)][C(RESULT_ACCESS)] = ARMV8_PMUV3_PERFCTR_L1D_CACHE, > > Fixes: 3b16f6268e66 ("ARM: mach-virt: Select PMUv3 driver by default") > Signed-off-by: Arnd Bergmann > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index e8ccacb3653b..700458c7cace 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -397,7 +397,7 @@ config ARCH_VIRT > select ARM_GIC_V3 > select ARM_GIC_V3_ITS if PCI > select ARM_PSCI > - select ARM_PMUV3 if PERF_EVENTS > + select ARM_PMUV3 if PERF_EVENTS && ARM_PMU > select HAVE_ARM_ARCH_TIMER We're discussing this one over at: https://lore.kernel.org/r/202303281539.zzI4vpw1-lkp@intel.com I'm leaning towards dropping the 'select' altogether. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel