From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF7B9C761AF for ; Wed, 29 Mar 2023 16:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bmRsrJovdCNN5d7WfNWkXh3xNYkV/pYVfwwNi7/TK0o=; b=0fTlziLhWbZtbQm+U3bl802puV sehPyWGe0ADwBgbH1vXjq/weabZePuu8BbVXeCrFPxjED5fw9v5HqTazoVe/zDYOJ0KxrN9BWuXWO v8f3z3wGADDehBMnhCVjpAfxYaktVw2vnHq5OsR3YmK32oMNI0Frqwm6nuCLf3C5n+SBshxWTeLRH 8jSVxsH3ogru8WGOpdL5JUkMJ7sJBcHMyQC/LYC/xvskhP+taAD64gyRLDBxmrAqPacsSjyrp13dv sd3MtnLkZ2hcpBIRDFK7Lz50B1qVfSmqIH9KgMpi0Avk0TmxrpJj5PLOKAyO9rTH8WH+n1G4/7Q0R xkzk/zDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phYKX-0010sZ-1U; Wed, 29 Mar 2023 16:07:21 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phYKU-0010lL-1d for linux-arm-kernel@lists.infradead.org; Wed, 29 Mar 2023 16:07:19 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 06D54581F9B; Wed, 29 Mar 2023 12:06:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 29 Mar 2023 12:06:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1680106016; x=1680113216; bh=th Rw2/tFs/SwCLKlW3NOEoR71LT+Ry2A2LqiLKA1wEU=; b=JVNDbc+MY5oREoD06S +DcekfmC36dI9aqn/twmH9eClRsgxHsK1vrEDVVakWUjoHs3a2SYcOGwtUQns7yH 3y3QbNzVkl5yhmMvxH5qvJpmSsqOuqifzEQYVNnBl/wO5c7wtnBTo4Prvdd+X+d1 +uMiToSbklmYULNWzGSyS5snupaadjApQ4xgMJWM8dLccZadhw/cNViYR3Xg4uql PGCM84fZX+BBzK5USZOcxqojgQkKQaYWr+CcJKlcdz08h3tDxSpxGJ7WUPJuwPgi 7ZZzVRup4keNmbrg7XaSUR4oXX7Vo4yQ1ShpJZqbL54tlXFxcpOCaswr8q4Rsbkz ei0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680106016; x=1680113216; bh=thRw2/tFs/SwC LKlW3NOEoR71LT+Ry2A2LqiLKA1wEU=; b=LnhyOmWlCJTs8izABKUs7dBWaVgGR 3BucKvjdG/ntkSg9I3lUoOINnmOzkKfd8UcpJPsjhs7/nOY2ToiOpP7lYF+KxmgQ UiolKHPGRiK/mW2UCjPnWZrHFuBAf5B4/HdLZTfn+z5JJbYQVOymSZE4SFKAaGwk rFNpPoGe3d08DBccsFO9LnpZ2Gj1X1KwNzItxnYNaDgdOm9WrWT6nMFa+9bySbW5 o0LyYuVYWs90nfXlk5/fmSlG4tlmH6JWGh1Y4sB2DQbtIupaeZX48T8b7AZ/vqao 0QdiydeLd3v7MIVGEuXq2xA+sCilgI5auVNuCqnUNutnHGbWFWN/8XlQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehiedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeejgeeiveevvdfgffeftdevuefhheduveejieefgeejveeuhfetkeelgfev teefffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Mar 2023 12:06:53 -0400 (EDT) Date: Wed, 29 Mar 2023 18:06:52 +0200 From: Maxime Ripard To: Jagan Teki Cc: Dave Stevenson , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sam Ravnborg , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Marek Vasut , linux-amarula Subject: Re: [PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver Message-ID: <20230329160652.7gel5qvckzwihjx4@penduick> References: <20230329131929.1328612-1-jagan@amarulasolutions.com> <20230329131929.1328612-3-jagan@amarulasolutions.com> <20230329145939.7zcex4x2pipivuj4@penduick> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230329_090718_615860_EF174935 X-CRM114-Status: GOOD ( 26.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3554805673129654040==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3554805673129654040== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zrjrrfurl2tflvml" Content-Disposition: inline --zrjrrfurl2tflvml Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 29, 2023 at 09:08:17PM +0530, Jagan Teki wrote: > On Wed, Mar 29, 2023 at 8:29=E2=80=AFPM Maxime Ripard = wrote: > > > > Hi, > > > > The patch prefix should be drm/sun4i: >=20 > I did follow my previous prefix, I will update this. >=20 > > > > On Wed, Mar 29, 2023 at 06:49:29PM +0530, Jagan Teki wrote: > > > Convert the encoder to bridge driver in order to standardize on a > > > single API by supporting all varients of downstream bridge devices. > > > > Which variant, and why do we need to convert to a bridge to support all= of them? >=20 > Downstream bridge variants like DSI panel, DSI bridge and > I2C-Configured DSI bridges. Bridge conversion would be required for > the DSI host to access the more variety and complex downstream bridges > in a standardized bridge chain way which is indeed complex for encoder > driven DSI hosts. >=20 > > > > > The drm_encoder can't be removed as it's exposed to userspace, so it > > > then becomes a dumb encoder, without any operation implemented. > > > > > > Tested on DSI Panel, DSI Bridge, I2C-Configured DSI Bridge. > > > > > > Signed-off-by: Jagan Teki > > > > [...] > > > > > +static const struct component_ops sun6i_dsi_ops; > > > + > > > static int sun6i_dsi_attach(struct mipi_dsi_host *host, > > > struct mipi_dsi_device *device) > > > { > > > struct sun6i_dsi *dsi =3D host_to_sun6i_dsi(host); > > > - struct drm_panel *panel =3D of_drm_find_panel(device->dev.of_no= de); > > > > That one looks unrelated. Why do you need that change? >=20 > This was replaced with drmm_of_dsi_get_bridge for lookup of both panel > and bridge. I think I will separate this into another patch. So, it looks to me that you're doing two (unrelated) things in that patch: - You modify the existing driver to be a bridge - And you support downstream device being bridges. Both are orthogonal, can (and should!) be done separately, and I'm pretty sure you don't actually need to do the former at all. Maxime --zrjrrfurl2tflvml Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZCRiHAAKCRDj7w1vZxhR xd68AQC05r3DsJGaU7H1oonM8OgOgjnGl+gioqXGq3ALav5aSgEAuFfH8EvCnOv7 n0z5dUr5W+RUNtouMyIew97EwKd5ZAk= =u1E2 -----END PGP SIGNATURE----- --zrjrrfurl2tflvml-- --===============3554805673129654040== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3554805673129654040==--