From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 786A6C761A6 for ; Thu, 30 Mar 2023 15:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hA03rY9QJGzrRfQH8o/m2CMmqz1x8Gm9AyjKzu0xWGY=; b=pV/zgunCc41XC8 NiJkIsIxDrhuTP24ipm9DyCNYtS8Fn/eWpr6l1Y0PVm4IB6iv0txe596AgydP4AgoJoPHMsQUhCRP cWiazLkTEU7nHfUlCAWBaxqKQCUxzBmFltOGJOJIw7eKhu4rfyI8zq56+pei7Ay9j1WI9/kvVVZGo 3Z4wgMva/9op889LzP20GPuiQUT/e+a8SclBwntc6zAK9GVt8vdqAnyeD4UX9ljeGdx83iEA866ZK B7RJmuUbepVu1/q54IvZ/xkgadD4JBSFNskztB6Yi097gnCPVHWbYboqAJ1oIrP7BwvmzU8IYje9x KFdTZChhuiytc1gmYctQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phu8T-004FMV-1x; Thu, 30 Mar 2023 15:24:21 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phu8M-004FF3-0m for linux-arm-kernel@lists.infradead.org; Thu, 30 Mar 2023 15:24:19 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32UFO6me085602; Thu, 30 Mar 2023 10:24:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680189846; bh=ySGkM7XhpG2QJR1IyhjEH+r6F5YDlBy7XmSF2pLNiLY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=OfDtqJA0S346CYC/aP76oa+JLNMZ/Z746NEj7xa39na1vwfe5U6VfcTZglAJGjsVZ JLLKPCRPmPEKosoyr91ZAhDw/BJ3JnjvaK9NngS4aUcyZX/5TeXQJf1eTfE0gw5QZy mjvfI64T6Mq/mtrbnwrEpotddWAWWXX6Q51ymJhY= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32UFO6EW031585 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Mar 2023 10:24:06 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 30 Mar 2023 10:24:06 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 30 Mar 2023 10:24:06 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32UFO6OH011690; Thu, 30 Mar 2023 10:24:06 -0500 Date: Thu, 30 Mar 2023 10:24:06 -0500 From: Nishanth Menon To: Bhavya Kapoor CC: Apurva Nandan , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , , , Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support Message-ID: <20230330152406.fmpri7nnzybf7uqh@jubilance> References: <20230327083100.12587-1-a-nandan@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230330_082414_421427_837C0C24 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11:50-20230330, Bhavya Kapoor wrote: > > On 27/03/23 14:01, Apurva Nandan wrote: > > Add support for eMMC card connected to main sdhci0 instance. > > > > Signed-off-by: Apurva Nandan > > Reviewed-by: Bhavya Kapoor > > > --- > > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > > index 7480f37e89e8..1622a01a4667 100644 > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > > @@ -21,6 +21,7 @@ chosen { > > > > aliases { > > serial2 = &main_uart8; > > + mmc0 = &main_sdhci0; > > mmc1 = &main_sdhci1; > > i2c0 = &main_i2c0; > > }; > > @@ -225,6 +226,14 @@ exp2: gpio@22 { > > }; > > }; > > > > +&main_sdhci0 { > > + /* eMMC */ > > + status = "okay"; > > + non-removable; > > + ti,driver-strength-ohm = <50>; > > + disable-wp; > > +}; > > + > > &main_sdhci1 { > > /* SD card */ > > status = "okay"; > > -- > > 2.34.1 > Looks correct to me. Don't you need pinmux? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel