From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B40C6FD1D for ; Thu, 30 Mar 2023 18:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q2M0Fi1a1wPMJ57VR6EhPdtALyB9ybkCOUgX2YbJqmY=; b=E/ZYt9e7bEbxGn ouaI9e2uQYe67MNIZpLOkHmMmEV6Tb3LrxlYWYdwdS7oUN54erC590Dnp1ksLn+wZMnhR4Uc9Aw5C v6ameUCl1+BlzPSql62AaM4on57NEYrblVITgU6C4sq3Od6yWzbQV2EAfVfky4+VX/egQW2Covxbs KYS3+V3SGkCoT276Dxec7CsGJO0+LqFD6/0T0SqkvFu0eiMiq7IcngKNkxoMqvCYmxzWIUjkteNJn hQ1gv5Y87WzgneMu1SoyGQXFiYjlTx0dkI7gxDgkazQYpcwBOtuCm9eX3BthV4XXJJJtWUkzKBHEv 4yYDoqtV50OO2bMCEr1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phwzy-004oX6-2O; Thu, 30 Mar 2023 18:27:46 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phwzv-004oWN-1w for linux-arm-kernel@lists.infradead.org; Thu, 30 Mar 2023 18:27:45 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32UIRZvH051124; Thu, 30 Mar 2023 13:27:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680200855; bh=iwVvxxRviT6unOdLjY9LnCnWTXA8oTUOvdHCBztIn4Y=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=o8RFiSyoupCLX3l+sReRbvjwU+3QYgCbUgmIU/JM29f1oJhfKsbUfBE622Hp8BqoL nue6EOUT6JoOBGQDYh0G93KHQfUqlICdsSL/KHxqpJ63RElfbI3e8o0IIjAXNfo2GK nLYPcsPA8bt2xykk3ld5e1YlE9mN9sFGhjBXyuZA= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32UIRZPD007347 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Mar 2023 13:27:35 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 30 Mar 2023 13:27:35 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 30 Mar 2023 13:27:35 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32UIRZPC023276; Thu, 30 Mar 2023 13:27:35 -0500 Date: Thu, 30 Mar 2023 13:27:35 -0500 From: Nishanth Menon To: Bhavya Kapoor CC: Apurva Nandan , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , , , , "Kumar, Udit" Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support Message-ID: <20230330182735.2lkuplsqcjku5enh@unnoticed> References: <20230327083100.12587-1-a-nandan@ti.com> <20230330152406.fmpri7nnzybf7uqh@jubilance> <8f4e8265-da64-1e53-e1ed-b925e0326cad@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8f4e8265-da64-1e53-e1ed-b925e0326cad@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230330_112743_739704_AD0C77F2 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23:14-20230330, Bhavya Kapoor wrote: > = > On 30/03/23 20:54, Nishanth Menon wrote: > > On 11:50-20230330, Bhavya Kapoor wrote: > >> On 27/03/23 14:01, Apurva Nandan wrote: > >>> Add support for eMMC card connected to main sdhci0 instance. > >>> > >>> Signed-off-by: Apurva Nandan > >> Reviewed-by: Bhavya Kapoor > >> > >>> --- > >>> arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++ > >>> 1 file changed, 9 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/bo= ot/dts/ti/k3-j784s4-evm.dts > >>> index 7480f37e89e8..1622a01a4667 100644 > >>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > >>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > >>> @@ -21,6 +21,7 @@ chosen { > >>> > >>> aliases { > >>> serial2 =3D &main_uart8; > >>> + mmc0 =3D &main_sdhci0; > >>> mmc1 =3D &main_sdhci1; > >>> i2c0 =3D &main_i2c0; > >>> }; > >>> @@ -225,6 +226,14 @@ exp2: gpio@22 { > >>> }; > >>> }; > >>> > >>> +&main_sdhci0 { > >>> + /* eMMC */ > >>> + status =3D "okay"; > >>> + non-removable; > >>> + ti,driver-strength-ohm =3D <50>; > >>> + disable-wp; > >>> +}; > >>> + > >>> &main_sdhci1 { > >>> /* SD card */ > >>> status =3D "okay"; > >>> -- > >>> 2.34.1 > >> Looks correct to me. > > > > Don't you need pinmux? > > > Hi Nishanth, pinmux is not needed since there is no mux options for emmc = pins (mmc0) in datasheet. > = > =A0-> Kindly refer to datasheet for same : https://www.ti.com/lit/ds/syml= ink/tda4vh-q1.pdf?ts=3D1680197698102&ref_url=3Dhttps%253A%252F%252Fwww.ti.c= om%252Fproduct%252FTDA4VH-Q1%253FkeyMatch%253DTDA4VH%2BDATASHEET Aah, yes - thanks for clarifying. -- = Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5= 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel