From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B71A2C76196 for ; Sat, 1 Apr 2023 04:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IPpTxShT4E5b587Cy+1hxlC35d/TGEIUKT/nJPiXK+8=; b=YkqdPJgY227X3f w3mDw77Z7wrlRrGU26YBNz/1T9KeYyH+wG0z9q1C1nCC4vXxkF0vEvN6lZJ6Vqj4D3ngq1rwvnOIk Lfvl1RY6zcGZFiWulp/WIaC9WzuWVVv3cslyXeyH6rzTcLttz9P/U+Yt1i91vMWDwoRNB2lqw5I3o kHubBLpZMNJre7Qy17QHNkgJOPNrt8+6BHfuafknp2rm7R0OtgzWXtf/lfcSP92ekaLzXglsy0XgA UGPQH7Uykiw8MKPCkRcpS8dE676UnWJycMCL4ueDHn2x4yP4nEhy/FFIlbQULHaC2xSpqFPQFRnTb lUhPD16/VUo+b7jSOKeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1piTJn-009jyQ-1S; Sat, 01 Apr 2023 04:58:23 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1piTJl-009jxu-09 for linux-arm-kernel@lists.infradead.org; Sat, 01 Apr 2023 04:58:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84D5D60915; Sat, 1 Apr 2023 04:58:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEA93C433D2; Sat, 1 Apr 2023 04:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680325098; bh=M7NRHgeY9YLXr0tbXa8gzPSJWRgkntHKUQrTaY89fR8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GkSp7WfnFZqe6RFdyi1EpCwdsQoGTaK5STvuHcwCzA7s3Q1fL7Jkc85TPoHcM5tp6 wzyNTG3cey+KwCmZx5k0CxDvqVLi0ZSBtfIyM+m4lBGbzqxEf0vssAPm04JznywGXs 8X4RNSdU8+ppCDOPLh491CWy3o5XSQfAhw0sV2USjyN95ruHOMqbNSZbzif1i0fiU9 guhn9O3tlmfOdCdTs7OSmNsbYUdX1n1D41ce5nxsTHKarUptpT6DBJwWT9NcK/5f62 fab7lcVQVK0tiKzGaImFZX8R7SMxQR+YxdhwOfUq5wiB7NZFJO/wfx5YDwrkwNaQE6 WjuatBkdD2nZw== Date: Fri, 31 Mar 2023 21:58:16 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Shawn Guo , Sascha Hauer , Maxime Coquelin , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Wong Vee Khee , Kurt Kanzenbach , Revanth Kumar Uppala , Andrey Konovalov , Tan Tee Min , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, imx@lists.linux.dev Subject: Re: [PATCH v4 1/2] net: stmmac: add support for platform specific reset Message-ID: <20230331215816.32d5aa35@kernel.org> In-Reply-To: <20230331212250.103017-1-shenwei.wang@nxp.com> References: <20230331212250.103017-1-shenwei.wang@nxp.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230331_215821_123519_23220A74 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 31 Mar 2023 16:22:49 -0500 Shenwei Wang wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h b/drivers/net/ethernet/stmicro/stmmac/hwif.h > index 16a7421715cb..47a68f506c10 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/hwif.h > +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h > @@ -214,8 +214,6 @@ struct stmmac_dma_ops { > int (*enable_tbs)(void __iomem *ioaddr, bool en, u32 chan); > }; > > -#define stmmac_reset(__priv, __args...) \ > - stmmac_do_callback(__priv, dma, reset, __args) > #define stmmac_dma_init(__priv, __args...) \ > stmmac_do_void_callback(__priv, dma, init, __args) > #define stmmac_init_chan(__priv, __args...) \ > @@ -640,6 +638,7 @@ extern const struct stmmac_mmc_ops dwxgmac_mmc_ops; > #define GMAC_VERSION 0x00000020 /* GMAC CORE Version */ > #define GMAC4_VERSION 0x00000110 /* GMAC4+ CORE Version */ > > +int stmmac_reset(struct stmmac_priv *priv, void *ioaddr); sparse reports missing annotation, I think it's this line. It should have a __iomem tag. Try building with C=1 Also please take a look at: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html > int stmmac_hwif_init(struct stmmac_priv *priv); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel