From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A233C76188 for ; Mon, 3 Apr 2023 18:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UpwyNcRpOEZAq23s9ChGpie+BjJ2cMTrzG4Kx3NJcs0=; b=aVi4dd6355Klrq fN52zTeo/vLd6eoTCj7Sir+/68yBdiW0Q2+oYP9xZBPnVBqKjW+dnHymeU0lue4DhM5sJR03L9zFe qWKXZlvjbsUPqdTDTtLxMstKNGHe5pYkNKv4TdK/R1oxLfM6QbA5jyNFZk0o/Kn/6gnfJbCLSrtt5 zVRP9xhsuZAWDAGKe8+kjXebX4D5PsHZd7P6Rcrgssr7HgQ+wtU58+svSSF1XPo2wiaDpFXJFicnk flcBahIuFe9o/aNlMiTVJbSlpn4pZtfDu0L4tnqJe+ULKYD4UIXW/5n4SvdkypWqM6sut0XmFqG/2 AYwUJ3cqpF0mZ5CNSLsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjOl1-00GAvY-0f; Mon, 03 Apr 2023 18:18:19 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjOky-00GAuY-0k for linux-arm-kernel@lists.infradead.org; Mon, 03 Apr 2023 18:18:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5FBE62587; Mon, 3 Apr 2023 18:18:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9D63C433EF; Mon, 3 Apr 2023 18:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680545894; bh=aBv3MIAl7MHy2gxFkA3aRokEYOsWf9pvu+LOh3HggEM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QfMW9qU5BVF4Lvj70eLSPFbuo/AIl6dggkk0cscwgbF765jelDaa52rRFaZGJyUVD l2w6rkiunDdVCe0yG5t9gs3jNYORHP6njKwIBEoFW2er7WI6nX4ok6NIGt/DqPLAlc GksMbiu/kTG37+RJxXbBK4n2c0N2PZZ3S7uV4AaGoxUP3ut++4/aBV2TKUWtvSgOw0 rymKjGl4NQR36luXbxpKX83/ETkJ9mVbgKWmfSC9nNXXH+7has5hoPvvLSXxmGahIy FzVqlIIlE7UG4rVVmodaJWEKpsm8nBj+kFddrXcZCPq5xCbqfAV5/PdT0qtKQNbeL6 8aznCOoltjvXg== Date: Mon, 3 Apr 2023 11:18:12 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , poros , mschmidt , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "Olech, Milena" , "Michalik, Michal" Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: <20230403111812.163b7d1d@kernel.org> In-Reply-To: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> <2b749045-021e-d6c8-b265-972cfa892802@linux.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230403_111816_303491_3047BDEF X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 15 Mar 2023 10:22:33 +0100 Jiri Pirko wrote: > So basically you say, you can have 2 approaches in app: > 1) > id = dpll_device_get_id("ice/c92d02a7129f4747/1") > dpll_device_set(id, something); > dpll_device_set(id, something); > dpll_device_set(id, something); > 2): > dpll_device_set("ice/c92d02a7129f4747/1, something); > dpll_device_set("ice/c92d02a7129f4747/1, something); > dpll_device_set("ice/c92d02a7129f4747/1, something); > > What is exactly benefit of the first one? Why to have 2 handles? Devlink > is a nice example of 2) approach, no problem there. IMHO for devlink the neatness of using the name came from the fact that the device name was meaningful. With the advent of auxbus that's no longer the case. In fact it seems more than likely that changing the name to auxbus will break FW update scripts. Maybe nobody has complained yet only because prod adoption of these APIs is generally lacking :( I agree that supporting both name and ID is pointless, user space can translate between the two trivially all by itself. But I'd lean towards deleting the name support not the ID support :( _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel