From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCAFDC6FD1D for ; Tue, 4 Apr 2023 16:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SzEPgCIRs4kLOjsybuqs+pjkhX42540Aq1PfdMMkcLE=; b=MFy+xpbjP9mX7X sGKUiWBxLp7Os9gMYrGs4owHupgSeURLk0SzKZfXMMoCYM3t9wK+9IYfq5JKIN0II2AoK8pg6MKyo BEhS6EQZ9IZCi69TS1WMEflh8sqY1xCMI/gjaZyCI7kpzl9bfWy9gfGKhj8wkT2TwtB4oN30S6qwR HXF01jxtAes1QwK1xNSGZduc/gj/OSwu+Atnsg8wtVoA4bITD7jrsx9BDHfMkL6enJClB/KOohY4L rN7H0/xn4rX0Ye7w5chc+gswNHnBcxF5fmYfhhKGuIlNNhLFzA5e3mh+UlQ5CwQYjnBh7KhGSa0mN N7j6BZVUuW4yJiTQzjOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjj5a-0028M6-13; Tue, 04 Apr 2023 16:00:54 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjj5W-0028JK-15 for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 16:00:52 +0000 Received: by mail-wr1-x433.google.com with SMTP id d17so33332757wrb.11 for ; Tue, 04 Apr 2023 09:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680624046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8K2SCp3N7WmXl5Hlded+U+tmuHCBjMjb7rjTKVn+ghk=; b=owhdeMQ665T618BPk+i/t5+b22DfkXcK5JP+rpAZdWk3KRCpsDtTpmaa4HT2RDnqld PYlRYjyf9wkXrjdfIHzBk2Act08sGj8PBm7Wg3vHTx63pYbuU/xX7cD93j3TEYQj7ACc PZ3+p6b+w5kELe6CyS0//j7RztJLt1C++sv2wDPybtRZx3tZSypUE0ELXrb9KqVq+jC6 2MNYVUifpj6TYfpnAK7lQuBAIIKUvur44LiyBtIYM3Tw7+1rTkMWb1AEZNgg/McpK/MV Sq91mzgjuwiCSvVO3pzdmrNE8j5CQ8zT4lLXpt5FP8nSeYw7i1lgExkxbw75QZ3ggIAP eN1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680624046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8K2SCp3N7WmXl5Hlded+U+tmuHCBjMjb7rjTKVn+ghk=; b=52rvRaqpvdvgC4DJeh4zngaRtSMVvhbhkFudh/qGt1n2we3vMXGvWTmIIORWPQNMVR GRe8PDT9F012cdglXay+ZGLOcUgzTY+xif8hy0AeedNAM637A3eFIO3Ihu8K/Y72T/tA aOUlqNPBLOaaRgrQVbZIy61S1GpcGz4rgVPtr4DwdvP4NmchXdG4xm25xHLYJ8GBqorg jdXJoU3jKj7Oq3vjMBDQey1E7f1UHrK5tSiVp/XRApzCgvncLAHgrvvB9MgQ0cBnr8k0 82AavjCKNdUfZZ4Q/oPYhY4OiBHwbcmKOeUiyJIaNE6xdY7TvTKO8WZX7bUgcaU3ldo4 iSfg== X-Gm-Message-State: AAQBX9d95B+XIdkfOv+aUJo/wbId8D9zQM/IrUZuBbGyNrddVilOMY/U SybqbUp3323UISdLPMu1L4qbmA== X-Google-Smtp-Source: AKy350Yhk5Yty0BVntaEj2IuKQU6pcpCE8rOGmBm4/2Og/8fIk8LVzOTYonEUbAff04/787UgUetIQ== X-Received: by 2002:a5d:4b91:0:b0:2e5:31a3:38d4 with SMTP id b17-20020a5d4b91000000b002e531a338d4mr1916594wrt.55.1680624046051; Tue, 04 Apr 2023 09:00:46 -0700 (PDT) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id n9-20020a5d4009000000b002d431f61b18sm12480440wrp.103.2023.04.04.09.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 09:00:45 -0700 (PDT) Date: Tue, 4 Apr 2023 17:00:46 +0100 From: Jean-Philippe Brucker To: Mostafa Saleh Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, joro@8bytes.org, robin.murphy@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, dbrazdil@google.com, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev Subject: Re: [RFC PATCH 20/45] KVM: arm64: iommu: Add map() and unmap() operations Message-ID: <20230404160046.GA305012@myrica> References: <20230201125328.2186498-1-jean-philippe@linaro.org> <20230201125328.2186498-21-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_090050_395322_DFD236B1 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mostafa, On Thu, Mar 30, 2023 at 06:14:04PM +0000, Mostafa Saleh wrote: > > +err_unmap: > > + __kvm_iommu_unmap_pages(&iopt, iova_orig, pgsize, pgcount_orig - pgcount); > On error here, this unmaps (and unshares) only pages that has been > mapped. > But all pages where shared with IOMMU before (via > __pkvm_host_share_dma) and this corrupts the other pages state as > they are marked as shared while they are not. Right, I'll fix this > I see we can add a "bool unshare" arg to __kvm_iommu_unmap_pages which > will be called with false on error from here after calling > __pkvm_host_unshare_dma for the whole range. I think it's simpler to call iopt_unmap_pages() directly here, followed by __pkvm_host_unshare_dma(). It even saves us a few lines Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel