From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D961C6FD1D for ; Tue, 4 Apr 2023 14:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UznEBOvngCqKQKuYwaK+qkh8MmeJzIqQWpCnYHoTRVw=; b=X4BBif54NAXjF8 ksG1bXzNOalyratcsTSrH0QkTljSPWYzukUtR2C0sHDxBzKHCKf+na5OixIRQ+u/ridHCDKolCDxV vXGTTGBi8GurEzBuBRfHqogf+jWIJoBNI3p2VIbT+Z4se5znzUjbSQ+wOe24ZJVAODMFCJ2VUKJpj 0rxUsu8E0JveDKgAkqKmRZvEwboI+lywuS20ihSceqqqkytJ7pZjnf7sz1wksKmv/XmnP7veEVMvY Rr1D+VDF/sDQMgqE/iMiSWqIpEU7skCecRZFa6aRj6926Y9TqMugdVEzmNGccqrZFAbYEgXRLjGRn 8Nw4gS65N5G1blNXjXcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjhq5-001qRl-2Q; Tue, 04 Apr 2023 14:40:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjhq1-001qQe-33 for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 14:40:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CE73634FE; Tue, 4 Apr 2023 14:40:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EBB4C433EF; Tue, 4 Apr 2023 14:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680619244; bh=kJs2FcJMOyFP6Jf9o+j82QnGRlSZKmBzBCteDbxYsXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YuEvT3Dc+BynuOi7RdV3awmvLg9JsgbBy8E7i9AWMgfcUA5Q69kszLaCOceYC+28H 6af20+rJGuKZ9+JU076ksTIH8Z3r8vN1AdJLPpeZxhH1XTHfTLKxrZ+eaPttJP45Y1 NeZNVeqBlCnssVHKmlHDm2xXXuPYwA7s9rdCGuiY= Date: Tue, 4 Apr 2023 16:40:42 +0200 From: Greg KH To: Jonathan Cameron Cc: Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, Dan Williams , Shaokun Zhang , Yicong Yang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, Suzuki K Poulose , Liang Kan Subject: Re: [PATCH 00/32] Add parents to struct pmu -> dev Message-ID: <2023040423-hungry-cadet-1fc1@gregkh> References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_074046_024250_F6F1D7DB X-CRM114-Status: GOOD ( 25.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 04, 2023 at 02:41:53PM +0100, Jonathan Cameron wrote: > These are the low hanging fruit following GregKH's feedback that > all the devices registered via perf_pmu_register() should have parents. > > Note that this causes potential ABI breakage. > > It may fall in the category of it isn't breakage if no one notices > but I can't be certain of that. Whilst it is arguable that > no one should be been accessing PMUs except via the event_source > bus, there was documentation suggesting /sys/devices/ for particular > PMUs (because it was a shorter path?) > > The first patch is pulled out of the series: > https://lore.kernel.org/linux-cxl/20230327170247.6968-1-Jonathan.Cameron@huawei.com/ > [PATCH v3 0/5] CXL 3.0 Performance Monitoring Unit support > > In that particular case it is very useful to be able to figure out which > CXL device the PMU device is associated with and looking at it's parents > in the device model as shown with ls -lh /sys/bus/event_sources/devices/ > is a very easy way to do this (once it is correctly parented). > > Addressing all the other instances of struct pmu not covered by this series > is likely to be a more complex discussion but unlikely to have an affect > on what is proposed here. > > Documentation updates deliberately 'fixed' in separate patches before > changing the path to highlight that using /sys/bus/event_source/devices > path is unchanged by this series and that is presumed to be the > most common way these files are accessed. For the whole series, looks good: Reviewed-by: Greg Kroah-Hartman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel