From: Peter Robinson <pbrobinson@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>, Ondrej Jirman <megi@xff.cz>,
Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
Martijn Braam <martijn@brixit.nl>,
Caleb Connolly <kc@postmarketos.org>,
Jarrah Gosbell <kernel@undef.tools>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: "Kamil Trzciński" <ayufan@ayufan.eu>,
"Peter Robinson" <pbrobinson@gmail.com>
Subject: [PATCH] arm64: dts: rk3399-pinephone-pro: Add support for volume keys
Date: Wed, 5 Apr 2023 13:38:13 +0100 [thread overview]
Message-ID: <20230405123813.2272919-1-pbrobinson@gmail.com> (raw)
From: Ondrej Jirman <megi@xff.cz>
These are implemented via regular ADC, so regular polling is needed,
for these keys to work.
Signed-off-by: Martijn Braam <martijn@brixit.nl>
Co-developed-by: Kamil Trzciński <ayufan@ayufan.eu>
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
.../dts/rockchip/rk3399-pinephone-pro.dts | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index a0795a2b1cb1..ecd48040eb0c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -10,6 +10,7 @@
*/
/dts-v1/;
+#include <dt-bindings/input/gpio-keys.h>
#include <dt-bindings/input/linux-event-codes.h>
#include "rk3399.dtsi"
#include "rk3399-opp.dtsi"
@@ -29,6 +30,26 @@ chosen {
stdout-path = "serial2:115200n8";
};
+ adc-keys {
+ compatible = "adc-keys";
+ io-channels = <&saradc 1>;
+ io-channel-names = "buttons";
+ keyup-threshold-microvolt = <1600000>;
+ poll-interval = <100>;
+
+ button-up {
+ label = "Volume Up";
+ linux,code = <KEY_VOLUMEUP>;
+ press-threshold-microvolt = <100000>;
+ };
+
+ button-down {
+ label = "Volume Down";
+ linux,code = <KEY_VOLUMEDOWN>;
+ press-threshold-microvolt = <300000>;
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";
pinctrl-names = "default";
@@ -429,6 +450,11 @@ &sdio0 {
status = "okay";
};
+&saradc {
+ vref-supply = <&vcca1v8_s3>;
+ status = "okay";
+};
+
&sdmmc {
bus-width = <4>;
cap-sd-highspeed;
--
2.40.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-04-05 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 12:38 Peter Robinson [this message]
2023-04-05 13:53 ` [PATCH] arm64: dts: rk3399-pinephone-pro: Add support for volume keys Ondřej Jirman
2023-04-17 8:34 ` Heiko Stübner
2023-04-17 12:37 ` Ondřej Jirman
2023-04-17 14:36 ` Heiko Stübner
2023-04-17 14:48 ` Ondřej Jirman
2023-04-17 22:43 ` Heiko Stuebner
2023-04-18 7:42 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405123813.2272919-1-pbrobinson@gmail.com \
--to=pbrobinson@gmail.com \
--cc=ayufan@ayufan.eu \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kc@postmarketos.org \
--cc=kernel@undef.tools \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=robh+dt@kernel.org \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).