From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14FC2C7618D for ; Thu, 6 Apr 2023 14:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k1f0igF9aIDy9bRtLkKnM4hplA+TRUvw4ecn+E/LvGA=; b=SHdA0uI9hk3iPA 6jHN4RNMazxLpn4O4c8NDt+B6b09gnZCzqqXfP89tdv+5TkVCjj4x90d/Y8Qyelo5D2Ur0iYFyDgc HQJU1kPDoKKnLqlYDvk4r1s8PcmRxFXq5dXxw1E9Apw9dKa6CrzRhwH6/ql4eUAq5a5aCYqkIfMyz vkUnxJc0jNWe/K5bS9+Z56n7Gi0AQjTeIuC0/ofGknPRRX+/3iPGaKLQNy2wYXMEvYw979Wjp7UbT lRyi6Ad48jJbhY92JXcBmy7H13A/gGnJ2vULv3uVQrkQ03GyopWdpYBolQ1untEzS1/ta93icl8nW +St6n7+zBazwWeaEXoHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkQJn-007XBg-0F; Thu, 06 Apr 2023 14:10:27 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkQJk-007XAu-0f for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2023 14:10:25 +0000 Received: by mail-oi1-f175.google.com with SMTP id l18so29116909oic.13 for ; Thu, 06 Apr 2023 07:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680790219; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nc5XJTaOIWq/+ghJJzs83WOcsawa6agTiIS3abEUxHk=; b=F6YUfHXShI9acZPIpzarTE2UuCHCCfLnrPj9o3DMGTBA0iTk4g88SG9knY3QdC0QYx 4QVLfAYk4MbeGEnfDVhcowz+h2drkVdP7o3WIkCbWgR1BDm0ndktyVhRjX4qKUVusDvY qpXgMDS8Tvaun8ixG7J//34wAG0UO0vLIxWJaFhxg7M9YCfTUL7bvrH772E5E5ND6Ukr BRW1V+W8ra0aAuR/UsIJzwRed2NgJNrwXr/pGdzgJsStpPSpOSiK10LDGHtM2boBZWnA UnB61W4b1dcawTaV1PwcT+VaDjIVbYQOFebYkGuDDht3o2ZJzLDITyt18gBR6ZIgpHGO xX3Q== X-Gm-Message-State: AAQBX9eSTewB/pH33I6/XcFhkrBMPLB+KIFAgJZ9QzMNODzu3IWhrKwT l3IWN8A96jo84Sm9v/4SnQ== X-Google-Smtp-Source: AKy350bprKKRW6e63wfLCr4O11TNLUQS8A8vFXvQ7rnM+SgcwkuVgGwzG9QgCq5uzZdD14u6qXu/Sw== X-Received: by 2002:a54:4585:0:b0:387:926e:35d3 with SMTP id z5-20020a544585000000b00387926e35d3mr3309739oib.20.1680790219545; Thu, 06 Apr 2023 07:10:19 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y9-20020a4a9809000000b005251f71250dsm566500ooi.37.2023.04.06.07.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 07:10:19 -0700 (PDT) Received: (nullmailer pid 2976308 invoked by uid 1000); Thu, 06 Apr 2023 14:10:18 -0000 Date: Thu, 6 Apr 2023 09:10:18 -0500 From: Rob Herring To: Christian Marangi Cc: Pavel Machek , Lee Jones , Krzysztof Kozlowski , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [net-next PATCH v6 12/16] dt-bindings: net: dsa: qca8k: add LEDs definition example Message-ID: <20230406141018.GA2956156-robh@kernel.org> References: <20230327141031.11904-1-ansuelsmth@gmail.com> <20230327141031.11904-13-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230327141031.11904-13-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_071024_245870_4002B4F3 X-CRM114-Status: GOOD ( 19.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 27, 2023 at 04:10:27PM +0200, Christian Marangi wrote: > Add LEDs definition example for qca8k Switch Family to describe how they > should be defined for a correct usage. > > Signed-off-by: Christian Marangi > --- > .../devicetree/bindings/net/dsa/qca8k.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > index 389892592aac..ad354864187a 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > @@ -18,6 +18,8 @@ description: > PHY it is connected to. In this config, an internal mdio-bus is registered and > the MDIO master is used for communication. Mixed external and internal > mdio-bus configurations are not supported by the hardware. > + Each phy has at most 3 LEDs connected and can be declared > + using the standard LEDs structure. > > properties: > compatible: > @@ -117,6 +119,7 @@ unevaluatedProperties: false > examples: > - | > #include > + #include > > mdio { > #address-cells = <1>; > @@ -226,6 +229,27 @@ examples: > label = "lan1"; > phy-mode = "internal"; > phy-handle = <&internal_phy_port1>; > + > + leds { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + color = ; > + function = LED_FUNCTION_LAN; > + function-enumerator = <1>; > + default-state = "keep"; > + }; > + > + led@1 { > + reg = <1>; > + color = ; > + function = LED_FUNCTION_LAN; > + function-enumerator = <1>; Isn't function-enumerator supposed to be unique within a given 'function'? > + default-state = "keep"; > + }; > + }; > }; > > port@2 { > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel