From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6600FC76196 for ; Thu, 6 Apr 2023 19:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VNJdfxLnGRXv8Z/VnZFgD6BgTKtGZ2M8IRR+LojjVtE=; b=MCPSqNEOUMyhaq Lwx+tp/1s89oxMsLL9mcLPpNjKF8gQK3cUb5/md2dYxs5cRQ1EImod0Q4s20YYY7enXZEUZp9wnVo E1UFxO1ciKjWoNKizuW0OYz9Nv61Dx9bbd9qSkhLq1GrcwUPN7bjwg41ri/4nMso5SiOKqcq/qoXt yWndFzanSC4sVe12CFT5iPuOZDm/NYoSHid1FV3mDxLMhu2mHjJOXUgWvxOocDcMC6fuut4FrTLo8 Qx52SQUwK3CqY+lY5OBGHRPPoKOLDlBpX6T83+gRCrlNlndEJjHvlfdwR2L0SFxbshiu8ORSCR+2O 2VlwGTmNxUOP1XBjRsZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkVcF-008Qwm-22; Thu, 06 Apr 2023 19:49:51 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkVcE-008Qwb-1Z for linux-arm-kernel@bombadil.infradead.org; Thu, 06 Apr 2023 19:49:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DmGtZh90fpEw0TretC9nRQhMQvDnjMB5G00Z5+VRCJQ=; b=L08PtDFWYx1ukCT2pPv1pyufFB S/61aVSjNkOOM63Ny2OG1fCAj6zQtUgcmDOgAM7d/jq+jgX65UTy81ClnAelmLd3S4kGYc9kzqv/w xkfUcb9SJhyrS0FBk7obbDWej4fKjzqX6WD/OvBKrhMpoIqb8Cx6yaS+3MhLLswoPbfukR+FyKKXs jn+wrwG897iS2qDRIfcoB9rKEFxKxSH/lhbpeqGJ3TElnk0N6SbjGnywb/yqyfslxVOnQjzWZpZvD 2GRC0D3Td2KCUPT8fYFu3xAbrYgwNBNU8rKxZCLpPm3NgBvL0QAk0N0x4zEdCWgLaQ+WGbXH8xXtk EZYiUzrQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pkVc7-00073v-2j; Thu, 06 Apr 2023 19:49:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1CA09300202; Thu, 6 Apr 2023 21:49:39 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id EC4D32625225B; Thu, 6 Apr 2023 21:49:38 +0200 (CEST) Date: Thu, 6 Apr 2023 21:49:38 +0200 From: Peter Zijlstra To: Jonathan Cameron Cc: Yicong Yang , Mark Rutland , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, yangyicong@hisilicon.com, linuxarm@huawei.com, Dan Williams , Shaokun Zhang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, Suzuki K Poulose , Liang Kan Subject: Re: [PATCH 01/32] perf: Allow a PMU to have a parent Message-ID: <20230406194938.GB405948@hirez.programming.kicks-ass.net> References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> <20230404134225.13408-2-Jonathan.Cameron@huawei.com> <61f8e489-ae76-38d6-2da0-43cf3c17853d@huawei.com> <20230406111607.00007be5@Huawei.com> <20230406124040.GD392176@hirez.programming.kicks-ass.net> <20230406174445.0000235c@Huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230406174445.0000235c@Huawei.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 06, 2023 at 05:44:45PM +0100, Jonathan Cameron wrote: > On Thu, 6 Apr 2023 14:40:40 +0200 > Peter Zijlstra wrote: > > > On Thu, Apr 06, 2023 at 11:16:07AM +0100, Jonathan Cameron wrote: > > > > > In the long run I agree it would be good. Short term there are more instances of > > > struct pmu that don't have parents than those that do (even after this series). > > > We need to figure out what to do about those before adding checks on it being > > > set. > > > > Right, I don't think you've touched *any* of the x86 PMUs for example, > > and getting everybody that boots an x86 kernel a warning isn't going to > > go over well :-) > > > > It was tempting :) "Warning: Parentless PMU: try a different architecture." Haha! > I'd love some inputs on what the x86 PMU devices parents should be? > CPU counters in general tend to just spin out of deep in the architecture code. For the 'simple' ones I suppose we can use the CPU device. > My overall favorite is an l2 cache related PMU that is spun up in > arch/arm/kernel/irq.c init_IRQ() Yeah, we're going to have a ton of them as well. Some of them are PCI devices and have a clear parent, others, not so much :/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel