From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AB59C77B61 for ; Tue, 11 Apr 2023 00:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z/zgOvpZ0Hy+MjhAnJ8Uh2FUmeCCoG5Ov+ZKAFG302w=; b=pk7nQtHhRlVxBt IGLIbnCjDsUY4ZEi6Hb0rDFJ/14UTXGFTkU+W1XMTtlvRlVX1fTe/wuTGkSTM04MdLhNrliOMwpAx tP16joT/srn2wsmIWywaerjQdMk5lp6R0cdUrUorjQ7XT/iBLzZ+FyFRIBAhilL2pO6BMEz/XY+G5 AkmxCv9btU8Bc1gqNIav8wLo9eQlwIe+cnV6PdVYAibtRKsVfyrJwCPcgp0d77da0d9TaJ3enYl05 rW60x3lKXbtCf2aG6AKmKKrfiu15D57Tr/cGwuwsFb2brE+S3W9uo6EE80tawoFg6E6t8jI9BzZtm lDBBvWw5EOfQOYrLo/zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pm1w3-00G9ff-08; Tue, 11 Apr 2023 00:32:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pm1vz-00G9fI-1R for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 00:32:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C206262043; Tue, 11 Apr 2023 00:32:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2F5AC433EF; Tue, 11 Apr 2023 00:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681173149; bh=IPQiRaKv5N4+opLgH2RmWIdytX47K28TWJ6fB7F/4ms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mDi/A2//d0R/Hvzon1hhED+jHJkvRVjIcq+GQTe+sjEF9gvI+4ZE9mPM4+M6hmLQ6 QxfVMnujtGa1rq/6epuadF4HtpZgZKwtxmeekxccb4VS6pVXcDocWEDevHyyUup+ZZ 88mF/mXduHMi8DLt1Oogc31S9dWEH/0z6hfd6pcuD7m8n63Mky9AXMyXRA5SckTLSk 3J1IdqmaLJdwRbrYIqXuRJ8oTvrXcBDNjkufZqp1E7tU1oWlG8tRKtUvkzNb7wv+JK ZJ8yB4Uz5ohK/vnossIlah9hGKDRf9rj0NgT7D6F7ERKCY6/YFhsAZ7Ojzdwb7C93o kmMBZn0g2dLsw== Date: Mon, 10 Apr 2023 17:32:27 -0700 From: Jakub Kicinski To: Yan Wang Cc: davem@davemloft.net, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, John 'Warthog9' Hawley Subject: Re: [PATCH] net: stmmac:fix system hang when setting up standalone tag_8021q VLAN for DSA ports Message-ID: <20230410173227.74f9d60a@kernel.org> In-Reply-To: <20230408155823.12834-1-rocklouts@sina.com> References: <20230407195730.298867dd@kernel.org> <20230408155823.12834-1-rocklouts@sina.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230410_173231_545513_028A8DA7 X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 8 Apr 2023 23:58:23 +0800 Yan Wang wrote: > The system hang because of dsa_tag_8021q_port_setup() callbcak > stmmac_vlan_rx_add_vid().I found in stmmac_drv_probe() that > cailing pm_runtime_put() disabled the clock when check the stmmac > dirver. > > First, when the kernel is compiled with CONFIG_PM=y,The stmmac's > resume/suspend is active. > > Secondly,stmmac as DSA master,the dsa_tag_8021q_port_setup() function > will callback stmmac_vlan_rx_add_vid when DSA dirver starts. However, > The system is hanged for the stmmac_vlan_rx_add_vid() accesses its > registers after stmmac's clock is closed. > > I would suggest adding the pm_runtime_resume_and_get() to the > stmmac_vlan_rx_add_vid().This guarantees that resuming clock output > while in use. Hm, the patch is not making it to the @vger list, even tho it did make it to lore.kernel.org, it seems. I couldn't spot anything wrong with it. Could you try sending it to testing@vger.kernel.org and contacting John (added to CC) who administers vger.kernel.org, to figure out what's wrong? Based on this conversation: https://lore.kernel.org/all/9539b880-642d-9ac5-ccfa-2b237548f4fc@kernel.org/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel