From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 440A2C77B6F for ; Tue, 11 Apr 2023 12:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qTtUhfP9UczuuaNzbFCiclgwVsl3j71bzLj31QPAN3g=; b=Dwuga6bR+SG/nP hBhMJYb8mdpCS1V4TiAbtekg0vyKOWmtWObRvIkai0JuWX66bmpt0z/YPjADk+GzA1gSXucK3rGmE Myt5xJnYwh5z5kBNlUUUDkjNbKVqOQuLTMbiCemUcOXoI13rB+hB/67+zMumy+ALz2YvPSjxUkVRd zhPm4Lz59ch7Unh9xFX7JhzZBW2XqLlPIsVojTMb9h9GNRiZ9TK2H4ZrmVFYORnBE+08ZME8MwxfK 9FJssOcoqGEluhXEHeyljTw+snrjRFDbMq0F9iDczRU5fjGEdmNjGPVaoDjdP94KMf18jfFUAzjGp 5plUX48pDickd11KvDVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmDW3-0000uF-04; Tue, 11 Apr 2023 12:54:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmDW0-0000ti-12 for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 12:54:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5BC46D75; Tue, 11 Apr 2023 05:55:08 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BBC5C3F6C4; Tue, 11 Apr 2023 05:54:22 -0700 (PDT) Date: Tue, 11 Apr 2023 13:54:20 +0100 From: Sudeep Holla To: Nikunj Kela Cc: cristian.marussi@arm.com, robh+dt@kernel.org, Sudeep Holla , krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH v2 1/2] dt-bindings: firmware: arm,scmi: support parameter passing in smc/hvc Message-ID: <20230411125420.lymhjf5chxdr7if7@bogus> References: <20230409181918.29270-1-quic_nkela@quicinc.com> <20230410182058.8949-1-quic_nkela@quicinc.com> <20230410182058.8949-2-quic_nkela@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230410182058.8949-2-quic_nkela@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_055428_426737_C5047F02 X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 10, 2023 at 11:20:57AM -0700, Nikunj Kela wrote: > Currently, smc/hvc calls are made with smc-id only. The parameters are > all set to zeros. This patch defines two optional device tree bindings, > that can be used to pass parameters in smc/hvc calls. > Why 2 values ? > This is useful when multiple scmi instances are used with common smc-id. > I really would like to avoid this binding. Because of lack of standard SMC/HVC FID for SCMI we had to add this binding. Extending for newer use case like this in a vendor specific way is something I would like to avoid. > Signed-off-by: Nikunj Kela > --- > .../devicetree/bindings/firmware/arm,scmi.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5824c43e9893..ecf76b763c8c 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -115,6 +115,23 @@ properties: > description: > SMC id required when using smc or hvc transports > > + arm,smc32-params: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + An optional parameter list passed in smc32 or hvc32 calls > + default: 0 > + minItems: 1 > + maxItems: 6 > + > + arm,smc64-params: > + $ref: /schemas/types.yaml#/definitions/uint64-array > + description: > + An optional parameter list passed in smc64 or hvc64 calls. > + This is valid only on ARM64 machines. > + default: 0 > + minItems: 1 > + maxItems: 6 > + Even if we end up adding(which I would very much like to avoid), I don't see the need for 32 and 64 bit params like this. There must be ways to avoid that used by some property in some other binding(I will look for one if we choose this path) -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel