From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72787C77B6F for ; Tue, 11 Apr 2023 14:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nZdAxbqnHSVHnQeQnWnoUtAyRcSpjezdTN9euwUnVQA=; b=GuGN/vjwEihElI tH7hj8J8nne98lm5+h/TASM9xoJWVfFEstGmyTSDxiFelxY8TbW6uBxvFRr67dIWOFerX5ogmDjz9 Qo+W7tfuCE9AyITV3hBvf9M5O+VihoCbf5vro0re10R1umNkGDLG4adGh+c4cvgj4jFF2uw/qAYky 8Ypyph81g0g0jNTJ3z0tWE12StvjlH90qNLpmdIuLIUjtxQtSQO1kIB4Pmnmngoif+Zb+HM8UOxA2 at7oVdelJd/aZhY0sFU95BklpZZZL8R8gTPHkXgteyD0kMoAfIzIHRE0OhZLj7vx7P+6YGZtIu3Q4 pv3IvSUN4fXhxLed7qaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmEbS-000CRR-38; Tue, 11 Apr 2023 14:04:10 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmEbP-000CQE-2G for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 14:04:09 +0000 Received: by mail-oi1-f175.google.com with SMTP id e9so5429528oig.7 for ; Tue, 11 Apr 2023 07:04:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681221843; x=1683813843; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Aewvq7Qyi31VTr5PdaFcbjGaZV7Zh9U8Jss5DyPyZ6k=; b=KFQVbE208z8g0q7Xfb3b4a8LXhCf8FjjT5K/e+bb0HKFnE463hISclA3kb9YsBiUYZ ReOXn3wrCwBrE5xElZf9Hn1VpGnBcajkzTYviyGwJm1JjXzk4FwkXMsvrLuN1OkrKwiV IbATWinnqts7mqbBtToPf/V68rIBCFBUB/0eOqquJvcaThkmPB3ba+rZoLMnQEczPH5Y wtnsb6n3hjmRgOAgtYH8Dx7MyKlpgWEJz7vtvcxclhGM/fDwhjydDG4DKHzNCbDeFGcy OcD4XxPPxs3/m5yewQbeo1nJB0BmFPshh6ICD9a+wrhJ7pCM4rmalIxFHLuqqUMdjAAl BU/w== X-Gm-Message-State: AAQBX9fNpS+9Tqa0N9uQ3qP5PbnY+Yc+Zl3XUBbKDHU/5/j/6P5iC9GP Kk2wJs5wtpBevbl/wfLiiA== X-Google-Smtp-Source: AKy350ZtVObD4H0kcB6Kxrdgy3xaGWSl03KtG/6TAmlqg3kjYEkbJgm/DeGs/e+KiMT4OJJnhxHjjg== X-Received: by 2002:a05:6808:249:b0:387:1e71:e4d3 with SMTP id m9-20020a056808024900b003871e71e4d3mr5213892oie.11.1681221842953; Tue, 11 Apr 2023 07:04:02 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id u10-20020a056808150a00b0037832f60518sm5550740oiw.14.2023.04.11.07.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 07:04:02 -0700 (PDT) Received: (nullmailer pid 2981771 invoked by uid 1000); Tue, 11 Apr 2023 14:04:01 -0000 Date: Tue, 11 Apr 2023 09:04:01 -0500 From: Rob Herring To: Stephen Boyd Cc: Andrew Lunn , Gregory Clement , Michael Turquette , Sebastian Hesselbarth , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 2/3] clk: mvebu: Use of_get_cpu_hwid() to read CPU ID Message-ID: <20230411140401.GA2963980-robh@kernel.org> References: <20230327-mvebu-clk-fixes-v1-0-438de1026efd@kernel.org> <20230327-mvebu-clk-fixes-v1-2-438de1026efd@kernel.org> <216176104e507b860e24399bf020d836.sboyd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <216176104e507b860e24399bf020d836.sboyd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_070407_738011_FB391028 X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 10, 2023 at 04:36:21PM -0700, Stephen Boyd wrote: > Quoting Rob Herring (2023-03-27 11:43:19) > > Use of_get_cpu_hwid() rather than the open coded reading of the CPU > > nodes "reg" property. The existing code is in fact wrong as the "reg" > > address cells size is 2 cells for arm64. The existing code happens to > > work because the DTS files are wrong as well. > > > > Signed-off-by: Rob Herring > > --- > > Note this should be marked for stable so that if/when the DTS files are > > fixed, then at least stable kernels will work. This is untested, so I > > didn't mark for stable. > > That makes it sound like it breaks for existing DTS files. Is that the > case? No, if the DTS files are fixed, then they will not work with the existing code. This change should work for both existing and fixed DTS files. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel