From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD823C76196 for ; Tue, 11 Apr 2023 17:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZheHSiuVKQJdIBKgL0DvH3mwnVMmBRdMIekOtT6uAf0=; b=eiTBhwaCbxYrcH t1Vlv2JFQ2VKXUK1nxHhAGz9ntAmtH6UuGMOjrP89g/e1OE3MznvrDc6eUVBDXX/bJkY7SwMAPIbv aP5oB4f7gM2hMDpbAEvqj7fW/lsF6q00OgIMvROHDD2TIbitL1swQ1Nq03oDhvPPENwRrqv6CsARf z62rrZrRIske81zNqUgiEBzFPHj/5IR7g0ibDyKkOl4FRUnQPDn6c11unqnsHrOuDxFAYfmqeiR7j yvQHnUR9XRK401Y3fqGSywbKlL0ukpfBPo3R3zZ6yIxsxFicxgMQEXNId6+VUVEYtzhORwgGQEScM qaEsvh6/Ui8EFeDmZMLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmHhw-000hem-2F; Tue, 11 Apr 2023 17:23:04 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmHhs-000hdi-2y for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 17:23:02 +0000 Received: by mail-pj1-x102d.google.com with SMTP id e18-20020a17090ac21200b00246952d917fso7194693pjt.4 for ; Tue, 11 Apr 2023 10:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681233777; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=28t9ljw3dxSMctDXd2sUTJmBDzILsgHACRxjFVxLS2g=; b=WCYj8t8ny0LdlrIG9tCjxh22vn5C3Q1UkHnVNm8DV4PFWXeiab3ZWUu0JKZqDFS3hb dhJ7vg8LHyCJvizfoGzTjdkm1WIjegUYCj0yMkjNqwmi7W/gwjkGWG2QwlAFeeJc5tt5 ZPwz1NPP3y7nsYx292pI1mDz3ETQpdKB0VLzEpDpMVjxOWmnOHAEmNCevVUpLO7/AJp/ 6+YoEk+Uq25jEk2mS1XNWdtdDgMjz3rasye7pLXjolWaJkRa3OGAgMGtLBQd55+H6/Bq HfekeQ01+kmoh16PO6oI6vhY96ATh1utiyIQWMwjsopk/PZ7OAUvVwSX+XpNftmABfc7 Xqkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681233777; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=28t9ljw3dxSMctDXd2sUTJmBDzILsgHACRxjFVxLS2g=; b=kXLJtdfgFXLLgc//L7+SUPU+Pe/gyy7TReSOeteSDz+gOksHXcQy1dyLGZnF7mJBpJ GOB2UcR3RDXoH77x1IzjG0f3DcF13RsPAsXmucsaI+kA2prMw+74gWqWyG5LsVcl2q5a gbcrm89y2mM7AvHJrctTcle/FSQr7V1IxICUQiEiX+xFYgC3IcESNL+tLv4CiVEvZuEc 7aoFZkv1QZuLzLPqRVPgHpAC6zlKtfQ12tEVqwPL7MiwK32qNb8JABJ+vpcNlYwx2rmc SRbP7GRfaONGdARHxJbexDiAbiDibpi5qqpodoCe9yWg2ftuztKisSsW77C69kZfd814 +mOQ== X-Gm-Message-State: AAQBX9fEcMt9MhMEPaLogzOKlTLqnWkafZDP37F1RgWmHLGa3M6u9LHU ScfjwikiVfPVMwzXxOBA1QtOVw== X-Google-Smtp-Source: AKy350a5XwVObtMkbzt9yXV+8X+TW6NImWGouirRf5xPMJ8qYuLtf9KoU1ulzFiARg3bdoF+HAZX7Q== X-Received: by 2002:a17:90a:7e89:b0:240:ce2f:5fc1 with SMTP id j9-20020a17090a7e8900b00240ce2f5fc1mr18668803pjl.46.1681233777152; Tue, 11 Apr 2023 10:22:57 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:f795:eecb:467b:d183]) by smtp.gmail.com with ESMTPSA id x14-20020a17090a1f8e00b0023b3179f0fcsm11412320pja.6.2023.04.11.10.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 10:22:56 -0700 (PDT) Date: Tue, 11 Apr 2023 11:22:53 -0600 From: Mathieu Poirier To: Iuliana Prodan Cc: andersson@kernel.org, linux-remoteproc@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: Fix kernel test robot sparse warning Message-ID: <20230411172253.GA38361@p14s> References: <20230407161429.3973177-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_102300_966174_44AFE98B X-CRM114-Status: GOOD ( 22.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 11, 2023 at 02:28:34AM +0300, Iuliana Prodan wrote: > On 4/7/2023 7:14 PM, Mathieu Poirier wrote: > > This patch fixes the kernel test robot warning reported here: > > > > https://lore.kernel.org/bpf/642f916b.pPIKZ%2Fl%2F%2Fbw8tvIH%25lkp@intel.com/T/ > > > > Fixes: 408ec1ff0caa ("remoteproc: imx_dsp_rproc: Add custom memory copy implementation for i.MX DSP Cores") > > Signed-off-by: Mathieu Poirier > > Tested-by: Iuliana Prodan > Reviewed-by: Iuliana Prodan > Applied > Thanks, > Iulia > > > > --- > > > > Iuliana - please thest this on your side > > > > --- > > drivers/remoteproc/imx_dsp_rproc.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > > index 21759d9e5b7b..c805cb83cacc 100644 > > --- a/drivers/remoteproc/imx_dsp_rproc.c > > +++ b/drivers/remoteproc/imx_dsp_rproc.c > > @@ -750,12 +750,12 @@ static void imx_dsp_rproc_kick(struct rproc *rproc, int vqid) > > * The IRAM is part of the HiFi DSP. > > * According to hw specs only 32-bits writes are allowed. > > */ > > -static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size) > > +static int imx_dsp_rproc_memcpy(void *dst, const void *src, size_t size) > > { > > + void __iomem *dest = (void __iomem *)dst; > > const u8 *src_byte = src; > > const u32 *source = src; > > u32 affected_mask; > > - u32 *dst = dest; > > int i, q, r; > > u32 tmp; > > @@ -768,7 +768,7 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size) > > /* copy data in units of 32 bits at a time */ > > for (i = 0; i < q; i++) > > - writel(source[i], &dst[i]); > > + writel(source[i], dest + i * 4); > > if (r) { > > affected_mask = GENMASK(8 * r, 0); > > @@ -799,8 +799,8 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size) > > */ > > static int imx_dsp_rproc_memset(void *addr, u8 value, size_t size) > > { > > + void __iomem *tmp_dst = (void __iomem *)addr; > > u32 tmp_val = value; > > - u32 *tmp_dst = addr; > > u32 affected_mask; > > int q, r; > > u32 tmp; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel