From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBBDCC77B73 for ; Tue, 11 Apr 2023 17:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l7PSmb1oKu6PBAGnTlUKf6PA5OoxBdF/wt5FQNwWWWQ=; b=izk0Qgn+Bf03+h BbG4TQMw9xpXQ2RHLUqBgM4porh76I2peYt8x6jMERtRnrv716nz+Se3r59ZiNynBjReExsHm+v4O RGm9+AeW+qb0I5Am/2ggJPgu/LfI2O3aAgZ8XbNJ9q1g1GJOv+LbcS4p/1oKP8pUDhOq93PUuWFW1 SPvCwEmxgb2K4yfB1m0tfCir6rlivLiMeSSwmGWlErR/InDC8MigwweDUAOSbmRF9JR2n17EpNtkj muoI0Bjh8HLw6V2vXADe+9sVPxUByFlnuButFK9CBX07Cbq2o+38u+Vm0xd1sg0XaWzZ5LOWVrN4r 0HSDQP23gXZKtgiv0b0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmHrC-000ib9-2H; Tue, 11 Apr 2023 17:32:38 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmHr8-000iaT-2g for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 17:32:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681234354; x=1712770354; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IYu2VOdyLChmKOsBaksULDPYyAcnFIA61rGyIqo32/E=; b=FE7b/EFj8Mh5GtXWwusRpRIXOVI0NRwdfExbHom3bnGvuROvNFI4mF/w rolDyqeFEv/Vh/pPuYbZfhPvaNkQb5H7Mc8qyflljrHN8GpB3x6f0h1JD BfDauXF7VNYsvGyceQd57vBdapQu3iE9r1Il+3NVaOT/FdlAElseyKLnv huWVn5LtXJrhl20Ol3H5GZqMivL+q7w2FINsuD6lBXhOyTmUfb6PzlE7B mIvFMShFQrdd8cnHX3f4shwV98LbMZbQL5zcPgLltuFlArHIhHEmlODTY hT1RrM8QW7+Ay9frUHp8ICanYSNfF3GsVgXqk7S7IvsNW/V9Yp0684MQy w==; X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="343692748" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="343692748" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 10:32:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="832409212" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="832409212" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2023 10:32:26 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pmHqu-000WXz-1f; Tue, 11 Apr 2023 17:32:20 +0000 Date: Wed, 12 Apr 2023 01:31:49 +0800 From: kernel test robot To: Pankaj Gupta , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gaurav.jain@nxp.com, sahil.malhotra@nxp.com, aisheng.dong@nxp.com, V.Sethi@nxp.com Cc: oe-kbuild-all@lists.linux.dev, Pankaj Gupta Subject: Re: [NXP ELE-MUAP 6/7] firmware: imx: add ELE MU driver support Message-ID: <202304120141.95PmXzH6-lkp@intel.com> References: <20230411162536.30604-7-pankaj.gupta@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230411162536.30604-7-pankaj.gupta@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_103234_912466_1FF1D2FB X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pankaj, kernel test robot noticed the following build warnings: [auto build test WARNING on shawnguo/for-next] [also build test WARNING on robh/for-next arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next rockchip/for-next soc/for-next linus/master v6.3-rc6 next-20230411] [cannot apply to xilinx-xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Pankaj-Gupta/doc-device-tree-binding-addition-for-ele-MU/20230411-231913 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next patch link: https://lore.kernel.org/r/20230411162536.30604-7-pankaj.gupta%40nxp.com patch subject: [NXP ELE-MUAP 6/7] firmware: imx: add ELE MU driver support config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230412/202304120141.95PmXzH6-lkp@intel.com/config) compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/80f6b85e97e7f7eb4b5d59c638adb2bdbe6d48d1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Pankaj-Gupta/doc-device-tree-binding-addition-for-ele-MU/20230411-231913 git checkout 80f6b85e97e7f7eb4b5d59c638adb2bdbe6d48d1 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/firmware/imx/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304120141.95PmXzH6-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/firmware/imx/ele_mu.c: In function 'ele_mu_fops_read': >> drivers/firmware/imx/ele_mu.c:408:23: warning: variable 'header' set but not used [-Wunused-but-set-variable] 408 | struct mu_hdr header; | ^~~~~~ drivers/firmware/imx/ele_mu.c:404:29: warning: unused variable 'ele_mu_priv' [-Wunused-variable] 404 | struct ele_mu_priv *ele_mu_priv = dev_ctx->priv; | ^~~~~~~~~~~ vim +/header +408 drivers/firmware/imx/ele_mu.c 392 393 /* 394 * Read a message from the MU. 395 * Blocking until a message is available. 396 */ 397 static ssize_t ele_mu_fops_read(struct file *fp, char __user *buf, 398 size_t size, loff_t *ppos) 399 { 400 struct ele_mu_device_ctx *dev_ctx 401 = container_of(fp->private_data, 402 struct ele_mu_device_ctx, 403 miscdev); 404 struct ele_mu_priv *ele_mu_priv = dev_ctx->priv; 405 u32 data_size = 0, size_to_copy = 0; 406 struct ele_obuf_desc *b_desc; 407 int err; > 408 struct mu_hdr header; 409 410 devctx_dbg(dev_ctx, "read to buf %p(%ld), ppos=%lld\n", buf, size, 411 ((ppos) ? *ppos : 0)); 412 413 if (down_interruptible(&dev_ctx->fops_lock)) 414 return -EBUSY; 415 416 if (dev_ctx->status != MU_OPENED) { 417 err = -EINVAL; 418 goto exit; 419 } 420 421 /* Wait until the complete message is received on the MU. */ 422 err = wait_event_interruptible(dev_ctx->wq, dev_ctx->pending_hdr != 0); 423 if (err) { 424 devctx_err(dev_ctx, "Err[0x%x]:Interrupted by signal.\n", err); 425 goto exit; 426 } 427 428 devctx_dbg(dev_ctx, "%s %s\n", __func__, 429 "message received, start transmit to user"); 430 431 /* Check that the size passed as argument is larger than 432 * the one carried in the message. 433 */ 434 data_size = dev_ctx->temp_resp_size * sizeof(u32); 435 size_to_copy = data_size; 436 if (size_to_copy > size) { 437 devctx_dbg(dev_ctx, "User buffer too small (%ld < %d)\n", 438 size, size_to_copy); 439 size_to_copy = size; 440 } 441 442 /* We may need to copy the output data to user before 443 * delivering the completion message. 444 */ 445 while (!list_empty(&dev_ctx->pending_out)) { 446 b_desc = list_first_entry_or_null(&dev_ctx->pending_out, 447 struct ele_obuf_desc, 448 link); 449 if (b_desc->out_usr_ptr && b_desc->out_ptr) { 450 devctx_dbg(dev_ctx, "Copy output data to user\n"); 451 err = (int)copy_to_user(b_desc->out_usr_ptr, 452 b_desc->out_ptr, 453 b_desc->out_size); 454 if (err) { 455 devctx_err(dev_ctx, 456 "Failure copying output data to user."); 457 err = -EFAULT; 458 goto exit; 459 } 460 } 461 __list_del_entry(&b_desc->link); 462 devm_kfree(dev_ctx->dev, b_desc); 463 } 464 465 header = *((struct mu_hdr *) (&dev_ctx->temp_resp[0])); 466 467 /* Copy data from the buffer */ 468 print_hex_dump_debug("to user ", DUMP_PREFIX_OFFSET, 4, 4, 469 dev_ctx->temp_resp, size_to_copy, false); 470 err = (int)copy_to_user(buf, dev_ctx->temp_resp, size_to_copy); 471 if (err) { 472 devctx_err(dev_ctx, "Failed to copy to user\n"); 473 err = -EFAULT; 474 goto exit; 475 } 476 477 err = size_to_copy; 478 479 /* free memory allocated on the shared buffers. */ 480 dev_ctx->secure_mem.pos = 0; 481 dev_ctx->non_secure_mem.pos = 0; 482 483 dev_ctx->pending_hdr = 0; 484 485 exit: 486 487 up(&dev_ctx->fops_lock); 488 return err; 489 } 490 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel